From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM Date: Fri, 04 Mar 2016 16:05:49 +0900 Message-ID: <56D933CD.4070704@samsung.com> References: <1457053344-28992-1-git-send-email-k.kozlowski@samsung.com> <87y49yd8t6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:44546 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbcCDHF6 (ORCPT ); Fri, 4 Mar 2016 02:05:58 -0500 In-reply-to: <87y49yd8t6.fsf@gmail.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Holger Schurig Cc: Sylwester Nawrocki , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann On 04.03.2016 16:03, Holger Schurig wrote: > Krzysztof Kozlowski writes: > >> + depends on HAS_IOMEM # For MFD_SYSCON > ^^^^^^^^^^^^^^^^ > > I think this comment is not necessary, it's also highly unusual. On > other words: other patches like this don't add such comments. > > You can always use "git blame" to find out why some line has changed the > way it changed ... No problem, I can remove it. I thought it might be useful since this dependency is not for the driver but for selected item. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Fri, 04 Mar 2016 16:05:49 +0900 Subject: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM In-Reply-To: <87y49yd8t6.fsf@gmail.com> References: <1457053344-28992-1-git-send-email-k.kozlowski@samsung.com> <87y49yd8t6.fsf@gmail.com> Message-ID: <56D933CD.4070704@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04.03.2016 16:03, Holger Schurig wrote: > Krzysztof Kozlowski writes: > >> + depends on HAS_IOMEM # For MFD_SYSCON > ^^^^^^^^^^^^^^^^ > > I think this comment is not necessary, it's also highly unusual. On > other words: other patches like this don't add such comments. > > You can always use "git blame" to find out why some line has changed the > way it changed ... No problem, I can remove it. I thought it might be useful since this dependency is not for the driver but for selected item. Best regards, Krzysztof