From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52517)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1ablJ0-0003Mo-4h
	for qemu-devel@nongnu.org; Fri, 04 Mar 2016 03:41:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1ablIw-0004xY-TC
	for qemu-devel@nongnu.org; Fri, 04 Mar 2016 03:41:50 -0500
Received: from [59.151.112.132] (port=2173 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1ablIw-0004sf-02
	for qemu-devel@nongnu.org; Fri, 04 Mar 2016 03:41:46 -0500
References: <1456997052-31822-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<20160303145949.1f89d33c@nial.brq.redhat.com>
From: Cao jin <caoj.fnst@cn.fujitsu.com>
Message-ID: <56D94A85.2030202@cn.fujitsu.com>
Date: Fri, 4 Mar 2016 16:42:45 +0800
MIME-Version: 1.0
In-Reply-To: <20160303145949.1f89d33c@nial.brq.redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] correct comment of MemoryHotplugState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org, david@gibson.dropbear.id.au, ehabkost@redhat.com



On 03/03/2016 09:59 PM, Igor Mammedov wrote:
> On Thu, 3 Mar 2016 17:24:12 +0800
> Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
>
>> correct comment and remove an unused macro. commit adcb4ee6 already
>> correct its type
>>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
>
>> ---
>> Btw, in pc_memory_init(), I don`t see in which condition, the following code
>> will be executed:
>>
>>      if ((pcms->hotplug_memory.base + hotplug_mem_size) <
>>          hotplug_mem_size) {
>>          error_report("unsupported amount of maximum memory: " RAM_ADDR_FMT,
>>                        machine->maxram_size);
>>          exit(EXIT_FAILURE);
>>      }
>>
>> I appreciate if anyone could give a hint
> Integer overflow?
>

Ah yes, make sense. Thanks very much for the hint

-- 
Yours Sincerely,

Cao jin