From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH 1/3] add tx crc disable flag
Date: Fri, 4 Mar 2016 10:18:57 +0100
Message-ID: <56D95301.9050209@6wind.com>
References: <1455555325-20046-1-git-send-email-emmericp@net.in.tum.de>
 <1455555325-20046-2-git-send-email-emmericp@net.in.tum.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: Paul Emmerich <emmericp@net.in.tum.de>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 700A52BD3
 for <dev@dpdk.org>; Fri,  4 Mar 2016 10:19:04 +0100 (CET)
In-Reply-To: <1455555325-20046-2-git-send-email-emmericp@net.in.tum.de>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Paul,

On 02/15/2016 05:55 PM, Paul Emmerich wrote:
> Signed-off-by: Paul Emmerich <emmericp@net.in.tum.de>
> ---
>  lib/librte_mbuf/rte_mbuf.c | 1 +
>  lib/librte_mbuf/rte_mbuf.h | 6 ++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
> index f506517..744fb4e 100644
> --- a/lib/librte_mbuf/rte_mbuf.c
> +++ b/lib/librte_mbuf/rte_mbuf.c
> @@ -270,6 +270,7 @@ const char *rte_get_rx_ol_flag_name(uint64_t mask)
>  const char *rte_get_tx_ol_flag_name(uint64_t mask)
>  {
>  	switch (mask) {
> +	case PKT_TX_NO_CRC_CSUM: return "PKT_TX_NO_CRC_CSUM";
>  	case PKT_TX_VLAN_PKT: return "PKT_TX_VLAN_PKT";
>  	case PKT_TX_IP_CKSUM: return "PKT_TX_IP_CKSUM";
>  	case PKT_TX_TCP_CKSUM: return "PKT_TX_TCP_CKSUM";
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index ab6de67..096d84a 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -106,6 +106,12 @@ extern "C" {
>  /* add new TX flags here */
>  
>  /**
> + * Disable CRC checksum offload
> + */
> +#define PKT_TX_NO_CRC_CSUM   (1ULL << 49)
> +
> +
> +/**
>   * TCP segmentation offload. To enable this offload feature for a
>   * packet to be transmitted on hardware supporting TSO:
>   *  - set the PKT_TX_TCP_SEG flag in mbuf->ol_flags (this flag implies
> 

The patch does not apply properly. It seems you've done it on a version
that is more than 6 months old. Could you please rebase it?

My second question concerns the behavior of this flag when it is not
supported by the driver. Shouldn't we have a feature flag saying "this
driver supports CRC stripping"?

Also, I think "PKT_TX_STRIP_CRC" would be a better name.

Regards,
Olivier