From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Evan McClain <aeroevan@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>, Bryan Wu <cooloney@gmail.com>,
Simon Que <sque@chromium.org>,
Olof Johansson <olofj@chromium.org>,
Duncan Laurie <dlaurie@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: Add Chrome OS keyboard backlight LEDs driver
Date: Fri, 04 Mar 2016 10:38:40 +0100 [thread overview]
Message-ID: <56D957A0.7070300@samsung.com> (raw)
In-Reply-To: <1457080729.18482.6.camel@gmail.com>
Hi Evan,
On 03/04/2016 09:38 AM, Evan McClain wrote:
> On Thu, 2016-03-03 at 15:46 -0800, Dmitry Torokhov wrote:
>> From: Simon Que <sque@chromium.org>
>>
>> This is a driver for ACPI-based keyboard backlight LEDs found on
>> Chromebooks. The driver locates \\_SB.KBLT ACPI device and exports
>> backlight as "chromeos::kbd_backlight" LED class device in sysfs.
>
> Was it ever decided where this driver should live? I was planning on
> submitting to platform/chrome since most keyboard backlights seem to
> live over there but I don't think I got a response.
>
It hasn't been decided yet. I can take it, but could you submit one more
version, without
'owner = THIS_MODULE' in struct platform_driver keyboard_led_driver ?
It is redundant, because the core will do it.
Also the line with devm_kzalloc has over 80 characters.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2016-03-04 9:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 23:46 [PATCH] leds: Add Chrome OS keyboard backlight LEDs driver Dmitry Torokhov
2016-03-04 8:38 ` Evan McClain
2016-03-04 9:38 ` Jacek Anaszewski [this message]
2016-03-04 19:13 ` Dmitry Torokhov
2016-03-04 20:41 ` Evan McClain
2016-03-04 20:56 ` Dmitry Torokhov
2016-03-04 22:09 ` Olof Johansson
2016-03-04 20:55 ` Jacek Anaszewski
2016-03-04 20:59 ` Dmitry Torokhov
2016-03-04 21:48 ` Jacek Anaszewski
2016-03-04 9:38 ` Jacek Anaszewski
2016-03-04 19:19 ` Dmitry Torokhov
2016-03-04 19:22 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D957A0.7070300@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=aeroevan@gmail.com \
--cc=cooloney@gmail.com \
--cc=dlaurie@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=rpurdie@rpsys.net \
--cc=sque@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.