From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH v10 2/2] vhost: Add VHOST PMD Date: Fri, 4 Mar 2016 18:58:12 +0900 Message-ID: <56D95C34.2080303@igel.co.jp> References: <1455010686-21802-2-git-send-email-mukawa@igel.co.jp> <1457065062-4423-3-git-send-email-mukawa@igel.co.jp> <20160304083920.GW14300@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, ann.zhuangyanying@huawei.com, yuanhan.liu@intel.com To: Yuanhan Liu Return-path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 140B62946 for ; Fri, 4 Mar 2016 10:58:13 +0100 (CET) Received: by mail-pa0-f47.google.com with SMTP id fl4so32430341pad.0 for ; Fri, 04 Mar 2016 01:58:13 -0800 (PST) In-Reply-To: <20160304083920.GW14300@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2016/03/04 17:39, Yuanhan Liu wrote: > On Fri, Mar 04, 2016 at 01:17:42PM +0900, Tetsuya Mukawa wrote: >> The patch introduces a new PMD. This PMD is implemented as thin wrapper >> of librte_vhost. It means librte_vhost is also needed to compile the PMD. >> The vhost messages will be handled only when a port is started. So start >> a port first, then invoke QEMU. >> >> The PMD has 2 parameters. >> - iface: The parameter is used to specify a path to connect to a >> virtio-net device. >> - queues: The parameter is used to specify the number of the queues >> virtio-net device has. >> (Default: 1) >> >> Here is an example. >> $ ./testpmd -c f -n 4 --vdev 'eth_vhost0,iface=/tmp/sock0,queues=1' -- -i >> >> To connect above testpmd, here is qemu command example. >> >> $ qemu-system-x86_64 \ >> >> -chardev socket,id=chr0,path=/tmp/sock0 \ >> -netdev vhost-user,id=net0,chardev=chr0,vhostforce,queues=1 \ >> -device virtio-net-pci,netdev=net0,mq=on >> >> Signed-off-by: Tetsuya Mukawa >> Acked-by: Ferruh Yigit > You should carry my Acked-by that I gave few versions before, as well > as the Reviewed-by and Tested-by from Rich, if my memory serves me > right. It's also a way to show respects to the reivew/test efforts > from them. Sure, I will submit one more patch, and will add them. >> --- >> MAINTAINERS | 4 + > Mind to add me to the MAINTAINER list as well if you send another > version? :) If so, don't put my email address wrongly, which you > have done many times ;-) Thank you so much for it. And sorry I get wrong your email address. I will add you in MAINTAINERS in next patch. Thanks, Tetsuya > --yliu