From: Alexandre Torgue <alexandre.torgue@st.com>
To: kbuild test robot <fengguang.wu@intel.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: <kbuild-all@01.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] stmmac: fix noderef.cocci warnings
Date: Fri, 4 Mar 2016 13:45:40 +0100 [thread overview]
Message-ID: <56D98374.6020003@st.com> (raw)
In-Reply-To: <20160303015519.GA43500@lkp-nex06>
Hi,
On 03/03/2016 02:55 AM, kbuild test robot wrote:
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:115:15-21: ERROR: application of sizeof to pointer
>
> sizeof when applied to a pointer typed expression gives the size of
> the pointer
>
> Generated by: scripts/coccinelle/misc/noderef.cocci
>
> CC: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>
> stmmac_platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -112,7 +112,7 @@ static struct stmmac_axi *stmmac_axi_set
> if (!np)
> return NULL;
>
> - axi = kzalloc(sizeof(axi), GFP_KERNEL);
> + axi = kzalloc(sizeof(*axi), GFP_KERNEL);
> if (!axi)
> return ERR_PTR(-ENOMEM);
>
>
Thanks.
You can add my Acked-by: Alexandre Torgue <alexandre.torgue@st.com>
--
Regards
Alex
next prev parent reply other threads:[~2016-03-04 12:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 1:55 [net-next:master 963/985] drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:115:15-21: ERROR: application of sizeof to pointer kbuild test robot
2016-03-03 1:55 ` [PATCH] stmmac: fix noderef.cocci warnings kbuild test robot
2016-03-04 12:45 ` Alexandre Torgue [this message]
2016-03-04 21:32 ` David Miller
2016-03-07 3:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D98374.6020003@st.com \
--to=alexandre.torgue@st.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.