From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abrba-0002rs-B0 for qemu-devel@nongnu.org; Fri, 04 Mar 2016 10:25:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abrbX-0008St-KT for qemu-devel@nongnu.org; Fri, 04 Mar 2016 10:25:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abrbX-0008Sn-ES for qemu-devel@nongnu.org; Fri, 04 Mar 2016 10:25:23 -0500 References: <1457021813-10704-1-git-send-email-eblake@redhat.com> <1457021813-10704-10-git-send-email-eblake@redhat.com> <8737s6xq5j.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56D9A8E1.20105@redhat.com> Date: Fri, 4 Mar 2016 08:25:21 -0700 MIME-Version: 1.0 In-Reply-To: <8737s6xq5j.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N7MQ0AjbbNpQXj1mPm4jCjp6rVUMp5bXv" Subject: Re: [Qemu-devel] [PATCH v3 09/10] chardev: Drop useless ChardevDummy type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Samuel Thibault , qemu-devel@nongnu.org, Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --N7MQ0AjbbNpQXj1mPm4jCjp6rVUMp5bXv Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/04/2016 07:40 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Commit d0d7708b made ChardevDummy be an empty wrapper type around >> ChardevCommon. But there is no technical reason for this indirection,= >> so simplify the code by directly using the base type. >> >> Also change the fallback assignment to assign u.null rather than >> u.data, since a future patch will remove the data member of the C >> struct generated for QAPI unions. >> >> Signed-off-by: Eric Blake >> Reviewed-by: Daniel P. Berrange >=20 > Doesn't compile with MinGW: >=20 > qemu/qemu-char.c: In function 'qemu_chr_open_win_con': > qemu/qemu-char.c:2186:29: warning: implicit declaration of function 'qa= pi_ChardevDummy_base' [-Wimplicit-function-declaration] > ChardevCommon *common =3D qapi_ChardevDummy_base(backend->u.consol= e); > ^ The curse of not compiling all the backends, and failing to grep for ChardevDummy. Replacement patch coming up soon. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --N7MQ0AjbbNpQXj1mPm4jCjp6rVUMp5bXv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW2ajhAAoJEKeha0olJ0Nqp3YH/12nSyRh0c+i/tWXmSGF4LJG O5UiUURnpd9tS5yUoBVJXqqyIUTD0hLz4PA2tisTOVvyNHD+cpw+bzbFBEzItMVr vZP6F+NfyX+ISdOyBTV+V6f5swSEB/IRk2DQi1sLF3OhIJmurszQtrAkfk9nvxU9 XisnDBQ4qfHQffuTh+7YUAGw8U2NYuBQvsF8zMtdmVaP5C/FxgMFTxE/5K7MO/Bt DE6I/kogpg6xxtoUTTkgK0v8UauGlhLd7QBSMiiuUkNh4b1CuA4nEiy8XVlokuqz 60DDCUqhjSaRfiJWiXOzXaKyG9JVWEmEj+F4rNEOuC2Ulo9LohAK/08Ap4IZiKc= =9Fjv -----END PGP SIGNATURE----- --N7MQ0AjbbNpQXj1mPm4jCjp6rVUMp5bXv--