From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>, Peter Feiner <pfeiner@google.com>
Cc: kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests] arm: fix parallel build (make -j)
Date: Fri, 4 Mar 2016 16:45:09 +0100 [thread overview]
Message-ID: <56D9AD85.7050904@redhat.com> (raw)
In-Reply-To: <20160304110458.GA3641@localhost.redhat.com>
On 04/03/2016 12:04, Andrew Jones wrote:
>> > +
>> > +$(TEST_DIR)/selftest.o $(TEST_DIR)/spinlock-test.o $(cstart.o): $(asm-offsets)
> You know a project is really growing when you need 'make -j' :-)
>
> How about this patch instead though
>
> -test_cases: $(generated_files) $(tests-common) $(tests)
> +test_cases: $(tests-common) $(tests)
> +$(patsubst %.flat,%.o,$(tests-common) $(tests)) $(cstart.o): $(generated_files)
>
> Or, hmm, actually any $(TEST_DIR)/ lib/$(TEST_DIR)/ or lib/$(ARCH)/
> source file could depend on asm-offsets. So the above probably isn't
> sufficient for the long term either.
I expect a relatively small part of the .o files to need asm-offsets, so
I'm going with Peter's patch.
Paolo
next prev parent reply other threads:[~2016-03-04 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 21:41 [kvm-unit-tests] arm: fix parallel build (make -j) Peter Feiner
2016-03-04 11:04 ` Andrew Jones
2016-03-04 15:45 ` Paolo Bonzini [this message]
2016-03-04 16:28 ` Andrew Jones
2016-03-04 17:03 ` Peter Feiner
2016-03-04 17:04 ` [PATCH kvm-unit-tests v2] " Peter Feiner
2016-03-04 18:34 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D9AD85.7050904@redhat.com \
--to=pbonzini@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pfeiner@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.