From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 98490E00CD1; Fri, 4 Mar 2016 08:48:52 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [134.134.136.24 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 471A1E00AB6 for ; Fri, 4 Mar 2016 08:48:50 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 04 Mar 2016 08:48:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,536,1449561600"; d="scan'208";a="59923710" Received: from gmilescu-mobl1.ger.corp.intel.com (HELO [10.252.19.28]) ([10.252.19.28]) by fmsmga004.fm.intel.com with ESMTP; 04 Mar 2016 08:48:48 -0800 To: Dave Lerner , toaster@yoctoproject.org, belen.barros.pena@linux.intel.com References: <1457041393-4803-1-git-send-email-dave.lerner@windriver.com> From: Michael Wood Message-ID: <56D9BC6F.9090606@intel.com> Date: Fri, 4 Mar 2016 16:48:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1457041393-4803-1-git-send-email-dave.lerner@windriver.com> Subject: Re: [PATCH 1/1 v2] toaster: fixup dependency excludes for customimage X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2016 16:48:52 -0000 Content-Type: text/plain; charset="windows-1252"; format="flowed" Content-Transfer-Encoding: quoted-printable Thanks Dave Sent to bitbake-devel and committed to toaster-next Michael On 03/03/16 21:43, Dave Lerner wrote: > [YOCTO #9156] > > For a customized image when adding a dependent package X that depends on > dependency package Y, in addition to adding X to appends_set and Y to > includes_set, make sure that Y is no longer in the excludes_set. Y may > have been added to the excludes_set by a prior package removal. > > Signed-off-by: Dave Lerner > --- > bitbake/lib/toaster/toastergui/views.py | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/bitbake/lib/toaster/toastergui/views.py b/bitbake/lib/toaste= r/toastergui/views.py > index 28b03d3..f3b8d3c 100755 > --- a/bitbake/lib/toaster/toastergui/views.py > +++ b/bitbake/lib/toaster/toastergui/views.py > @@ -2653,6 +2653,13 @@ if True: > name=3Ddep.depends_on.name) > = > recipe.includes_set.add(cust_package) > + try: > + # when adding the pre-requisite package make= sure it's not in the > + # excluded list from a prior removal. > + recipe.excludes_set.remove(cust_package) > + except Package.DoesNotExist: > + # Don't care if the package had never been= excluded > + pass > except: > logger.warning("Could not add package's suggest= ed" > "dependencies to the list") --------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.