From mboxrd@z Thu Jan 1 00:00:00 1970 From: "pankaj.dubey" Subject: Re: [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree binding Date: Sat, 05 Mar 2016 11:48:39 +0530 Message-ID: <56DA7A3F.4060105@samsung.com> References: <1456389222-12738-1-git-send-email-pankaj.dubey@samsung.com> <1456389222-12738-2-git-send-email-pankaj.dubey@samsung.com> <20160302175319.GA11155@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:56508 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbcCEGRM (ORCPT ); Sat, 5 Mar 2016 01:17:12 -0500 In-reply-to: <20160302175319.GA11155@rob-hp-laptop> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Rob Herring Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kgene.kim@samsung.com, k.kozlowski@samsung.com, thomas.ab@samsung.com, olof@lixom.net, p.fedin@samsung.com, Mark Rutland , Ian Campbell , devicetree@vger.kernel.org, Kukjin Kim Hi On Wednesday 02 March 2016 11:23 PM, Rob Herring wrote: > On Thu, Feb 25, 2016 at 02:03:37PM +0530, Pankaj Dubey wrote: >> This patch adds exynos-srom binding information for SROM Controller >> driver on Exynos SoCs. >> >> CC: Rob Herring >> CC: Mark Rutland >> CC: Ian Campbell >> CC: devicetree@vger.kernel.org >> Signed-off-by: Pankaj Dubey >> Reviewed-by: Krzysztof Kozlowski >> Signed-off-by: Kukjin Kim >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../devicetree/bindings/memory-controllers/exynos-srom.txt | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt >> >> diff --git a/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt >> new file mode 100644 >> index 0000000..33886d5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt >> @@ -0,0 +1,12 @@ >> +SAMSUNG Exynos SoCs SROM Controller driver. >> + >> +Required properties: >> +- compatible : Should contain "samsung,exynos-srom". > > There should be SoC specific compatible strings in addition to this. > I do not understood need of additional SoC specific compatible here. As of now all SoCs having SROM can work with exynos specific common compatible. Do you see any issues if we do not have SoC specific compatible here. >> + >> +- reg: offset and length of the register set >> + >> +Example: >> + sromc@12570000 { > > This should be memory-controller@... > >> + compatible = "samsung,exynos-srom"; >> + reg = <0x12570000 0x10>; > > The next patch changes the size to 0x14? > > BTW, you could just combine both patches. I guess you didn't to maintain > authorship? > OK. Will squash both of these patches, unless Pavel do not have any objections to this. Thanks, Pankaj Dubey > Rob > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: pankaj.dubey@samsung.com (pankaj.dubey) Date: Sat, 05 Mar 2016 11:48:39 +0530 Subject: [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree binding In-Reply-To: <20160302175319.GA11155@rob-hp-laptop> References: <1456389222-12738-1-git-send-email-pankaj.dubey@samsung.com> <1456389222-12738-2-git-send-email-pankaj.dubey@samsung.com> <20160302175319.GA11155@rob-hp-laptop> Message-ID: <56DA7A3F.4060105@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi On Wednesday 02 March 2016 11:23 PM, Rob Herring wrote: > On Thu, Feb 25, 2016 at 02:03:37PM +0530, Pankaj Dubey wrote: >> This patch adds exynos-srom binding information for SROM Controller >> driver on Exynos SoCs. >> >> CC: Rob Herring >> CC: Mark Rutland >> CC: Ian Campbell >> CC: devicetree at vger.kernel.org >> Signed-off-by: Pankaj Dubey >> Reviewed-by: Krzysztof Kozlowski >> Signed-off-by: Kukjin Kim >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../devicetree/bindings/memory-controllers/exynos-srom.txt | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt >> >> diff --git a/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt >> new file mode 100644 >> index 0000000..33886d5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt >> @@ -0,0 +1,12 @@ >> +SAMSUNG Exynos SoCs SROM Controller driver. >> + >> +Required properties: >> +- compatible : Should contain "samsung,exynos-srom". > > There should be SoC specific compatible strings in addition to this. > I do not understood need of additional SoC specific compatible here. As of now all SoCs having SROM can work with exynos specific common compatible. Do you see any issues if we do not have SoC specific compatible here. >> + >> +- reg: offset and length of the register set >> + >> +Example: >> + sromc at 12570000 { > > This should be memory-controller at ... > >> + compatible = "samsung,exynos-srom"; >> + reg = <0x12570000 0x10>; > > The next patch changes the size to 0x14? > > BTW, you could just combine both patches. I guess you didn't to maintain > authorship? > OK. Will squash both of these patches, unless Pavel do not have any objections to this. Thanks, Pankaj Dubey > Rob > >