From: "Michel Dänzer" <michel@daenzer.net>
To: Mario Kleiner <mario.kleiner.de@gmail.com>,
Alex Deucher <alexander.deucher@amd.com>
Cc: dan.carpenter@oracle.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/amdgpu: Fix error handling in amdgpu_flip_work_func.
Date: Sat, 5 Mar 2016 17:00:43 +0900 [thread overview]
Message-ID: <56DA922B.9000405@daenzer.net> (raw)
In-Reply-To: <1456864277-9551-1-git-send-email-mario.kleiner.de@gmail.com>
On 02.03.2016 05:31, Mario Kleiner wrote:
> The patch e1d09dc0ccc6: "drm/amdgpu: Don't hang in
> amdgpu_flip_work_func on disabled crtc." from Feb 19, 2016, leads to
> the following static checker warning, as reported by Dan Carpenter in
> https://lists.freedesktop.org/archives/dri-devel/2016-February/101987.html
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:127 amdgpu_flip_work_func() warn: should this be 'repcnt == -1'
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:136 amdgpu_flip_work_func() error: double unlock 'spin_lock:&crtc->dev->event_lock'
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:136 amdgpu_flip_work_func() error: double unlock 'irqsave:flags'
>
> This patch fixes both reported problems:
>
> Change post-decrement of repcnt to pre-decrement, so
> it can't underflow anymore, but still performs up to
> three repetitions - three is the maximum one could
> expect in practice.
>
> Move the spin_unlock_irqrestore to where it actually
> belongs.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
> Cc: <stable@vger.kernel.org> # 4.4+
> Cc: Michel Dänzer <michel.daenzer@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
Both patches are
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Alex, these should go into 4.5 if at all possible.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-03-05 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 20:31 [PATCH 1/2] drm/amdgpu: Fix error handling in amdgpu_flip_work_func Mario Kleiner
2016-03-01 20:31 ` [PATCH 2/2] drm/radeon: Fix error handling in radeon_flip_work_func Mario Kleiner
2016-03-05 8:00 ` Michel Dänzer [this message]
2016-03-05 17:32 ` [PATCH 1/2] drm/amdgpu: Fix error handling in amdgpu_flip_work_func Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DA922B.9000405@daenzer.net \
--to=michel@daenzer.net \
--cc=alexander.deucher@amd.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=mario.kleiner.de@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.