From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH v2] serial: core: remove baud_rates when serial console setup Date: Sat, 5 Mar 2016 18:21:51 +0800 Message-ID: <56DAB33F.50802@gmail.com> References: <1451894086-20435-1-git-send-email-jeffy.chen@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1451894086-20435-1-git-send-email-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Jeffy Chen , gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org Cc: Heiko Stuebner , Doug Anderson , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jslaby-IBi9RG/b67k@public.gmane.org, Caesar Wang List-Id: linux-rockchip.vger.kernel.org SGksCgpJIGRvbid0IHNlZSB0aGlzIHBhdGNoIGluIG1haW5saW5lLjotKApTb3JyeSBmb3Igbm9p c2UgaWYgdGhpcyBwYXRjaCBoYXMgYXBwbGllZCBieSBHcmVnLgoK5ZyoIDIwMTblubQwMeaciDA0 5pelIDE1OjU0LCBKZWZmeSBDaGVuIOWGmemBkzoKPiBDdXJyZW50bHksIHdoZW4gdHJpbmcgdG8g c2V0IHVwIGEgc2VyaWFsIGNvbnNvbGUgd2l0aCBhIGhpZ2hlcgo+IGJhdWQgcmF0ZSwgaXQgd291 bGQgZmFsbGJhY2sgdG8gOTIxNjAwLgo+Cj4gVGVzdGVkLWJ5OiBKaWFucXVuIFh1IDxqYXkueHVA cm9jay1jaGlwcy5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSmVmZnkgQ2hlbiA8amVmZnkuY2hlbkBy b2NrLWNoaXBzLmNvbT4KClZlcmlmaWVkIG9uIFJLMzIyOC9SSzMyMjkgU29Dcy4KVGVzdGVkLWJ5 OiBDYWVzYXIgV2FuZyA8d3h0QHJvY2stY2hpcHMuY29tPgoKCj4KPiAtLS0KPgo+IENoYW5nZXMg aW4gdjI6Cj4gcmVtb3ZlIGJhdWRfcmF0ZXMgYXMgQWxhbidzIHN1Z2dlc3Rpb24uCj4KPiAgIGRy aXZlcnMvdHR5L3NlcmlhbC9zZXJpYWxfY29yZS5jIHwgMzMgKystLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAzMSBkZWxl dGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3R0eS9zZXJpYWwvc2VyaWFsX2NvcmUu YyBiL2RyaXZlcnMvdHR5L3NlcmlhbC9zZXJpYWxfY29yZS5jCj4gaW5kZXggZGVmNTE5OS4uMTUw NTQ3YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3R0eS9zZXJpYWwvc2VyaWFsX2NvcmUuYwo+ICsr KyBiL2RyaXZlcnMvdHR5L3NlcmlhbC9zZXJpYWxfY29yZS5jCj4gQEAgLTE4OTIsMjYgKzE4OTIs NiBAQCB1YXJ0X3BhcnNlX29wdGlvbnMoY2hhciAqb3B0aW9ucywgaW50ICpiYXVkLCBpbnQgKnBh cml0eSwgaW50ICpiaXRzLCBpbnQgKmZsb3cpCj4gICB9Cj4gICBFWFBPUlRfU1lNQk9MX0dQTCh1 YXJ0X3BhcnNlX29wdGlvbnMpOwo+ICAgCj4gLXN0cnVjdCBiYXVkX3JhdGVzIHsKPiAtCXVuc2ln bmVkIGludCByYXRlOwo+IC0JdW5zaWduZWQgaW50IGNmbGFnOwo+IC19Owo+IC0KPiAtc3RhdGlj IGNvbnN0IHN0cnVjdCBiYXVkX3JhdGVzIGJhdWRfcmF0ZXNbXSA9IHsKPiAtCXsgOTIxNjAwLCBC OTIxNjAwIH0sCj4gLQl7IDQ2MDgwMCwgQjQ2MDgwMCB9LAo+IC0JeyAyMzA0MDAsIEIyMzA0MDAg fSwKPiAtCXsgMTE1MjAwLCBCMTE1MjAwIH0sCj4gLQl7ICA1NzYwMCwgQjU3NjAwICB9LAo+IC0J eyAgMzg0MDAsIEIzODQwMCAgfSwKPiAtCXsgIDE5MjAwLCBCMTkyMDAgIH0sCj4gLQl7ICAgOTYw MCwgQjk2MDAgICB9LAo+IC0JeyAgIDQ4MDAsIEI0ODAwICAgfSwKPiAtCXsgICAyNDAwLCBCMjQw MCAgIH0sCj4gLQl7ICAgMTIwMCwgQjEyMDAgICB9LAo+IC0JeyAgICAgIDAsIEIzODQwMCAgfQo+ IC19Owo+IC0KPiAgIC8qKgo+ICAgICoJdWFydF9zZXRfb3B0aW9ucyAtIHNldHVwIHRoZSBzZXJp YWwgY29uc29sZSBwYXJhbWV0ZXJzCj4gICAgKglAcG9ydDogcG9pbnRlciB0byB0aGUgc2VyaWFs IHBvcnRzIHVhcnRfcG9ydCBzdHJ1Y3R1cmUKPiBAQCAtMTkyNyw3ICsxOTA3LDYgQEAgdWFydF9z ZXRfb3B0aW9ucyhzdHJ1Y3QgdWFydF9wb3J0ICpwb3J0LCBzdHJ1Y3QgY29uc29sZSAqY28sCj4g ICB7Cj4gICAJc3RydWN0IGt0ZXJtaW9zIHRlcm1pb3M7Cj4gICAJc3RhdGljIHN0cnVjdCBrdGVy bWlvcyBkdW1teTsKPiAtCWludCBpOwo+ICAgCj4gICAJLyoKPiAgIAkgKiBFbnN1cmUgdGhhdCB0 aGUgc2VyaWFsIGNvbnNvbGUgbG9jayBpcyBpbml0aWFsaXNlZAo+IEBAIC0xOTQyLDE2ICsxOTIx LDggQEAgdWFydF9zZXRfb3B0aW9ucyhzdHJ1Y3QgdWFydF9wb3J0ICpwb3J0LCBzdHJ1Y3QgY29u c29sZSAqY28sCj4gICAKPiAgIAltZW1zZXQoJnRlcm1pb3MsIDAsIHNpemVvZihzdHJ1Y3Qga3Rl cm1pb3MpKTsKPiAgIAo+IC0JdGVybWlvcy5jX2NmbGFnID0gQ1JFQUQgfCBIVVBDTCB8IENMT0NB TDsKPiAtCj4gLQkvKgo+IC0JICogQ29uc3RydWN0IGEgY2ZsYWcgc2V0dGluZy4KPiAtCSAqLwo+ IC0JZm9yIChpID0gMDsgYmF1ZF9yYXRlc1tpXS5yYXRlOyBpKyspCj4gLQkJaWYgKGJhdWRfcmF0 ZXNbaV0ucmF0ZSA8PSBiYXVkKQo+IC0JCQlicmVhazsKPiAtCj4gLQl0ZXJtaW9zLmNfY2ZsYWcg fD0gYmF1ZF9yYXRlc1tpXS5jZmxhZzsKPiArCXRlcm1pb3MuY19jZmxhZyB8PSBDUkVBRCB8IEhV UENMIHwgQ0xPQ0FMOwo+ICsJdHR5X3Rlcm1pb3NfZW5jb2RlX2JhdWRfcmF0ZSgmdGVybWlvcywg YmF1ZCwgYmF1ZCk7Cj4gICAKPiAgIAlpZiAoYml0cyA9PSA3KQo+ICAgCQl0ZXJtaW9zLmNfY2Zs YWcgfD0gQ1M3OwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760558AbcCEKWT (ORCPT ); Sat, 5 Mar 2016 05:22:19 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34748 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755535AbcCEKWE (ORCPT ); Sat, 5 Mar 2016 05:22:04 -0500 Subject: Re: [PATCH v2] serial: core: remove baud_rates when serial console setup To: Jeffy Chen , gregkh@linuxfoundation.org References: <1451894086-20435-1-git-send-email-jeffy.chen@rock-chips.com> Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, jslaby@suse.com, linux-rockchip@lists.infradead.org, Doug Anderson , Caesar Wang , Heiko Stuebner From: Caesar Wang Message-ID: <56DAB33F.50802@gmail.com> Date: Sat, 5 Mar 2016 18:21:51 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1451894086-20435-1-git-send-email-jeffy.chen@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I don't see this patch in mainline.:-( Sorry for noise if this patch has applied by Greg. 在 2016年01月04日 15:54, Jeffy Chen 写道: > Currently, when tring to set up a serial console with a higher > baud rate, it would fallback to 921600. > > Tested-by: Jianqun Xu > Signed-off-by: Jeffy Chen Verified on RK3228/RK3229 SoCs. Tested-by: Caesar Wang > > --- > > Changes in v2: > remove baud_rates as Alan's suggestion. > > drivers/tty/serial/serial_core.c | 33 ++------------------------------- > 1 file changed, 2 insertions(+), 31 deletions(-) > > diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c > index def5199..150547c 100644 > --- a/drivers/tty/serial/serial_core.c > +++ b/drivers/tty/serial/serial_core.c > @@ -1892,26 +1892,6 @@ uart_parse_options(char *options, int *baud, int *parity, int *bits, int *flow) > } > EXPORT_SYMBOL_GPL(uart_parse_options); > > -struct baud_rates { > - unsigned int rate; > - unsigned int cflag; > -}; > - > -static const struct baud_rates baud_rates[] = { > - { 921600, B921600 }, > - { 460800, B460800 }, > - { 230400, B230400 }, > - { 115200, B115200 }, > - { 57600, B57600 }, > - { 38400, B38400 }, > - { 19200, B19200 }, > - { 9600, B9600 }, > - { 4800, B4800 }, > - { 2400, B2400 }, > - { 1200, B1200 }, > - { 0, B38400 } > -}; > - > /** > * uart_set_options - setup the serial console parameters > * @port: pointer to the serial ports uart_port structure > @@ -1927,7 +1907,6 @@ uart_set_options(struct uart_port *port, struct console *co, > { > struct ktermios termios; > static struct ktermios dummy; > - int i; > > /* > * Ensure that the serial console lock is initialised > @@ -1942,16 +1921,8 @@ uart_set_options(struct uart_port *port, struct console *co, > > memset(&termios, 0, sizeof(struct ktermios)); > > - termios.c_cflag = CREAD | HUPCL | CLOCAL; > - > - /* > - * Construct a cflag setting. > - */ > - for (i = 0; baud_rates[i].rate; i++) > - if (baud_rates[i].rate <= baud) > - break; > - > - termios.c_cflag |= baud_rates[i].cflag; > + termios.c_cflag |= CREAD | HUPCL | CLOCAL; > + tty_termios_encode_baud_rate(&termios, baud, baud); > > if (bits == 7) > termios.c_cflag |= CS7;