From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] Reviewed-by
Date: Sat, 5 Mar 2016 16:55:10 +0100 [thread overview]
Message-ID: <56DB015E.1090205@gmail.com> (raw)
In-Reply-To: <1456883894-25867-1-git-send-email-rprebello@gmail.com>
Hi Rodrigo,
Le 02/03/2016 02:58, Rodrigo Rebello a ?crit :
> A 'Libs.private' field needs to be present and properly defined in the
> pkg-config file in order for static linking against SDL_mixer to work.
>
> Besides adding the mentioned field, the included patch also modifies
> configure.in so that EXTRA_LDFLAGS (which is now also used as the value
> of 'Libs.private') no longer includes SDL_LIBS. This is done so as to
> prevent libraries required by SDL from being listed twice when
> 'pkg-config --libs --static SDL_mixer' is run (they're already shown
> because of the 'Requires: sdl' line in SDL_mixer.pc). Makefile.in is
> adjusted accordingly as well.
>
> Also enable autoreconf for this package since we're patching
> configure.in.
>
> Signed-off-by: Rodrigo Rebello <rprebello@gmail.com>
> ---
> Changes v1 -> v2:
> - Add host-autoconf host-automake and host-libtool to
> SDL_MIXER_DEPENDENCIES (Thomas Petazzoni)
>
> Changes v2 -> v3:
> - Use SDL_MIXER_AUTORECONF instead of pre-configure hook
> (Arnout Vandecappelle)
> ---
Reviewed-by: Romain Naour <romain.naour@gmail.com>
Best regards,
Romain
next prev parent reply other threads:[~2016-03-05 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 1:58 [Buildroot] [PATCH v3 1/2] sdl_mixer: add patch to fix SDL_mixer.pc for static linking Rodrigo Rebello
2016-03-02 1:58 ` [Buildroot] [PATCH v3 2/2] chocolate-doom: add patch to fix " Rodrigo Rebello
2016-03-02 18:24 ` Arnout Vandecappelle
2016-03-05 15:56 ` [Buildroot] Best regards Romain Naour
2016-03-02 18:21 ` [Buildroot] [PATCH v3 1/2] sdl_mixer: add patch to fix SDL_mixer.pc for static linking Arnout Vandecappelle
2016-03-02 21:31 ` Rodrigo Rebello
2016-03-05 15:55 ` Romain Naour [this message]
2016-03-06 15:00 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DB015E.1090205@gmail.com \
--to=romain.naour@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.