All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Martin Kepplinger <martink@posteo.de>,
	knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	christoph.muellner@theobroma-systems.com, mfuzzey@parkeon.com
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] iio: mma8452: coding style fixes
Date: Sat, 5 Mar 2016 17:19:35 +0000	[thread overview]
Message-ID: <56DB1527.9080509@kernel.org> (raw)
In-Reply-To: <1456993444-21320-2-git-send-email-martink@posteo.de>

On 03/03/16 08:24, Martin Kepplinger wrote:
> fix checkpatch issues like "space before tabs", too long lines or alignment.
> 
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
Applied to the togreg branch of iio.git - initially pushed out as testing.

Thanks,

Jonathan
> ---
>  drivers/iio/accel/mma8452.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 7f4994f..17d72bc 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -357,7 +357,8 @@ static int mma8452_read_raw(struct iio_dev *indio_dev,
>  		return IIO_VAL_INT_PLUS_MICRO;
>  	case IIO_CHAN_INFO_CALIBBIAS:
>  		ret = i2c_smbus_read_byte_data(data->client,
> -					      MMA8452_OFF_X + chan->scan_index);
> +					       MMA8452_OFF_X +
> +					       chan->scan_index);
>  		if (ret < 0)
>  			return ret;
>  
> @@ -418,7 +419,7 @@ fail:
>  	return ret;
>  }
>  
> -/* returns >0 if in freefall mode, 0 if not or <0 if an error occured */
> +/* returns >0 if in freefall mode, 0 if not or <0 if an error occurred */
>  static int mma8452_freefall_mode_enabled(struct mma8452_data *data)
>  {
>  	int val;
> @@ -668,7 +669,8 @@ static int mma8452_read_event_config(struct iio_dev *indio_dev,
>  		if (ret < 0)
>  			return ret;
>  
> -		return !!(ret & BIT(chan->scan_index + chip->ev_cfg_chan_shift));
> +		return !!(ret & BIT(chan->scan_index +
> +				    chip->ev_cfg_chan_shift));
>  	default:
>  		return -EINVAL;
>  	}
> @@ -1003,7 +1005,7 @@ static const struct mma_chip_info mma_chip_info_table[] = {
>  		 * bit.
>  		 * The userspace interface uses m/s^2 and we declare micro units
>  		 * So scale factor for 12 bit here is given by:
> -		 * 	g * N * 1000000 / 2048 for N = 2, 4, 8 and g=9.80665
> +		 *	g * N * 1000000 / 2048 for N = 2, 4, 8 and g=9.80665
>  		 */
>  		.mma_scales = { {0, 2394}, {0, 4788}, {0, 9577} },
>  		.ev_cfg = MMA8452_TRANSIENT_CFG,
> 


  reply	other threads:[~2016-03-05 17:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03  8:24 iio: mma8452: power saving features for v4.7 Martin Kepplinger
2016-03-03  8:24 ` [PATCH 1/4] iio: mma8452: coding style fixes Martin Kepplinger
2016-03-05 17:19   ` Jonathan Cameron [this message]
2016-03-03  8:24 ` [PATCH 2/4] iio: mma8452: avoid switching to active because of config change Martin Kepplinger
2016-03-05 17:23   ` Jonathan Cameron
2016-03-03  8:24 ` [PATCH 3/4] iio: mma8452: add support for runtime power management Martin Kepplinger
2016-03-06 12:59   ` Jonathan Cameron
2016-03-03  8:24 ` [PATCH 4/4] iio: mma8452: add low_power mode Martin Kepplinger
2016-03-05 17:40   ` Jonathan Cameron
2016-03-06 15:49     ` Martin Kepplinger
2016-03-09 21:17       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56DB1527.9080509@kernel.org \
    --to=jic23@kernel.org \
    --cc=christoph.muellner@theobroma-systems.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martink@posteo.de \
    --cc=mfuzzey@parkeon.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.