From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <mranostay@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: matt.ranostay@intel.com, linux-iio@vger.kernel.org
Subject: Re: iio: imu: mpu6050: add mpu6500 register settings
Date: Sat, 5 Mar 2016 17:50:42 +0000 [thread overview]
Message-ID: <56DB1C72.5060407@kernel.org> (raw)
In-Reply-To: <21021227-E4C9-4D25-BD2A-F9A42927B1FD@gmail.com>
On 02/03/16 22:04, Matt Ranostay wrote:
> Will fix and submit this afternoon!
>
> Sent from my iPhone
>
>> On Mar 2, 2016, at 10:21, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>>
>> I sent that too quickly. The i2c version of inv_mpu_probe() has the
>> same issue as well.
>>
>> drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c:134 inv_mpu_probe()
>> error: we previously assumed 'id' could be null (see line 119)
>>
>> regards,
>> dan carpenter
Whilst true, I'm now wondering why we assumed it might be. Paranoia perhaps?
Hmm, guess we should keep it consistent (he says having just bounced this
back to Matt)- I'll take it as is but as a cleanup rather than a fix.
J
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-03-05 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 18:18 iio: imu: mpu6050: add mpu6500 register settings Dan Carpenter
2016-03-02 18:21 ` Dan Carpenter
2016-03-02 22:04 ` Matt Ranostay
2016-03-05 17:50 ` Jonathan Cameron [this message]
2016-03-07 8:19 ` Adriana Reus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DB1C72.5060407@kernel.org \
--to=jic23@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=linux-iio@vger.kernel.org \
--cc=matt.ranostay@intel.com \
--cc=mranostay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.