Re: [PATCH nf-next v3 2/3] netfilter: bridge: pass L2 header and VLAN as netlink attributes in queues to userspace

["stéphane bryant" <stephane.ml.bryant@gmail.com>]

> 
> Stephane, I'm very looking forward to having this update pushed
> mainstream.
> 
> However, this I think it would be good if you can translate this to
> use nested attributes.
> 
> See nla_nest_start() and nla_nest_end(). Then, add a new vlan
> attributes for this:
> 
>         enum nfqnl_vlan_attr {
>                 NFQA_VLAN_UNSPEC,
>                 NFQA_VLAN_PROTO,
>                 NFQA_VLAN_TCI,
>                 __NFQA_VLAN_MAX,
>         };
>         #define NFQA_VLAN_MAX   (__NFQA_VLAN_MAX + 1)
> 
> Using structure to encapsulate netlink data is highly discouraged. I
> know we're doing this already in old attribute but that we cannot
> change since it's part of the ABI. But I would like that we start
> doing this the right way for new attributes.

Apologies for the delay -- i missed the email. I will try to get this
done within 3 weeks.