Re: [PATCH 4/4] ALSA: dice: force to add two pcm devices for listed models

[Takashi Sakamoto <o-takashi@sakamocchi.jp>]

On Mar 6 2016 00:07, Stefan Richter wrote:
> On Mar 05 Takashi Sakamoto wrote:
>> +static bool force_two_pcm_support(struct fw_unit *unit)
>> +{
>> +	const char *const models[] = {
>> +		/* TC Electronic models. */
>> +		"StudioKonnekt48",
>> +		/* Focusrite models. */
>> +		"SAFFIRE PRO 40",
>> +		"LIQUID SAFFIRE 56",
>> +		"SAFFIRE PRO 40 1",
>> +	};
>> +	char model[32];
>> +	unsigned int i;
>> +	int err;
>> +
>> +	err = fw_csr_string(unit->directory, CSR_MODEL, model, sizeof(model));
>> +	if (err < 0)
>> +		return false;
>> +
>> +	for (i = 0; i < ARRAY_SIZE(models); i++) {
>> +		if (strcmp(models[i], model) == 0)
>> +			break;
>> +	}
>> +
>> +	return i < ARRAY_SIZE(models);
>> +}
> 
> The model name of my old Saffire PRO 40 is "SAFFIRE_PRO_40", and
> according to e.g. Alban Bernard on ffado-user, the newer model is
> "SAFFIRE_PRO_40_1".  Saffire 56's name is "LIQUID_SAFFIRE_56"
> according to https://forum.ubuntuusers.de/topic/focusrite-liquid/.

OK. Thanks for your correction. I'll include them in next patchset.

Well, can this patchset enable snd-dice to drive your Saffire Pro 40
with several isochronous streams?  (of cource, the strings should be fixed.)


Regards

Takashi Sakamoto