From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Hauke Mehrtens <hauke@hauke-m.de>,
linux-mips@linux-mips.org, ralf@linux-mips.org
Cc: Paul Burton <paul.burton@imgtec.com>,
"# v3 . 15+" <stable@vger.kernel.org>
Subject: Re: [PATCH] MIPS: fix build error when SMP is used without GIC
Date: Sun, 6 Mar 2016 23:22:57 +0300 [thread overview]
Message-ID: <56DC91A1.5070404@cogentembedded.com> (raw)
In-Reply-To: <1457273756-4182-1-git-send-email-hauke@hauke-m.de>
Hello.
On 03/06/2016 05:15 PM, Hauke Mehrtens wrote:
> The MIPS_GIC_IPI should only be selected when MIPS_GIC is also
> selected, otherwise it results in a compile error. smp-gic.c uses some
> functions form include/linux/irqchip/mips-gic.h like
s/form/from/.
> plat_ipi_call_int_xlate() which are only added to the header file when
> MIPS_GIC is set. The Lantiq SoC does not use the GIC, but supports SMP.
> The calls top the functions from smp-gic.c are laready protected by
s/laready/already/.
> some #ifdefs
>
> The first part of this was introduced in commit 72e20142b "MIPS: Move
> GIC IPI functions out of smp-cmp.c"
scripts/checkpatch.pl now enforces certain commit citing style, yours
doesn't quite match it...
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> Cc: Paul Burton <paul.burton@imgtec.com>
> Cc: <stable@vger.kernel.org> # v3.15+
[...]
MBR, Sergei
prev parent reply other threads:[~2016-03-06 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 14:15 [PATCH] MIPS: fix build error when SMP is used without GIC Hauke Mehrtens
2016-03-06 20:22 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DC91A1.5070404@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=hauke@hauke-m.de \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.