From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 05/42] drm/omap: panel-dsi-cm: remove pdata support Date: Mon, 7 Mar 2016 10:07:37 +0200 Message-ID: <56DD36C9.7020409@ti.com> References: <1456161048-21240-1-git-send-email-tomi.valkeinen@ti.com> <1456161048-21240-6-git-send-email-tomi.valkeinen@ti.com> <3574138.OtnBVa2NJW@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0487530739==" Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by gabe.freedesktop.org (Postfix) with ESMTPS id E40F26E145 for ; Mon, 7 Mar 2016 08:07:43 +0000 (UTC) In-Reply-To: <3574138.OtnBVa2NJW@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0487530739== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5KTuD8Fepee1ieL4g0J5Xut0FwofkdFTK" --5KTuD8Fepee1ieL4g0J5Xut0FwofkdFTK Content-Type: multipart/mixed; boundary="Ae4LWFpABUtjPCwmxtg9LogWu0Dw8RNNH" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Rob Clark Message-ID: <56DD36C9.7020409@ti.com> Subject: Re: [PATCH 05/42] drm/omap: panel-dsi-cm: remove pdata support References: <1456161048-21240-1-git-send-email-tomi.valkeinen@ti.com> <1456161048-21240-6-git-send-email-tomi.valkeinen@ti.com> <3574138.OtnBVa2NJW@avalon> In-Reply-To: <3574138.OtnBVa2NJW@avalon> --Ae4LWFpABUtjPCwmxtg9LogWu0Dw8RNNH Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/03/16 10:04, Laurent Pinchart wrote: > Hi Tomi, >=20 > Thank you for the patch. > On Monday 22 February 2016 19:10:11 Tomi Valkeinen wrote: >> We no longer have any boards that require the platform data support fr= om >> the panel, so we can remove the related code. >> >> Signed-off-by: Tomi Valkeinen >> --- >> drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 49 +++------------= ------ >=20 > I was about to say that you can also remove the definition of the=20 > panel_dsicm_platform_data structure in include/video/omap-panel-data.h,= but=20 > you have to keep it for the display drivers in the omapfb driver. I won= der=20 > whether you shouldn't also remove pdata support there as well to be abl= e to=20 > clean the shared headers. This also applies to patches 06/42 to 13/42. Yes, I'm planning to do some cleaning on that side too. But I only have so much time... =3D). I didn't want to mix up omapfb and omapdrm changes in this same series. >> 1 file changed, 5 insertions(+), 44 deletions(-) >> >> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c >> b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c index >> 3414c2609320..ae7dd625e19f 100644 >> --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c >> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c >> @@ -1127,40 +1127,6 @@ static struct omap_dss_driver dsicm_ops =3D { >> .memory_read =3D dsicm_memory_read, >> }; >> >> -static int dsicm_probe_pdata(struct platform_device *pdev) >> -{ >> - const struct panel_dsicm_platform_data *pdata; >> - struct panel_drv_data *ddata =3D platform_get_drvdata(pdev); >> - struct omap_dss_device *dssdev, *in; >> - >> - pdata =3D dev_get_platdata(&pdev->dev); >> - >> - in =3D omap_dss_find_output(pdata->source); >> - if (in =3D=3D NULL) { >> - dev_err(&pdev->dev, "failed to find video source\n"); >> - return -EPROBE_DEFER; >> - } >> - ddata->in =3D in; >> - >> - ddata->reset_gpio =3D pdata->reset_gpio; >> - >> - if (pdata->use_ext_te) >> - ddata->ext_te_gpio =3D pdata->ext_te_gpio; >> - else >> - ddata->ext_te_gpio =3D -1; >> - >> - ddata->ulps_timeout =3D pdata->ulps_timeout; >> - >> - ddata->use_dsi_backlight =3D pdata->use_dsi_backlight; >> - >> - ddata->pin_config =3D pdata->pin_config; >> - >> - dssdev =3D &ddata->dssdev; >> - dssdev->name =3D pdata->name; >> - >> - return 0; >> -} >> - >> static int dsicm_probe_of(struct platform_device *pdev) >> { >> struct device_node *node =3D pdev->dev.of_node; >> @@ -1214,17 +1180,12 @@ static int dsicm_probe(struct platform_device = *pdev) >> platform_set_drvdata(pdev, ddata); >> ddata->pdev =3D pdev; >> >> - if (dev_get_platdata(dev)) { >> - r =3D dsicm_probe_pdata(pdev); >> - if (r) >> - return r; >> - } else if (pdev->dev.of_node) { >> - r =3D dsicm_probe_of(pdev); >> - if (r) >> - return r; >> - } else { >> + if (pdev->dev.of_node) >=20 > Shouldn't you invert the condition ? Oops... Thanks for catching this. Tomi --Ae4LWFpABUtjPCwmxtg9LogWu0Dw8RNNH-- --5KTuD8Fepee1ieL4g0J5Xut0FwofkdFTK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW3TbJAAoJEPo9qoy8lh719+YP/jcFBe4Ntd07uic6RoPKT1IO BiznnuSE/GolmYGg6JIYWs9aB28tVHaZzgEp8AAbxdvF8U+wUJXqZDcj/7pwqS6d M/UCStfmS770asxP6yQzb3i2Zxbl8dDA9XRnV4Ju+gVwjn6hezXhOQEqf2d5WbAy H6CfKlSBLfzgb0n51FbUkrrCE/1S2/rP9uDwi7TsUwPm6m1lLxqABkxg5ttHdiUo gqOdlp28Z16faMYTs2N2FLSXyNGU0JskC2aQMxR0L2Kb2+xPo8TYHuAb3Qi3q3LY WobSJYGkGzt1qx0RcI854GyqkydzJnxjaC+BAELssgKWESdZdpYP7K1G3FtPa+hw Pkv+R2toTn1pO1m9MR9WEgbuT9z4czLl8jQJsT6CFCliOHluN7zIGnzjmV8E29Ly YoXsZSLGP2kxq/mTmE2owbTj65NR4zqD+JT3zdcQ232YrLL+Hl3OyUns96zxJyM2 QQ1r4rECgrZ3nxxJFjoU2DMmk5NgP7+nf5mvsvK3pQYxRPZdSomStWqV56TbumOy jcotmf4Y2Zs/prbUwLjuOIHqnJqj7siWLzMZzoP59Oc2q92+cCDNeKI3wkgmMfVb LVgRjxKBOLIYSfreI1ErbJvkeSOm8g0XvXTt7gbKp0IT7TxgBYGXSVBku8RTwOEE RbB6On3aYrlzJiuMSsZ5 =V+Mz -----END PGP SIGNATURE----- --5KTuD8Fepee1ieL4g0J5Xut0FwofkdFTK-- --===============0487530739== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0487530739==--