From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 07/42] drm/omap: connector-dvi: remove pdata support Date: Mon, 7 Mar 2016 10:24:33 +0200 Message-ID: <56DD3AC1.7070909@ti.com> References: <1456161048-21240-1-git-send-email-tomi.valkeinen@ti.com> <1456161048-21240-8-git-send-email-tomi.valkeinen@ti.com> <17560528.XXHOdQNTlz@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1263823118==" Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by gabe.freedesktop.org (Postfix) with ESMTPS id 37A7889B30 for ; Mon, 7 Mar 2016 08:24:39 +0000 (UTC) In-Reply-To: <17560528.XXHOdQNTlz@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1263823118== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9SL862P6DfMxu43tB4UpfNuaSaD56WSQ7" --9SL862P6DfMxu43tB4UpfNuaSaD56WSQ7 Content-Type: multipart/mixed; boundary="oU841sd8a7nbi6dv29pelxjQ1C0R09MAh" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Rob Clark Message-ID: <56DD3AC1.7070909@ti.com> Subject: Re: [PATCH 07/42] drm/omap: connector-dvi: remove pdata support References: <1456161048-21240-1-git-send-email-tomi.valkeinen@ti.com> <1456161048-21240-8-git-send-email-tomi.valkeinen@ti.com> <17560528.XXHOdQNTlz@avalon> In-Reply-To: <17560528.XXHOdQNTlz@avalon> --oU841sd8a7nbi6dv29pelxjQ1C0R09MAh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/03/16 10:16, Laurent Pinchart wrote: >> @@ -319,17 +279,12 @@ static int dvic_probe(struct platform_device *pd= ev) >> >> platform_set_drvdata(pdev, ddata); >> >> - if (dev_get_platdata(&pdev->dev)) { >> - r =3D dvic_probe_pdata(pdev); >> - if (r) >> - return r; >> - } else if (pdev->dev.of_node) { >> - r =3D dvic_probe_of(pdev); >> - if (r) >> - return r; >> - } else { >> + if (pdev->dev.of_node) >=20 > I think you need to invert the condition. Thanks! Well, I obviously wasn't too careful here... I'll go through all of them. Tomi --oU841sd8a7nbi6dv29pelxjQ1C0R09MAh-- --9SL862P6DfMxu43tB4UpfNuaSaD56WSQ7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW3TrBAAoJEPo9qoy8lh71iaoP/iTaCchyKuYe5ebjP0syiCby uuSvw8MLB+FGRrHRlyEAGu5ec328AyOEaL+Vsly+0aGc9pJ+y89i+p0z/CYNx4R6 Yrb/KLO4ixhh2eOzXJ1ROABQB0adMuDdq5NQ1Wb/APG1If/RjLbGOzEMqTrzE3xm K3WO2R8+hYtdp9yKOuCvHzc5/HjOX9Pqk8UCa6hxAbFBZpLZEeUB5HdhyQCCYhGW Z6ukfXYH+6SHIvZwr7kZOolicGsTv/6wCwK2wcUuNnZNEu/hE2y7/1bQhZTjLkns eWNVDHSCrsAMwghW/GeLYCCp5qAuHHipeLTzH1/MmasVy/KlJOPOy3enXyYKpxl/ EHxSdWBxzYhLQ2awSgNzL5G2i+E/teqKwxYuWwBWDAaSKGJ6Px7ZBl3kjVQ/EKdB c9PxWCZwOYvNoXk1H5s3AXYKseLJ0/y6zFJFiq1Kt8JFMsMJ6KsHjvoSfaOru5J5 WMaunEidplkN1Zg95m6heE+V+XB+We1zYwOsF+QRtFY/rQAkfpN7899a+cvzLcew wLSaOurude3JAioWFIx3+g0qWruj+dcmrz9BND4SE0KAQpxWlcTgVwlurcVjqVun MQ80BiBv2lymAk8DnuMr2RaqH4wfail8Ns3AaXZZY5iZCpalpTjsCF51K6nRx0bv r6V8QlN/+WWAMm+Dab6S =x6Dw -----END PGP SIGNATURE----- --9SL862P6DfMxu43tB4UpfNuaSaD56WSQ7-- --===============1263823118== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1263823118==--