Re: [PATCH v3] Improve the performance of --num-threads -d 31

From: "\"Zhou, Wenjian/周文剑\"" <zhouwj-fnst@cn.fujitsu.com>
To: Minoru Usui <min-usui@ti.jp.nec.com>
Cc: Minfei Huang <mhuang@redhat.com>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [PATCH v3] Improve the performance of --num-threads -d 31
Date: Mon, 7 Mar 2016 16:43:19 +0800	[thread overview]
Message-ID: <56DD3F27.4030105@cn.fujitsu.com> (raw)
In-Reply-To: <56DD3A3E.1000402@cn.fujitsu.com>

Hi Minoru,

I got two error dumpfiles by running it less than 100 times.

-- 
Thanks
Zhou

On 03/07/2016 04:22 PM, "Zhou, Wenjian/周文?" wrote:
> Hi Minoru,
>
> I have test your patch since you post.
> I can get a failure easily.
> If you run it several times, the dumpfile it produces may be different from the correct one.
>
> +			info->current_pfn = pfn + 1;
> +			pthread_mutex_unlock(&info->current_pfn_mutex);
> +			page_flag_buf->pfn = pfn;
> +			page_flag_buf->ready = FLAG_FILLING;
> The above code should be changed to the following:
>
> +			info->current_pfn = pfn + 1;
> +			page_flag_buf->pfn = pfn;
> +			page_flag_buf->ready = FLAG_FILLING;
> +			pthread_mutex_unlock(&info->current_pfn_mutex);
>
> I haven't run your code with the bug fixed.
> I'll try now.
>
> By the way, with my patch v3, I can't get an error dumpfile until run it by 5000 times.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec