From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 14/42] drm/omap, omapfb: move exported dispc function declarations to omapdrm/omapfb Date: Mon, 7 Mar 2016 10:54:05 +0200 Message-ID: <56DD41AD.5090502@ti.com> References: <1456161048-21240-1-git-send-email-tomi.valkeinen@ti.com> <1456161048-21240-15-git-send-email-tomi.valkeinen@ti.com> <16376840.MhAhaEz0gy@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0421634657==" Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by gabe.freedesktop.org (Postfix) with ESMTPS id 35DF26E309 for ; Mon, 7 Mar 2016 08:54:11 +0000 (UTC) In-Reply-To: <16376840.MhAhaEz0gy@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0421634657== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="q20iTV6E6DHvWJPAMgEA9W5c4VjEmbJO2" --q20iTV6E6DHvWJPAMgEA9W5c4VjEmbJO2 Content-Type: multipart/mixed; boundary="39o7hTedCh2dpuiumb5Qc9b9127iJ92Gk" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Rob Clark Message-ID: <56DD41AD.5090502@ti.com> Subject: Re: [PATCH 14/42] drm/omap, omapfb: move exported dispc function declarations to omapdrm/omapfb References: <1456161048-21240-1-git-send-email-tomi.valkeinen@ti.com> <1456161048-21240-15-git-send-email-tomi.valkeinen@ti.com> <16376840.MhAhaEz0gy@avalon> In-Reply-To: <16376840.MhAhaEz0gy@avalon> --39o7hTedCh2dpuiumb5Qc9b9127iJ92Gk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/03/16 10:42, Laurent Pinchart wrote: > Hi Tomi, >=20 > Thank you for the patch. >=20 > On Monday 22 February 2016 19:10:20 Tomi Valkeinen wrote: >> omapdrm and omapfb still share the same include/video/omapdss.h. We ne= ed >> to change that so that we can proceed with omapdrm work. >> >> However, it's not trivial to make separate omapfb and omapdrm versions= >> of omapdss.h, as that file is also included in other places like arch >> code, audio code and omap_vout code. So we'll do it piece by piece. >> >> This patch makes private versions of all the dispc function declaratio= ns >> that are in omapdss.h. For omapdrm we create a new file, >> drivers/gpu/drm/omapdrm/dss/omapdss.h, which will contain headers mean= t >> to be visible outside omapdss. >> >> Signed-off-by: Tomi Valkeinen >=20 > This looks good to me, but I would squash patches 14/42 to 16/42 togeth= er, as=20 > it will make it easier to review them and make sure everything relevant= has=20 > been moved. >=20 > Could you also confirm that the idea is to move anything that is not ne= eded by=20 > arch/ code away from include/video/omapdss.h ? My aim is to move/restructure everything shared by omapfb and omapdss so that they would be fully independent. But at the moment we've got structs used between arch/, omapfb and omapdrm, so there are some challenges there. include/video/omapdss.h was needed as a public omapdss header as we had multiple users for omapdss. Now on the omapdrm side we no longer need a public header at all, so in theory all that we need in omapdss.h (from omapdrm's perspective) are the parts used from arch/. But, of course, as omapfb and omap_vout still need support from omapdss.h, I can't remove them just like that. Probably I should create a new header for omapfb. Or maybe a new one for the parts used from arch/. Tomi --39o7hTedCh2dpuiumb5Qc9b9127iJ92Gk-- --q20iTV6E6DHvWJPAMgEA9W5c4VjEmbJO2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW3UGtAAoJEPo9qoy8lh716t0P/0vhJCViTIkNcKVipIIStA6Z ZXKj7kfEx5RjUn9aj9nwLNyWMoo7kWxHXSIPJ3o1UJ+pooSWJBDb8cUtKzNe4Oze W8BvzrZP5VlfjqJ92CpYNou92KkDTGMzH9gSSZ0uAvgrJkgJbgBL5Nm4qZ7C50bS hBSzJ9mMll9JRokwafxwoV4dQLaxxJBlZm2XYEmghbvEnveFRGjxFxvNKb59iCFE 7Lc7e+hwVqqIcGIy2/64qC3CBoAJQlYworr3+YL0RwCGypH4NlQ0sGihrou3xckr ttPp6PvnCJP3sxk225g6sv+fEI3h81nQGBHJz1i47Oa4E0SQ1UxtMc9NUwIO4ATD djP90PHNCiOddZfyuZ1MyI4Sp6DNkKrAhEU8gZVah2tzNBBRwIihJMOE01KCNL9B eWj8HJ80Sw/RIBQV4o3Uy8dO5U9yHqijoSVAjstRv7J1g96272+ZEyi05cYyJam5 Q4MITQvM22AVkpv0QYKtuv66VZdsFNaVaDSjJC7GoSybENRAPf8kve407Cv0OOo6 gZRp2n+Uu757V0dGzCwjB8rwpYHW5OEBkT8N19qDcxbxSXMftlL3gl5l85+r/Bvk ACEfYa1SCQB4rz7sL/Q1KVNqC1efqJ0uqDC9Wvge5R3FcdNLOmBnlNcy8sgg4kaq fQ7dx/lT2dFUkrwjOnz5 =3stG -----END PGP SIGNATURE----- --q20iTV6E6DHvWJPAMgEA9W5c4VjEmbJO2-- --===============0421634657== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0421634657==--