From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 17/42] drm/omap: Add dispc_mgr_get_supported_outputs() Date: Mon, 7 Mar 2016 11:08:46 +0200 Message-ID: <56DD451E.6040500@ti.com> References: <1456161048-21240-1-git-send-email-tomi.valkeinen@ti.com> <1456161048-21240-18-git-send-email-tomi.valkeinen@ti.com> <5379872.0MqFkrVTb2@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0064805041==" Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDF6A6E30E for ; Mon, 7 Mar 2016 09:08:51 +0000 (UTC) In-Reply-To: <5379872.0MqFkrVTb2@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0064805041== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wMsVXrWHbQT2Kdma17Fq4QktegstKDDUQ" --wMsVXrWHbQT2Kdma17Fq4QktegstKDDUQ Content-Type: multipart/mixed; boundary="uR8JnCxauUuSE6FPTfFxaSB3D3FHiVn20" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Rob Clark Message-ID: <56DD451E.6040500@ti.com> Subject: Re: [PATCH 17/42] drm/omap: Add dispc_mgr_get_supported_outputs() References: <1456161048-21240-1-git-send-email-tomi.valkeinen@ti.com> <1456161048-21240-18-git-send-email-tomi.valkeinen@ti.com> <5379872.0MqFkrVTb2@avalon> In-Reply-To: <5379872.0MqFkrVTb2@avalon> --uR8JnCxauUuSE6FPTfFxaSB3D3FHiVn20 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/03/16 10:47, Laurent Pinchart wrote: > Hi Tomi, >=20 > Thank you for the patch. >=20 > On Monday 22 February 2016 19:10:23 Tomi Valkeinen wrote: >> We are removing the use of the 'struct omap_overlay_manager' from >> omapdrm, and one part of that is removing the use of >> mgr->supported_outputs field. >> >> This patch adds dispc_mgr_get_supported_outputs() function which can b= e >> used instead of mgr->supported_outputs. omap_crtc.c is changed to use >> the new function. >> >> Signed-off-by: Tomi Valkeinen >> --- >> drivers/gpu/drm/omapdrm/dss/dispc.c | 6 ++++++ >> drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 ++ >> drivers/gpu/drm/omapdrm/omap_crtc.c | 2 +- >> 3 files changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c >> b/drivers/gpu/drm/omapdrm/dss/dispc.c index a4274dca384a..a5940892a788= >> 100644 >> --- a/drivers/gpu/drm/omapdrm/dss/dispc.c >> +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c >> @@ -2910,6 +2910,12 @@ bool dispc_ovl_enabled(enum omap_plane plane) >> } >> EXPORT_SYMBOL(dispc_ovl_enabled); >> >> +enum omap_dss_output_id dispc_mgr_get_supported_outputs(enum omap_cha= nnel >> channel) >> +{ >> + return dss_feat_get_supported_outputs(channel); >> +} >=20 > Wouldn't it make sense to turn this into a static inline function, as i= t's a=20 > one-liner ? I plan to get rid of the dss_features.c and move the code into respective driver files. So this function will probably get a bit larger with that. And hmm... Would it even work, as dss_feat_get_supported_outputs() is not visible to the callers? Tomi --uR8JnCxauUuSE6FPTfFxaSB3D3FHiVn20-- --wMsVXrWHbQT2Kdma17Fq4QktegstKDDUQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW3UUeAAoJEPo9qoy8lh71HccQAIpXog1zCOP7EDOF6rgzThn/ Vvnk7amdFFgcyLWmnXEiZFehWVqyRM/hvO0RoT6/r++Sqrf2e+Hkz1sBmoXPSYmL d9M1aa6WyM22rR1jnoVkpx7hHi8bBKAV+weyjOdT/IZX4LBiR2AENuqhbblYy/6f rEDXlho8RgdKfXh0WfGfXTguwqHsQ6wJP05gRrJfZJZTVK0bNPHeL22gfEFJeBDS QTO7iVQFbuW4fmK14r8HmhTBVw4kiiA2DWwWdyjLqXt0XdeO/8Pw0oAkZHqe6XDR 9Gw6H4LGUbd/HaQdHSE3UK5zNY+oHSITR2LZkO94u3fJCRFIwczcRNY7EDs8R7D+ Z3zeBxViSSy2Gt5XCvaHPD99ijVrPCPoAKf1/EoMK4112/O3Fb2NtHIwfbctdtOK zV0acW2YeoC2TT3ZdrJQ4xXXFJQqUxlFoiiv67VHlsxvKmw7r8S94GGuJrMr11Vf Gg+AZnku1Zm0rzwP/vbgdvPHgxxFEVmUc4NKD6FJEPc0kO9eec7Q4WE39MW0Ip1P k9mE28dZBOBrRRFUNpEX6y/UWr0fJl+Xk4iA9Hpnw3AQLMpMJPkfSzjgv7WLIcSl fD0ssfzAA1gS8yTeqvodqWxxu5xYMTcjIYZU0cvFDjhqTYWPPcaoYzNXf1TUp3d8 zXr1I/brKmrzLH9dS68G =AG1J -----END PGP SIGNATURE----- --wMsVXrWHbQT2Kdma17Fq4QktegstKDDUQ-- --===============0064805041== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0064805041==--