From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 18/42] drm/omap: remove crtc->mgr field Date: Mon, 7 Mar 2016 11:19:45 +0200 Message-ID: <56DD47B1.8040505@ti.com> References: <1456161048-21240-1-git-send-email-tomi.valkeinen@ti.com> <1456161048-21240-19-git-send-email-tomi.valkeinen@ti.com> <3600604.KbKb6Dn9dh@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0065927091==" Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B6EF6E30D for ; Mon, 7 Mar 2016 09:19:51 +0000 (UTC) In-Reply-To: <3600604.KbKb6Dn9dh@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0065927091== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mkWookNIJm9C7hUGL0qtgmF2F91F8O8Bv" --mkWookNIJm9C7hUGL0qtgmF2F91F8O8Bv Content-Type: multipart/mixed; boundary="VhvLKmt38i7rKrfdu1Qf8d9CqvRTB9Wa3" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Rob Clark Message-ID: <56DD47B1.8040505@ti.com> Subject: Re: [PATCH 18/42] drm/omap: remove crtc->mgr field References: <1456161048-21240-1-git-send-email-tomi.valkeinen@ti.com> <1456161048-21240-19-git-send-email-tomi.valkeinen@ti.com> <3600604.KbKb6Dn9dh@avalon> In-Reply-To: <3600604.KbKb6Dn9dh@avalon> --VhvLKmt38i7rKrfdu1Qf8d9CqvRTB9Wa3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/03/16 10:52, Laurent Pinchart wrote: > Hi Tomi, >=20 > Thank you for the patch. >=20 > On Monday 22 February 2016 19:10:24 Tomi Valkeinen wrote: >> In order to remove uses of 'struct omap_overlay_manager' from omapdrm,= >> this patch removes the crtc->mgr field. >> >> To accomplish that, a new static array is added along the current >> 'omap_crtcs' static array, which is used to store the output device >> connected to a crtc. >> >> Optimally we'd use the struct omap_crtc to store this information, but= >> at the time when omap_crtc_dss_connect() is called, we don't yet have >> the omap_crtc instances. This might possibly be fixed later, but for n= ow >> the static array does the job. >> >> Signed-off-by: Tomi Valkeinen >> --- >> drivers/gpu/drm/omapdrm/omap_crtc.c | 20 +++++++------------- >> 1 file changed, 7 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c >> b/drivers/gpu/drm/omapdrm/omap_crtc.c index b1ed18bf1b1b..104e70a91fd8= >> 100644 >> --- a/drivers/gpu/drm/omapdrm/omap_crtc.c >> +++ b/drivers/gpu/drm/omapdrm/omap_crtc.c >> @@ -34,14 +34,6 @@ struct omap_crtc { >> const char *name; >> enum omap_channel channel; >> >> - /* >> - * Temporary: eventually this will go away, but it is needed >> - * for now to keep the output's happy. (They only need >> - * mgr->id.) Eventually this will be replaced w/ something >> - * more common-panel-framework-y >> - */ >> - struct omap_overlay_manager *mgr; >> - >> struct omap_video_timings timings; >> >> struct omap_drm_irq vblank_irq; >> @@ -100,17 +92,20 @@ int omap_crtc_wait_pending(struct drm_crtc *crtc)= >> >> /* ovl-mgr-id -> crtc */ >> static struct omap_crtc *omap_crtcs[8]; >> +static struct omap_dss_device *omap_crtc_output[8]; >=20 > We should really move away from global structures, not adding more of t= hem :-/=20 > Could you add this to your (or my) todo list ? Agreed. This restructuring series was becoming quite large and confusing already, and I didn't see an obvious solution to this problem. So, as we already had the omap_crtcs[], I went the easy way. Tomi --VhvLKmt38i7rKrfdu1Qf8d9CqvRTB9Wa3-- --mkWookNIJm9C7hUGL0qtgmF2F91F8O8Bv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW3UexAAoJEPo9qoy8lh71ECcP/3t7AJN/2DiIfAtgkzINuiMl I8nulzbW1gD9U5rfGZpABXxr1LWfdMpxgHhMzI+u5c5nbED8JVyvRc8r2cauM740 Mx+IQrdr855WzzZxQXbJCRF+ScsLzDbW3ZyvmSQz7R1Oa7JY6wg0PrCgk5xqSHJz zvZKVGdADf9Lyyc+yaltuT3WInTzTY+zlEVFQH/s7PBPC39b+PMeO4KKKkimB43C ArsryevrJRwxLxbzdJcMNKMZI0aJdbt20nUAe5wOoRx4KP6xEQ5IXBBUlJMMhEdd 91wB/cVuz7ZEKeeNM9q6a3wW1vI9BYbSLvfg33pCQJlDedDnHsx4uQPlDYq17YYT 9AXQslxUyW47Csq/qNabheDEd4Bl5HaIayMI6HoRY/1cunJ2FnFRU+IDznwjqsU1 WRYSij0T9OSltyuDksT98KjDVixTU9GyDWcLW09GF1/EwGNeDCS2KnjQ0Btl/mWq /5T1w0Loh2oUwvcqMAb9jBq8JgudbmeeWBEcDxTmDnPYhv2xOI1IPt4ecoD6AuX/ WNWu0PURTnJjoPx56JfjGI37xHEcMYRy5xiFrNfM/63BmTC7q/KQWjii1C21OqoK w7nxKY2VK3r2zIzH+V5JA7u4qPKFIMVEY6PuadEVE+kH4Sy1H3shNQxNzgohr9xi 8rsnPaUjT6nL6eJ44L8I =8JXA -----END PGP SIGNATURE----- --mkWookNIJm9C7hUGL0qtgmF2F91F8O8Bv-- --===============0065927091== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0065927091==--