diff for duplicates of <56DD4C05.4060109@ozlabs.ru> diff --git a/a/1.txt b/N1/1.txt index 77d234d..2d41d02 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -151,7 +151,7 @@ I suppose I can reuse kvm_spapr_tce_put_group(), this looks inaccurate... > This comment does not appear to be correct. > >> + list_for_each_entry_rcu(stt, &kvm->arch.spapr_tce_tables, list) { ->> + if (stt->liobn = liobn) { +>> + if (stt->liobn == liobn) { >> + if ((stt->offset << stt->page_shift) != start_addr) >> + return -EINVAL; >> + @@ -175,8 +175,8 @@ I suppose I can reuse kvm_spapr_tce_put_group(), this looks inaccurate... >> + if (!tbl) >> + continue; >> + ->> + if ((tbl->it_page_shift = stt->page_shift) && ->> + (tbl->it_offset = stt->offset)) { +>> + if ((tbl->it_page_shift == stt->page_shift) && +>> + (tbl->it_offset == stt->offset)) { >> + tbltmp = tbl; >> + break; >> + } @@ -185,7 +185,7 @@ I suppose I can reuse kvm_spapr_tce_put_group(), this looks inaccurate... >> + return -ENODEV; >> + >> + list_for_each_entry_rcu(kg, &stt->groups, next) { ->> + if (kg->refgrp = grp) +>> + if (kg->refgrp == grp) >> + return -EBUSY; >> + } >> + @@ -235,7 +235,7 @@ I'll put this in the commit log next time. >> + >> + list_for_each_entry_rcu(stt, &kvm->arch.spapr_tce_tables, list) { >> + list_for_each_entry_rcu(kg, &stt->groups, next) { ->> + if (kg->refgrp = grp) { +>> + if (kg->refgrp == grp) { >> + list_del_rcu(&kg->next); >> + call_rcu(&kg->rcu, kvm_spapr_tce_put_group); >> + break; diff --git a/a/content_digest b/N1/content_digest index 8f34ce2..0297813 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020160307062523.GN22546@voom.fritz.box\0" "From\0Alexey Kardashevskiy <aik@ozlabs.ru>\0" "Subject\0Re: [PATCH kernel 6/9] KVM: PPC: Associate IOMMU group with guest view of TCE table\0" - "Date\0Mon, 07 Mar 2016 09:38:13 +0000\0" + "Date\0Mon, 7 Mar 2016 20:38:13 +1100\0" "To\0David Gibson <david@gibson.dropbear.id.au>\0" "Cc\0linuxppc-dev@lists.ozlabs.org" Paul Mackerras <paulus@samba.org> @@ -165,7 +165,7 @@ "> This comment does not appear to be correct.\n" ">\n" ">> +\tlist_for_each_entry_rcu(stt, &kvm->arch.spapr_tce_tables, list) {\n" - ">> +\t\tif (stt->liobn = liobn) {\n" + ">> +\t\tif (stt->liobn == liobn) {\n" ">> +\t\t\tif ((stt->offset << stt->page_shift) != start_addr)\n" ">> +\t\t\t\treturn -EINVAL;\n" ">> +\n" @@ -189,8 +189,8 @@ ">> +\t\tif (!tbl)\n" ">> +\t\t\tcontinue;\n" ">> +\n" - ">> +\t\tif ((tbl->it_page_shift = stt->page_shift) &&\n" - ">> +\t\t\t\t(tbl->it_offset = stt->offset)) {\n" + ">> +\t\tif ((tbl->it_page_shift == stt->page_shift) &&\n" + ">> +\t\t\t\t(tbl->it_offset == stt->offset)) {\n" ">> +\t\t\ttbltmp = tbl;\n" ">> +\t\t\tbreak;\n" ">> +\t\t}\n" @@ -199,7 +199,7 @@ ">> +\t\treturn -ENODEV;\n" ">> +\n" ">> +\tlist_for_each_entry_rcu(kg, &stt->groups, next) {\n" - ">> +\t\tif (kg->refgrp = grp)\n" + ">> +\t\tif (kg->refgrp == grp)\n" ">> +\t\t\treturn -EBUSY;\n" ">> +\t}\n" ">> +\n" @@ -249,7 +249,7 @@ ">> +\n" ">> +\tlist_for_each_entry_rcu(stt, &kvm->arch.spapr_tce_tables, list) {\n" ">> +\t\tlist_for_each_entry_rcu(kg, &stt->groups, next) {\n" - ">> +\t\t\tif (kg->refgrp = grp) {\n" + ">> +\t\t\tif (kg->refgrp == grp) {\n" ">> +\t\t\t\tlist_del_rcu(&kg->next);\n" ">> +\t\t\t\tcall_rcu(&kg->rcu, kvm_spapr_tce_put_group);\n" ">> +\t\t\t\tbreak;\n" @@ -275,4 +275,4 @@ "-- \n" Alexey -274e5f1d063c19bac12111984d33bd9ee1c39c23bdcaf5a5d8d7dcd5fd381f5b +c399a014f3224e1fe37c9640acd585f008085bcc6d20cb8c4e2f194be0b053e6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.