All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Phil Sutter <phil@nwl.cc>,
	Stephen Hemminger <shemming@brocade.com>,
	netdev@vger.kernel.org
Subject: Re: [iproute PATCH v2 06/20] iproute: TYPE keyword is not optional, fix help text accordingly
Date: Mon, 7 Mar 2016 06:23:42 -0500	[thread overview]
Message-ID: <56DD64BE.9080005@mojatatu.com> (raw)
In-Reply-To: <20160303150557.GE18624@orbyte.nwl.cc>

On 16-03-03 10:05 AM, Phil Sutter wrote:
> On Thu, Mar 03, 2016 at 09:21:55AM -0500, Jamal Hadi Salim wrote:
>> On 16-03-02 01:19 PM, Phil Sutter wrote:
>>> +	fprintf(stderr, "          unreachable | prohibit | blackhole | nat }\n");
>>
>> Dont think nat exists anymore...
>
> But iproute2 seems to still support it? At least it's listed in
> rtnl_rtntype_a2n().
>
> The entry for RTN_NAT in net/ipv4/fib_semantics.c though looks like just
> a stub. But at least it hasn't changed since the beginning of Git.
> According to ip-route.8 it's indeed non-functional.
>
> I only concerned help text and man page consistency, and since the man
> page lists it (with a useful hint about it's state), the help text
> should contain it either. Or do you think that's misleading?
>

Yeah it is gone. The cloud providers i know of that needed stateless
nat use tc nat.

cheers,
jamal

  reply	other threads:[~2016-03-07 11:23 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24  8:21 [iproute PATCH 00/20] Sync man pages and help texts Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 01/20] ip: align help text with manpage Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 02/20] ipaddrlabel: Improve help text precision Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 03/20] iplink: fix help text syntax Phil Sutter
2016-03-02 17:38   ` Stephen Hemminger
2016-03-02 18:19     ` [iproute PATCH v2 00/20] Sync man pages and help texts Phil Sutter
2016-03-02 18:19       ` [iproute PATCH v2 01/20] ip: align help text with manpage Phil Sutter
2016-03-02 18:19       ` [iproute PATCH v2 02/20] ipaddrlabel: Improve help text precision Phil Sutter
2016-03-02 18:19       ` [iproute PATCH v2 03/20] iplink: fix help text syntax Phil Sutter
2016-03-02 18:19       ` [iproute PATCH v2 04/20] ipneigh: add missing proxy keyword to help text Phil Sutter
2016-03-02 18:19       ` [iproute PATCH v2 05/20] ipntable: Fix typo in " Phil Sutter
2016-03-02 18:19       ` [iproute PATCH v2 06/20] iproute: TYPE keyword is not optional, fix help text accordingly Phil Sutter
2016-03-03 14:21         ` Jamal Hadi Salim
2016-03-03 15:05           ` Phil Sutter
2016-03-07 11:23             ` Jamal Hadi Salim [this message]
2016-03-02 18:19       ` [iproute PATCH v2 07/20] iprule: add missing nat keyword to help text Phil Sutter
2016-03-02 18:19       ` [iproute PATCH v2 08/20] man: ip-address.8: Minor syntax fixes Phil Sutter
2016-03-02 18:19       ` [iproute PATCH v2 09/20] man: ip-link.8: minor font fix Phil Sutter
2016-03-02 18:19       ` [iproute PATCH v2 10/20] man: ip-link.8: Fix and improve synopsis Phil Sutter
2016-03-02 18:19       ` [iproute PATCH v2 11/20] man: ip-neighbour: Fix for missing NUD_STATE description Phil Sutter
2016-03-02 18:20       ` [iproute PATCH v2 12/20] man: ip-netns.8: Clarify synopsis a bit Phil Sutter
2016-03-02 18:20       ` [iproute PATCH v2 13/20] man: ip-ntable.8: Review synopsis section Phil Sutter
2016-03-02 18:20       ` [iproute PATCH v2 14/20] man: ip-rule.8: " Phil Sutter
2016-03-02 18:20       ` [iproute PATCH v2 15/20] man: ip-token.8: " Phil Sutter
2016-03-02 18:20       ` [iproute PATCH v2 16/20] man: ip-tunnel.8: Document missing 6rd action Phil Sutter
2016-03-02 18:20       ` [iproute PATCH v2 17/20] man: ip-xfrm.8: Document missing parameters Phil Sutter
2016-03-02 18:20       ` [iproute PATCH v2 18/20] man: ip.8: Add missing flags and token subcommand description Phil Sutter
2016-03-02 18:20       ` [iproute PATCH v2 19/20] man: ip-l2tp.8: Fix BNF syntax Phil Sutter
2016-03-02 18:20       ` [iproute PATCH v2 20/20] man: ip-*.8: drop any reference to generic ip options Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 04/20] ipneigh: add missing proxy keyword to help text Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 05/20] ipntable: Fix typo in " Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 06/20] iproute: TYPE keyword is not optional, fix help text accordingly Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 07/20] iprule: add missing nat keyword to help text Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 08/20] man: ip-address.8: Minor syntax fixes Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 09/20] man: ip-link.8: minor font fix Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 10/20] man: ip-link.8: Fix and improve synopsis Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 11/20] man: ip-neighbour: Fix for missing NUD_STATE description Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 12/20] man: ip-netns.8: Clarify synopsis a bit Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 13/20] man: ip-ntable.8: Review synopsis section Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 14/20] man: ip-rule.8: " Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 15/20] man: ip-token.8: " Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 16/20] man: ip-tunnel.8: Document missing 6rd action Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 17/20] man: ip-xfrm.8: Document missing parameters Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 18/20] man: ip.8: Add missing flags and token subcommand description Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 19/20] man: ip-l2tp.8: Fix BNF syntax Phil Sutter
2016-02-24  8:21 ` [iproute PATCH 20/20] man: ip-*.8: drop any reference to generic ip options Phil Sutter
2016-03-02 19:59 ` [iproute PATCH 00/20] Sync man pages and help texts Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56DD64BE.9080005@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=phil@nwl.cc \
    --cc=shemming@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.