From: Paolo Bonzini <pbonzini@redhat.com>
To: "Huaicheng Li (coperd)" <lhcwhu@gmail.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] qemu AIO worker threads change causes Guest OS hangup
Date: Mon, 7 Mar 2016 14:02:13 +0100 [thread overview]
Message-ID: <56DD7BD5.3030209@redhat.com> (raw)
In-Reply-To: <CD1C3D8C-5372-426D-AF86-2A013D868E9C@gmail.com>
On 06/03/2016 03:42, Huaicheng Li (coperd) wrote:
>
>> On Mar 1, 2016, at 3:01 PM, Paolo Bonzini <pbonzini@redhat.com
>> <mailto:pbonzini@redhat.com>> wrote:
>>
>> This is done
>> because the worker threads only care about the queued request list, not
>> about active or completed requests.
>
> Do you think it would be useful to add an API for inserting one request
> back
> to the queued list? For example, In case of request failure, we can
> insert it
> back to the list for re-handling according to some rule before returning
> it directly
> to guest os.
Hi,
this is usually handled at a higher level than the thread pool. See for
example hw/block/virtio-blk.c's restart mechanism, which is enabled with
the rerror=stop and werror=stop options of -drive.
Paolo
next prev parent reply other threads:[~2016-03-07 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 18:45 [Qemu-devel] qemu AIO worker threads change causes Guest OS hangup Huaicheng Li
2016-03-01 21:01 ` Paolo Bonzini
2016-03-06 2:42 ` Huaicheng Li (coperd)
2016-03-07 13:02 ` Paolo Bonzini [this message]
2016-03-07 14:32 ` Huaicheng Li (coperd)
2016-03-01 21:34 ` Stefan Hajnoczi
2016-03-06 2:33 ` Huaicheng Li (coperd)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DD7BD5.3030209@redhat.com \
--to=pbonzini@redhat.com \
--cc=lhcwhu@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.