From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] libxc: simplify error handling in meminit_hvm Date: Mon, 7 Mar 2016 10:02:27 -0600 Message-ID: <56DDA613.5070303@cardoe.com> References: <1457021381-10372-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7134960367669377937==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1acxcD-0007Wr-Aa for xen-devel@lists.xenproject.org; Mon, 07 Mar 2016 16:02:37 +0000 Received: by mail-yw0-f181.google.com with SMTP id g127so97039151ywf.2 for ; Mon, 07 Mar 2016 08:02:35 -0800 (PST) In-Reply-To: <1457021381-10372-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu , Xen-devel Cc: Stefano Stabellini , Ian Jackson , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============7134960367669377937== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kBCXFeMveb86624pc5JCaEaBVEJtBQkCD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kBCXFeMveb86624pc5JCaEaBVEJtBQkCD Content-Type: multipart/mixed; boundary="4aXwBQU7D7hvXUhGL4U7NG5hkwgQImEds" From: Doug Goldstein To: Wei Liu , Xen-devel Cc: Ian Jackson , Roger Pau Monne , Stefano Stabellini Message-ID: <56DDA613.5070303@cardoe.com> Subject: Re: [Xen-devel] [PATCH] libxc: simplify error handling in meminit_hvm References: <1457021381-10372-1-git-send-email-wei.liu2@citrix.com> In-Reply-To: <1457021381-10372-1-git-send-email-wei.liu2@citrix.com> --4aXwBQU7D7hvXUhGL4U7NG5hkwgQImEds Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 3/3/16 10:09 AM, Wei Liu wrote: > The hunk that prints out error message can only be reached from the loo= p > that allocates memory. Move that hunk into the loop to avoid confusing > gcc. >=20 > Reported-by: Doug Goldstein > Signed-off-by: Wei Liu > --- Reviewed-by: Doug Goldstein --=20 Doug Goldstein --4aXwBQU7D7hvXUhGL4U7NG5hkwgQImEds-- --kBCXFeMveb86624pc5JCaEaBVEJtBQkCD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJW3aYWXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUR3sP/3zGWUD8Dbfk/Z1gprQ5hgsP CcF4mV0K5HrBh0CVp6DajtithtO+S+A+ZwekIGVproPMRVzze5m3DXkb3K1WKHoq MLWhpTSZuqEa7xfxdvweWfYF8Gzj8fVpTetVHSsCTPGiUKQC+tCUuYVbS0bQ4NgP brEmYpmfZyVC0wr3bJs8pr7uDGVmgStZAWpba49ga/2w0KzD2LTSOfx2SwF2oJx6 8XOsh/slf+9AsmkrTo1En8U2suGo+lXw6gcpPask4aVGcXA74BWONLVKce0YflYm ajGHW9HSUEA/R7J/zGUodT4n8rqOchc3dG1cXI6zpLSuf1Cuocs3cwS/uRfALfaE MwueydPk0SaLB0WCUK+FQNVH2PBrxaQXgrbC1lVJb+Zv3zfA0zh92NGb/u7QC1lr 3D0ItIqLauOIfX0Enmfv8oOb/OHOhhd7djciOdloaL50TTBP//moai+cjji676vT 6/VGoN7yZ/tB14J7EAHv3jPSEokcyvRyqp5uJ8H1TM0NFVv+iEr8xU69XQXZNMFa L5KZY/W8WfTtPYrX57rr4w2lX/ThSAcsZKzdZdi0qfhhqVnw0vWNMeJ4Bh13Y98x n7BgLUIxu7t52ybIcIY6LltN0w+Smj9wjlnNZJslq6IP8W4tsBZnHw/uchH5Tra4 emaNNBimMeC/3/F/r7jP =Qn6G -----END PGP SIGNATURE----- --kBCXFeMveb86624pc5JCaEaBVEJtBQkCD-- --===============7134960367669377937== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============7134960367669377937==--