Re: [PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes()

From: Thomas Hellstrom <thellstrom@vmware.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	dri-devel@lists.freedesktop.org,
	Sebastian Herbszt <herbszt@gmx.de>
Subject: Re: [PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes()
Date: Mon, 7 Mar 2016 22:18:19 +0100	[thread overview]
Message-ID: <56DDF01B.9020807@vmware.com> (raw)
In-Reply-To: <1457370361-28908-1-git-send-email-thierry.reding@gmail.com>

Tested-by: Thomas Hellstrom <thellstrom@vmware.com>


On 03/07/2016 06:06 PM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This partially reverts commit d56f57ac969c ("drm/gma500: Move to private
> save/restore hooks") which removed these lines by mistake.
>
> Reported-by: Sebastian Herbszt <herbszt@gmx.de>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Hi Dave,
>
> Daniel and I introduced this in v4.5-rc1, so it'd be good to have this
> go into v4.5 final once Sebastian and Thomas have confirmed that it is
> fixed.
>
>  drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> index db082bea8daf..c5a1a08b0449 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> @@ -563,6 +563,8 @@ static void vmw_sou_connector_destroy(struct drm_connector *connector)
>  
>  static const struct drm_connector_funcs vmw_sou_connector_funcs = {
>  	.dpms = vmw_du_connector_dpms,
> +	.detect = vmw_du_connector_detect,
> +	.fill_modes = vmw_du_connector_fill_modes,
>  	.set_property = vmw_du_connector_set_property,
>  	.destroy = vmw_sou_connector_destroy,
>  };

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel