From: Mugunthan V N <mugunthanvnm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] drivers: block: Kconfig: set default n to CONFIG_DISK
Date: Tue, 8 Mar 2016 12:00:41 +0530 [thread overview]
Message-ID: <56DE7191.1010702@ti.com> (raw)
In-Reply-To: <CAPnjgZ3vRNOhGubsiqxChLhQVp16vJwDjFkF1zwF3tOAYnTLvA@mail.gmail.com>
Hi Simon
On Monday 07 March 2016 08:09 AM, Simon Glass wrote:
> Hi Mugunthan,
>
> On 2 March 2016 at 22:06, Mugunthan V N <mugunthanvnm@ti.com> wrote:
>> > When a platform is converted to support DM and when its scsi
>> > driver is not converted to support DM, there is a build break as
>> > multiple definition of scsi_init(). So select CONFIG_DISK only
>> > when the platform supports CONFIG_DISK.
>> >
>> > drivers/built-in.o: In function `scsi_init':
>> > /home/mugunthan/workspace/git/work/u-boot/dm-sata/drivers/block/disk-uclass.c:37: multiple definition of `scsi_init'
>> > board/sunxi/built-in.o:/home/mugunthan/workspace/git/work/u-boot/dm-sata/board/sunxi/ahci.c:74: first defined here
>> > Makefile:1171: recipe for target 'u-boot' failed
>> > make: *** [u-boot] Error 1
>> >
>> > Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
>> > ---
>> > drivers/block/Kconfig | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
> This is because you are defining scsi_init() in the uclass, but I
> don't think that is a great idea. Or at least it should only be
> defined if DISK is enabled.
By default if DM is enabled DISK is also enabled as the Kconfig default
is "y if DM", So this patch makes default n for DISK so that it can be
enabled in platform defconfig which supports CONFIG_DISK.
Regards
Mugunthan V N
next prev parent reply other threads:[~2016-03-08 6:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 5:06 [U-Boot] [PATCH 0/3] fix for build break with CONFIG_DISK scsi_init() Mugunthan V N
2016-03-03 5:06 ` [U-Boot] [PATCH 1/3] drivers: block: Kconfig: set default n to CONFIG_DISK Mugunthan V N
2016-03-07 2:39 ` Simon Glass
2016-03-08 6:30 ` Mugunthan V N [this message]
2016-03-13 2:52 ` Simon Glass
2016-03-13 13:08 ` Tom Rini
2016-04-09 16:02 ` Simon Glass
2016-03-03 5:06 ` [U-Boot] [PATCH 2/3] configs: chromebook_link: enable CONFIG_DISK for accessing sata disk drive Mugunthan V N
2016-03-03 5:06 ` [U-Boot] [PATCH 3/3] cmd: scsi: compile out scsi_init when CONFIG_DISK is defined Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DE7191.1010702@ti.com \
--to=mugunthanvnm@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.