From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1adCTu-0008JN-VN for mharc-grub-devel@gnu.org; Tue, 08 Mar 2016 02:55:03 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adCTr-0008Bx-N7 for grub-devel@gnu.org; Tue, 08 Mar 2016 02:55:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adCTo-0000Ow-8i for grub-devel@gnu.org; Tue, 08 Mar 2016 02:54:59 -0500 Received: from mail-lb0-x22a.google.com ([2a00:1450:4010:c04::22a]:36180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adCTn-0000Oq-S7 for grub-devel@gnu.org; Tue, 08 Mar 2016 02:54:56 -0500 Received: by mail-lb0-x22a.google.com with SMTP id x1so8201102lbj.3 for ; Mon, 07 Mar 2016 23:54:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=v9nKN3VgiWo8q7tCCMUFq1C/UOjCzUCaaOzK/m/spOY=; b=iCHJafzr2QiOaIqpsV7nKBgNSK8NeW30VExlQXkgJj6cE9bSm1M66wZSRgtLtZSiyb 0Tpmt6Hw2qhtpIpdtOshuGAchaj/TQVwwXOKQ91gO/OhKwdi2U58+GTRZ6td+v5m/Eum ys335PHfnqFPZhA+lLV70eBqSTh2PsxCgwjqMUamxyUgO3tMXY0BPYNH81DAaBViksw4 4c8nBc/x3dxqd52Sk1U0IgTMIGzco0Pe79OSWahbojfcB+86s1OZ2JAM37qnBw8Rg2CP TtDVyv+1m3AEUlwGBxuDNfdQkLpSDSwJPGZp4jIfKMj0Jgio6xMgV7KRLSaksA5muBrj CdMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=v9nKN3VgiWo8q7tCCMUFq1C/UOjCzUCaaOzK/m/spOY=; b=NuOS5zJMrE8javYMlkDb4LH5q9N4s2pNgtk4riZLqqEDfOiKx5etmg0U1vNdzgF41T s9tLe5NNQdAjAqSow578rAC530YmROojEsQ+uO1vrCnfjHChinpIbr1sqU0rdcDIa6OY 8HFDYAMxn75ZVn0qhwpnwmL3+ioVwOc0x0Uz7K6eIAp8K8O/VxzQTObCiCNvd7KlJ5Y4 SZcXIUgLKBiT2yo3FBXU6eGSryuRofpIE0HfrRysMVPzpabOY2vX1TV36CoC+/3/tR+A qzsU2A1DVcG+PKNTNhfSnhiuObBFte/KPdV0Usf2Qd0YiTCZabu+2qmBT8COkKFNsVAf dBLQ== X-Gm-Message-State: AD7BkJJvevOb5d361LEUc6t7vyB40DaJ+AL2SC6uS6qJGVTIFs8f3pFFcYGYi/J/Slj80g== X-Received: by 10.112.126.162 with SMTP id mz2mr8681091lbb.71.1457423694807; Mon, 07 Mar 2016 23:54:54 -0800 (PST) Received: from [192.168.1.42] (ppp109-252-76-159.pppoe.spdop.ru. [109.252.76.159]) by smtp.gmail.com with ESMTPSA id xf10sm260117lbb.23.2016.03.07.23.54.53 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Mar 2016 23:54:53 -0800 (PST) Subject: Re: [PATCH v3 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi To: Fu Wei References: <1456485211-32695-1-git-send-email-fu.wei@linaro.org> <1456485211-32695-5-git-send-email-fu.wei@linaro.org> <56D1DC36.1020603@gmail.com> From: Andrei Borzenkov X-Enigmail-Draft-Status: N1110 Message-ID: <56DE854C.9010506@gmail.com> Date: Tue, 8 Mar 2016 10:54:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::22a Cc: The development of GNU GRUB , xen-devel@lists.xensource.com, Ian Campbell , Vladimir Serbinenko , Julien Grall , Leif Lindholm , Linaro UEFI Mailman List , Jon Masters X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2016 07:55:01 -0000 07.03.2016 11:22, Fu Wei пишет: > Hi Andrei, > > On 28 February 2016 at 00:44, Fu Wei wrote: >> Hi Andrei >> >> On 28 February 2016 at 01:26, Andrei Borzenkov wrote: >>> 26.02.2016 14:13, fu.wei@linaro.org пишет: >>>> From: Fu Wei >>>> >>>> delete: xen_linux, xen_initrd, xen_xsm >>>> add: xen_module >>>> >>>> This update bases on >>>> commit 0edd750e50698854068358ea53528100a9192902 >>>> Author: Vladimir Serbinenko >>>> Date: Fri Jan 22 10:18:47 2016 +0100 >>>> >>>> xen_boot: Remove obsolete module type distinctions. >>>> >>>> Signed-off-by: Fu Wei >>>> --- >>>> docs/grub.texi | 33 ++++++++++----------------------- >>>> 1 file changed, 10 insertions(+), 23 deletions(-) >>>> >>>> diff --git a/docs/grub.texi b/docs/grub.texi >>>> index 82f6fa4..3fbdd99 100644 >>>> --- a/docs/grub.texi >>>> +++ b/docs/grub.texi >>>> @@ -3861,9 +3861,7 @@ you forget a command, you can run the command @command{help} >>>> * videoinfo:: List available video modes >>>> @comment * xen_*:: Xen boot commands >>>> * xen_hypervisor:: Load xen hypervisor binary >>>> -* xen_linux:: Load dom0 kernel for xen hypervisor >>>> -* xen_initrd:: Load dom0 initrd for dom0 kernel >>>> -* xen_xsm:: Load xen security module for xen hypervisor >>>> +* xen_module:: Load xen modules for xen hypervisor >>>> @end menu >>>> >>>> >>>> @@ -5141,30 +5139,19 @@ verbatim as the @dfn{kernel command-line}. Any other binaries must be >>>> reloaded after using this command. >>>> @end deffn >>>> >>>> -@node xen_linux >>>> -@subsection xen_linux >>>> +@node xen_module >>>> +@subsection xen_module >>>> >>>> -@deffn Command xen_linux file [arguments] >>>> -Load a dom0 kernel image for xen hypervisor at the booting process of xen. >>>> +@deffn Command xen_module [--nounzip] file [arguments] >>>> +Load a module for xen hypervisor at the booting process of xen. >>>> The rest of the line is passed verbatim as the module command line. >>> >>> == >>>> +On i386, the modules will be identified by Multiboot(2) protocol. >>>> +On arm64, each module will be identified by the order in which the >>>> +modules are added. >>> >>> I think it is better to skip it entirely. It is not really correct - >>> neither multiboot protocol provides any module identification (Xen >>> probes module types), nor is i386 using multiboot2, nor can all modules >>> be probed, so order still matters. To avoid confusion I'd simply >>> replaced the above three lines with >>> >>> Modules should be loaded in the following order: >>> >>>> +The 1st module: dom0 kernel image >>>> +The 2nd module: dom0 ramdisk (optional) >>> >>> This covers both supported platforms without going into too deep >>> details; if you and Vladimir are OK, I'll commit with this change. >> >> Thank you very much! >> Sorry I am not familiar with xen on i386, so maybe I misunderstand this. >> So please commit with your change, Thanks for your correction :-) > > I just fetched the mainline GRUB, i would like to know why this > patchset haven't been applied? > Anything I need to do(improve it or post a new patchset according to > your suggestion) for this patchset? > Sorry for delay. It is not really about your patchset, but we need some decision about loading additional modules/lack of initrd on ARM. Until then I'd rather avoid committing to any high-level configuration support that will require even more backward compatible hacks later. As it stands now either Xen needs to support autodetection or we need to revert to providing module type explicitly. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrei Borzenkov Subject: Re: [PATCH v3 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi Date: Tue, 8 Mar 2016 10:54:52 +0300 Message-ID: <56DE854C.9010506@gmail.com> References: <1456485211-32695-1-git-send-email-fu.wei@linaro.org> <1456485211-32695-5-git-send-email-fu.wei@linaro.org> <56D1DC36.1020603@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Fu Wei Cc: The development of GNU GRUB , xen-devel@lists.xensource.com, Ian Campbell , Vladimir Serbinenko , Julien Grall , Leif Lindholm , Linaro UEFI Mailman List , Jon Masters List-Id: xen-devel@lists.xenproject.org MDcuMDMuMjAxNiAxMToyMiwgRnUgV2VpINC/0LjRiNC10YI6Cj4gSGkgQW5kcmVpLAo+IAo+IE9u IDI4IEZlYnJ1YXJ5IDIwMTYgYXQgMDA6NDQsIEZ1IFdlaSA8ZnUud2VpQGxpbmFyby5vcmc+IHdy b3RlOgo+PiBIaSBBbmRyZWkKPj4KPj4gT24gMjggRmVicnVhcnkgMjAxNiBhdCAwMToyNiwgQW5k cmVpIEJvcnplbmtvdiA8YXJ2aWRqYWFyQGdtYWlsLmNvbT4gd3JvdGU6Cj4+PiAyNi4wMi4yMDE2 IDE0OjEzLCBmdS53ZWlAbGluYXJvLm9yZyDQv9C40YjQtdGCOgo+Pj4+IEZyb206IEZ1IFdlaSA8 ZnUud2VpQGxpbmFyby5vcmc+Cj4+Pj4KPj4+PiBkZWxldGU6IHhlbl9saW51eCwgeGVuX2luaXRy ZCwgeGVuX3hzbQo+Pj4+IGFkZDogeGVuX21vZHVsZQo+Pj4+Cj4+Pj4gVGhpcyB1cGRhdGUgYmFz ZXMgb24KPj4+PiAgICAgY29tbWl0IDBlZGQ3NTBlNTA2OTg4NTQwNjgzNThlYTUzNTI4MTAwYTkx OTI5MDIKPj4+PiAgICAgQXV0aG9yOiBWbGFkaW1pciBTZXJiaW5lbmtvIDxwaGNvZGVyQGdtYWls LmNvbT4KPj4+PiAgICAgRGF0ZTogICBGcmkgSmFuIDIyIDEwOjE4OjQ3IDIwMTYgKzAxMDAKPj4+ Pgo+Pj4+ICAgICAgICAgeGVuX2Jvb3Q6IFJlbW92ZSBvYnNvbGV0ZSBtb2R1bGUgdHlwZSBkaXN0 aW5jdGlvbnMuCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBGdSBXZWkgPGZ1LndlaUBsaW5hcm8u b3JnPgo+Pj4+IC0tLQo+Pj4+ICBkb2NzL2dydWIudGV4aSB8IDMzICsrKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQo+Pj4+ICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwg MjMgZGVsZXRpb25zKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZG9jcy9ncnViLnRleGkgYi9k b2NzL2dydWIudGV4aQo+Pj4+IGluZGV4IDgyZjZmYTQuLjNmYmRkOTkgMTAwNjQ0Cj4+Pj4gLS0t IGEvZG9jcy9ncnViLnRleGkKPj4+PiArKysgYi9kb2NzL2dydWIudGV4aQo+Pj4+IEBAIC0zODYx LDkgKzM4NjEsNyBAQCB5b3UgZm9yZ2V0IGEgY29tbWFuZCwgeW91IGNhbiBydW4gdGhlIGNvbW1h bmQgQGNvbW1hbmR7aGVscH0KPj4+PiAgKiB2aWRlb2luZm86OiAgICAgICAgICAgICAgICAgICBM aXN0IGF2YWlsYWJsZSB2aWRlbyBtb2Rlcwo+Pj4+ICBAY29tbWVudCAqIHhlbl8qOjogICAgICAg ICAgICAgIFhlbiBib290IGNvbW1hbmRzCj4+Pj4gICogeGVuX2h5cGVydmlzb3I6OiAgICAgICAg ICAgICAgTG9hZCB4ZW4gaHlwZXJ2aXNvciBiaW5hcnkKPj4+PiAtKiB4ZW5fbGludXg6OiAgICAg ICAgICAgICAgICAgICBMb2FkIGRvbTAga2VybmVsIGZvciB4ZW4gaHlwZXJ2aXNvcgo+Pj4+IC0q IHhlbl9pbml0cmQ6OiAgICAgICAgICAgICAgICAgIExvYWQgZG9tMCBpbml0cmQgZm9yIGRvbTAg a2VybmVsCj4+Pj4gLSogeGVuX3hzbTo6ICAgICAgICAgICAgICAgICAgICAgTG9hZCB4ZW4gc2Vj dXJpdHkgbW9kdWxlIGZvciB4ZW4gaHlwZXJ2aXNvcgo+Pj4+ICsqIHhlbl9tb2R1bGU6OiAgICAg ICAgICAgICAgICAgIExvYWQgeGVuIG1vZHVsZXMgZm9yIHhlbiBoeXBlcnZpc29yCj4+Pj4gIEBl bmQgbWVudQo+Pj4+Cj4+Pj4KPj4+PiBAQCAtNTE0MSwzMCArNTEzOSwxOSBAQCB2ZXJiYXRpbSBh cyB0aGUgQGRmbntrZXJuZWwgY29tbWFuZC1saW5lfS4gQW55IG90aGVyIGJpbmFyaWVzIG11c3Qg YmUKPj4+PiAgcmVsb2FkZWQgYWZ0ZXIgdXNpbmcgdGhpcyBjb21tYW5kLgo+Pj4+ICBAZW5kIGRl ZmZuCj4+Pj4KPj4+PiAtQG5vZGUgeGVuX2xpbnV4Cj4+Pj4gLUBzdWJzZWN0aW9uIHhlbl9saW51 eAo+Pj4+ICtAbm9kZSB4ZW5fbW9kdWxlCj4+Pj4gK0BzdWJzZWN0aW9uIHhlbl9tb2R1bGUKPj4+ Pgo+Pj4+IC1AZGVmZm4gQ29tbWFuZCB4ZW5fbGludXggZmlsZSBbYXJndW1lbnRzXQo+Pj4+IC1M b2FkIGEgZG9tMCBrZXJuZWwgaW1hZ2UgZm9yIHhlbiBoeXBlcnZpc29yIGF0IHRoZSBib290aW5n IHByb2Nlc3Mgb2YgeGVuLgo+Pj4+ICtAZGVmZm4gQ29tbWFuZCB4ZW5fbW9kdWxlIFstLW5vdW56 aXBdIGZpbGUgW2FyZ3VtZW50c10KPj4+PiArTG9hZCBhIG1vZHVsZSBmb3IgeGVuIGh5cGVydmlz b3IgYXQgdGhlIGJvb3RpbmcgcHJvY2VzcyBvZiB4ZW4uCj4+Pj4gIFRoZSByZXN0IG9mIHRoZSBs aW5lIGlzIHBhc3NlZCB2ZXJiYXRpbSBhcyB0aGUgbW9kdWxlIGNvbW1hbmQgbGluZS4KPj4+Cj4+ PiA9PQo+Pj4+ICtPbiBpMzg2LCAgdGhlIG1vZHVsZXMgd2lsbCBiZSBpZGVudGlmaWVkIGJ5IE11 bHRpYm9vdCgyKSBwcm90b2NvbC4KPj4+PiArT24gYXJtNjQsIGVhY2ggbW9kdWxlIHdpbGwgYmUg aWRlbnRpZmllZCBieSB0aGUgb3JkZXIgaW4gd2hpY2ggdGhlCj4+Pj4gK21vZHVsZXMgYXJlIGFk ZGVkLgo+Pj4KPj4+IEkgdGhpbmsgaXQgaXMgYmV0dGVyIHRvIHNraXAgaXQgZW50aXJlbHkuIEl0 IGlzIG5vdCByZWFsbHkgY29ycmVjdCAtCj4+PiBuZWl0aGVyIG11bHRpYm9vdCBwcm90b2NvbCBw cm92aWRlcyBhbnkgbW9kdWxlIGlkZW50aWZpY2F0aW9uIChYZW4KPj4+IHByb2JlcyBtb2R1bGUg dHlwZXMpLCBub3IgaXMgaTM4NiB1c2luZyBtdWx0aWJvb3QyLCBub3IgY2FuIGFsbCBtb2R1bGVz Cj4+PiBiZSBwcm9iZWQsIHNvIG9yZGVyIHN0aWxsIG1hdHRlcnMuIFRvIGF2b2lkIGNvbmZ1c2lv biBJJ2Qgc2ltcGx5Cj4+PiByZXBsYWNlZCB0aGUgYWJvdmUgdGhyZWUgbGluZXMgd2l0aAo+Pj4K Pj4+IE1vZHVsZXMgc2hvdWxkIGJlIGxvYWRlZCBpbiB0aGUgZm9sbG93aW5nIG9yZGVyOgo+Pj4K Pj4+PiArVGhlIDFzdCBtb2R1bGU6IGRvbTAga2VybmVsIGltYWdlCj4+Pj4gK1RoZSAybmQgbW9k dWxlOiBkb20wIHJhbWRpc2sgKG9wdGlvbmFsKQo+Pj4KPj4+IFRoaXMgY292ZXJzIGJvdGggc3Vw cG9ydGVkIHBsYXRmb3JtcyB3aXRob3V0IGdvaW5nIGludG8gdG9vIGRlZXAKPj4+IGRldGFpbHM7 IGlmIHlvdSBhbmQgVmxhZGltaXIgYXJlIE9LLCBJJ2xsIGNvbW1pdCB3aXRoIHRoaXMgY2hhbmdl Lgo+Pgo+PiBUaGFuayB5b3UgdmVyeSBtdWNoIQo+PiBTb3JyeSBJIGFtIG5vdCBmYW1pbGlhciB3 aXRoIHhlbiBvbiBpMzg2LCBzbyBtYXliZSBJIG1pc3VuZGVyc3RhbmQgdGhpcy4KPj4gU28gcGxl YXNlIGNvbW1pdCB3aXRoIHlvdXIgY2hhbmdlLCBUaGFua3MgZm9yIHlvdXIgY29ycmVjdGlvbiA6 LSkKPiAKPiBJIGp1c3QgZmV0Y2hlZCB0aGUgbWFpbmxpbmUgR1JVQiwgaSB3b3VsZCBsaWtlIHRv IGtub3cgd2h5IHRoaXMKPiBwYXRjaHNldCBoYXZlbid0IGJlZW4gYXBwbGllZD8KPiBBbnl0aGlu ZyBJIG5lZWQgdG8gZG8oaW1wcm92ZSBpdCBvciBwb3N0IGEgbmV3IHBhdGNoc2V0IGFjY29yZGlu ZyB0bwo+IHlvdXIgc3VnZ2VzdGlvbikgZm9yIHRoaXMgcGF0Y2hzZXQ/Cj4gCgpTb3JyeSBmb3Ig ZGVsYXkuIEl0IGlzIG5vdCByZWFsbHkgYWJvdXQgeW91ciBwYXRjaHNldCwgYnV0IHdlIG5lZWQg c29tZQpkZWNpc2lvbiBhYm91dCBsb2FkaW5nIGFkZGl0aW9uYWwgbW9kdWxlcy9sYWNrIG9mIGlu aXRyZCBvbiBBUk0uIFVudGlsCnRoZW4gSSdkIHJhdGhlciBhdm9pZCBjb21taXR0aW5nIHRvIGFu eSBoaWdoLWxldmVsIGNvbmZpZ3VyYXRpb24gc3VwcG9ydAp0aGF0IHdpbGwgcmVxdWlyZSBldmVu IG1vcmUgYmFja3dhcmQgY29tcGF0aWJsZSBoYWNrcyBsYXRlci4KCkFzIGl0IHN0YW5kcyBub3cg ZWl0aGVyIFhlbiBuZWVkcyB0byBzdXBwb3J0IGF1dG9kZXRlY3Rpb24gb3Igd2UgbmVlZCB0bwpy ZXZlcnQgdG8gcHJvdmlkaW5nIG1vZHVsZSB0eXBlIGV4cGxpY2l0bHkuCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0 Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=