From: "Torsten Bögershausen" <tboegi@web.de>
To: Alexander Rinass <alex@fournova.com>
Cc: Ramsay Jones <ramsay@ramsayjones.plus.com>, git@vger.kernel.org
Subject: Re: git diff does not precompose unicode file paths (OS X)
Date: Tue, 8 Mar 2016 13:30:21 +0100 [thread overview]
Message-ID: <56DEC5DD.2070407@web.de> (raw)
In-Reply-To: <5C6A30EF-ED0A-4D64-B971-CF873C64B46E@fournova.com>
>> And if not, I can put it on my TODO-stack.
> I have read through the official contribution guidelines and I think I can
> send an official patch.
>
> In this case, would you prefer to have a single commit since the change
> is related? Or would you prefer keeping it in separate commits, since
> they are different commands and I can use commit subjects like “diff:”
> and “diff-index:”, etc.?
>
Thanks for the work.
The same issue fixed at different places:
I personally would prefer a single commit.
Another thing is, if we want to add TC in t3910,
to avoid future regressions.
(Otherwise I can help with those)
next prev parent reply other threads:[~2016-03-08 12:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 9:07 git diff does not precompose unicode file paths (OS X) Alexander Rinass
2016-03-04 12:16 ` Torsten Bögershausen
2016-03-04 14:37 ` Alexander Rinass
2016-03-04 18:36 ` Junio C Hamano
2016-03-04 18:49 ` Ramsay Jones
2016-03-07 7:47 ` Alexander Rinass
2016-03-07 8:54 ` Torsten Bögershausen
[not found] ` <5C6A30EF-ED0A-4D64-B971-CF873C64B46E@fournova.com>
2016-03-08 12:30 ` Torsten Bögershausen [this message]
2016-03-14 21:45 ` Alexander Rinass
2016-03-15 5:45 ` Torsten Bögershausen
2016-04-04 20:43 ` Alexander Rinass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DEC5DD.2070407@web.de \
--to=tboegi@web.de \
--cc=alex@fournova.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.