From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adGsk-0001Xg-Je for qemu-devel@nongnu.org; Tue, 08 Mar 2016 07:37:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adGsj-000381-RX for qemu-devel@nongnu.org; Tue, 08 Mar 2016 07:36:58 -0500 References: <1457425476-32547-1-git-send-email-famz@redhat.com> From: Paolo Bonzini Message-ID: <56DEC761.8060600@redhat.com> Date: Tue, 8 Mar 2016 13:36:49 +0100 MIME-Version: 1.0 In-Reply-To: <1457425476-32547-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/3] vmdk: Move descriptor buffers to heap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , peterx@redhat.com, qemu-block@nongnu.org On 08/03/2016 09:24, Fam Zheng wrote: > All three functions are not in hot path (all run once for the BDS lifecycle), > so it's okay to convert to g_malloc0. > > Fam > > > Fam Zheng (3): > vmdk: Switch to heap arrays for vmdk_write_cid > vmdk: Switch to heap arrays for vmdk_read_cid > vmdk: Switch to heap arrays for vmdk_parent_open > > block/vmdk.c | 47 +++++++++++++++++++++++++++++------------------ > 1 file changed, 29 insertions(+), 18 deletions(-) > Reviewed-by: Paolo Bonzini