From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Tue, 8 Mar 2016 16:03:41 +0100 Subject: [PATCH 3/8] drm: atmel-hlcdc: fix connector and encoder types In-Reply-To: <1452075569-8545-4-git-send-email-boris.brezillon@free-electrons.com> References: <1452075569-8545-1-git-send-email-boris.brezillon@free-electrons.com> <1452075569-8545-4-git-send-email-boris.brezillon@free-electrons.com> Message-ID: <56DEE9CD.1030501@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 06/01/2016 11:19, Boris Brezillon a ?crit : > The hlcdc IP keep the pixel stream in raw RGB mode, and does not provide > any specific connector. Since DRM_MODE_CONNECTOR_RAW_RGB does not exist, > use DRM_MODE_CONNECTOR_Unknown. > > Signed-off-by: Boris Brezillon Yes: Acked-by: Nicolas Ferre > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c > index 0f7ec01..49494e9 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c > @@ -256,7 +256,7 @@ static int atmel_hlcdc_create_panel_output(struct drm_device *dev, > &atmel_hlcdc_panel_encoder_helper_funcs); > ret = drm_encoder_init(dev, &panel->base.encoder, > &atmel_hlcdc_panel_encoder_funcs, > - DRM_MODE_ENCODER_LVDS, NULL); > + DRM_MODE_ENCODER_NONE, NULL); > if (ret) > return ret; > > @@ -266,7 +266,7 @@ static int atmel_hlcdc_create_panel_output(struct drm_device *dev, > &atmel_hlcdc_panel_connector_helper_funcs); > ret = drm_connector_init(dev, &panel->base.connector, > &atmel_hlcdc_panel_connector_funcs, > - DRM_MODE_CONNECTOR_LVDS); > + DRM_MODE_CONNECTOR_Unknown); > if (ret) > goto err_encoder_cleanup; > > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH 3/8] drm: atmel-hlcdc: fix connector and encoder types Date: Tue, 8 Mar 2016 16:03:41 +0100 Message-ID: <56DEE9CD.1030501@atmel.com> References: <1452075569-8545-1-git-send-email-boris.brezillon@free-electrons.com> <1452075569-8545-4-git-send-email-boris.brezillon@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1452075569-8545-4-git-send-email-boris.brezillon@free-electrons.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Boris Brezillon , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Cc: Alexandre Belloni , Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org Le 06/01/2016 11:19, Boris Brezillon a =E9crit : > The hlcdc IP keep the pixel stream in raw RGB mode, and does not provide > any specific connector. Since DRM_MODE_CONNECTOR_RAW_RGB does not exist, > use DRM_MODE_CONNECTOR_Unknown. > = > Signed-off-by: Boris Brezillon Yes: Acked-by: Nicolas Ferre > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > = > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/g= pu/drm/atmel-hlcdc/atmel_hlcdc_output.c > index 0f7ec01..49494e9 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c > @@ -256,7 +256,7 @@ static int atmel_hlcdc_create_panel_output(struct drm= _device *dev, > &atmel_hlcdc_panel_encoder_helper_funcs); > ret =3D drm_encoder_init(dev, &panel->base.encoder, > &atmel_hlcdc_panel_encoder_funcs, > - DRM_MODE_ENCODER_LVDS, NULL); > + DRM_MODE_ENCODER_NONE, NULL); > if (ret) > return ret; > = > @@ -266,7 +266,7 @@ static int atmel_hlcdc_create_panel_output(struct drm= _device *dev, > &atmel_hlcdc_panel_connector_helper_funcs); > ret =3D drm_connector_init(dev, &panel->base.connector, > &atmel_hlcdc_panel_connector_funcs, > - DRM_MODE_CONNECTOR_LVDS); > + DRM_MODE_CONNECTOR_Unknown); > if (ret) > goto err_encoder_cleanup; > = > = -- = Nicolas Ferre