From mboxrd@z Thu Jan 1 00:00:00 1970 From: tthayer@opensource.altera.com (Thor Thayer) Date: Tue, 8 Mar 2016 09:59:51 -0600 Subject: [PATCHv2 11/11] ARM: dts: Add Altera Arria10 L2 Cache EDAC devicetree entry In-Reply-To: <56DEE6AE.100@opensource.altera.com> References: <1457379787-8327-1-git-send-email-tthayer@opensource.altera.com> <1457379787-8327-12-git-send-email-tthayer@opensource.altera.com> <56DEE6AE.100@opensource.altera.com> Message-ID: <56DEF6F7.1030100@opensource.altera.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Dinh, On 03/08/2016 08:50 AM, Dinh Nguyen wrote: > > > On 03/07/2016 01:43 PM, tthayer at opensource.altera.com wrote: >> From: Thor Thayer >> >> Add the device tree entries needed to support the Altera L2 >> cache EDAC on the Arria10 chip. >> >> Signed-off-by: Thor Thayer >> --- >> v2 Match register value (l2-ecc at ffd06010) >> --- >> arch/arm/boot/dts/socfpga_arria10.dtsi | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/arch/arm/boot/dts/socfpga_arria10.dtsi b/arch/arm/boot/dts/socfpga_arria10.dtsi >> index cce9e50..44aeb3f 100644 >> --- a/arch/arm/boot/dts/socfpga_arria10.dtsi >> +++ b/arch/arm/boot/dts/socfpga_arria10.dtsi >> @@ -599,6 +599,20 @@ >> reg = <0xffe00000 0x40000>; >> }; >> >> + eccmgr: eccmgr at ffd06090 { >> + compatible = "altr,socfpga-ecc-manager"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + >> + l2-ecc at ffd06010 { >> + compatible = "altr,socfpga-a10-l2-ecc"; >> + reg = <0xffd06010 0x4>; >> + interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>, >> + <0 0 IRQ_TYPE_LEVEL_HIGH>; >> + }; >> + }; >> + > > Just checking if these addresses are correct. The eccmgr is at > 0xffd06090, but the l2-ecc is at 0xffd06010? I would have thought from > the placement the l2-ecc address would be inside the eccmgr's address? > > Dinh > Yes, this is confusing and I'll clarify/reorganize in the next series. The eccmgr is pointing to the ECC IRQ mask bits. These registers and the L2 ECC registers are organized in different areas within the system manager. I'm actually redoing the series since the Arria10 IRQ handling is significantly different. Since this change will affect the bindings and dti (the eccmgr will have the IRQs), please disregard this series. Sorry for the noise. Thor From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thor Thayer Subject: Re: [PATCHv2 11/11] ARM: dts: Add Altera Arria10 L2 Cache EDAC devicetree entry Date: Tue, 8 Mar 2016 09:59:51 -0600 Message-ID: <56DEF6F7.1030100@opensource.altera.com> References: <1457379787-8327-1-git-send-email-tthayer@opensource.altera.com> <1457379787-8327-12-git-send-email-tthayer@opensource.altera.com> <56DEE6AE.100@opensource.altera.com> Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56DEE6AE.100@opensource.altera.com> Sender: linux-doc-owner@vger.kernel.org To: Dinh Nguyen , bp@alien8.de, dougthompson@xmission.com, m.chehab@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, grant.likely@linaro.org Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tthayer.linux@gmail.com List-Id: devicetree@vger.kernel.org Hi Dinh, On 03/08/2016 08:50 AM, Dinh Nguyen wrote: > > > On 03/07/2016 01:43 PM, tthayer@opensource.altera.com wrote: >> From: Thor Thayer >> >> Add the device tree entries needed to support the Altera L2 >> cache EDAC on the Arria10 chip. >> >> Signed-off-by: Thor Thayer >> --- >> v2 Match register value (l2-ecc@ffd06010) >> --- >> arch/arm/boot/dts/socfpga_arria10.dtsi | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/arch/arm/boot/dts/socfpga_arria10.dtsi b/arch/arm/boot/dts/socfpga_arria10.dtsi >> index cce9e50..44aeb3f 100644 >> --- a/arch/arm/boot/dts/socfpga_arria10.dtsi >> +++ b/arch/arm/boot/dts/socfpga_arria10.dtsi >> @@ -599,6 +599,20 @@ >> reg = <0xffe00000 0x40000>; >> }; >> >> + eccmgr: eccmgr@ffd06090 { >> + compatible = "altr,socfpga-ecc-manager"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + >> + l2-ecc@ffd06010 { >> + compatible = "altr,socfpga-a10-l2-ecc"; >> + reg = <0xffd06010 0x4>; >> + interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>, >> + <0 0 IRQ_TYPE_LEVEL_HIGH>; >> + }; >> + }; >> + > > Just checking if these addresses are correct. The eccmgr is at > 0xffd06090, but the l2-ecc is at 0xffd06010? I would have thought from > the placement the l2-ecc address would be inside the eccmgr's address? > > Dinh > Yes, this is confusing and I'll clarify/reorganize in the next series. The eccmgr is pointing to the ECC IRQ mask bits. These registers and the L2 ECC registers are organized in different areas within the system manager. I'm actually redoing the series since the Arria10 IRQ handling is significantly different. Since this change will affect the bindings and dti (the eccmgr will have the IRQs), please disregard this series. Sorry for the noise. Thor From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932642AbcCHPze (ORCPT ); Tue, 8 Mar 2016 10:55:34 -0500 Received: from mail-bl2on0070.outbound.protection.outlook.com ([65.55.169.70]:31936 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752435AbcCHPzZ (ORCPT ); Tue, 8 Mar 2016 10:55:25 -0500 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; arm.com; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;arm.com; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=opensource.altera.com; Reply-To: Subject: Re: [PATCHv2 11/11] ARM: dts: Add Altera Arria10 L2 Cache EDAC devicetree entry References: <1457379787-8327-1-git-send-email-tthayer@opensource.altera.com> <1457379787-8327-12-git-send-email-tthayer@opensource.altera.com> <56DEE6AE.100@opensource.altera.com> To: Dinh Nguyen , , , , , , , , , , CC: , , , , , From: Thor Thayer Message-ID: <56DEF6F7.1030100@opensource.altera.com> Date: Tue, 8 Mar 2016 09:59:51 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56DEE6AE.100@opensource.altera.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: SN1PR0701CA0008.namprd07.prod.outlook.com (25.162.96.18) To BLUPR03MB1473.namprd03.prod.outlook.com (25.163.81.158) X-MS-Office365-Filtering-Correlation-Id: 5e9e8e15-d588-4f6f-db02-08d3476a0de0 X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1473;2:a+PkT49Zj04OHpwOXbJ1Od1MTac3k9LaDSN++fPXX2+SydRBK6NgOwQO4Tm1SBz5iIcb1ZK2d1dCTpsXOZqOjnLXRUOzJV2V+BkUOkbeuMU4Bsx/XrfkMF0zBACzo9vVtmzlNlLvyUD1P9d1EvYb+hGrkHL7RqejwmkoI22EM0KrQBWBfBgCE5TUghoQiW4J;3:4msaFxIbwZGxfs7JmPisCmzICRZD031kPbpgUFfEWkiKeoXzkuoptPj70uAwC1ishyYwiAXQK9jQDZXpYAvv4QDdcbb3pJ6UUfPTpif3PQLevIiCLKNDUkBNzrhJ6BVX;25:T9j8qF5wvUxKoR5icTPRgET/2s71z1QPgXXGEzksyBZk9RdTIadPTBYRDmVh85FpP9F4qblhMC6KwwOnxtbus85MTHHC6bRR8cUTSUCJP6XC4uVYEA16FoXulRG8ILdD7K4vd+7bYtgkdDa7bpRtaIPws5JqRLAX23SB7HrtA9jOhc6P4/mmb0R3WIGQE8yAXdKCiFYlT3YIljDc4TzboxrlcNW8PsLEYNqO9VrUfuVUJ8DBJPF6oV4RXh8lD76zkMZOkpPynDUKsU9KxOWPg6YuUKHRTLjj5t3QQuWm7/8Eb8pKwwWjJk8Vpm0uWqQIU20TuI4Ym4AaH73qUFYxwA==;20:pDYIbBTkBTxwHQj98n/GuJgTPu/Clu8CMgGoIDfMD6+vMji63NqTlJv2I0qRMcmKCDnvx/PD0bvTZZqgYS5nAJ/BP6teHywJX6yJhCTpMOZp4XAQMyMdmNSORjwGAH5xiFR1orPQMbKqJkOk4Gx3LVsttaDSluAH00FwB2tUXTw= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1473; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BLUPR03MB1473;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1473;BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(13024025)(13023025)(13017025)(13015025)(13018025)(8121501046)(3002001)(10201501046);SRVR:BLUPR03MB591;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB591; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1473;4:Vt1NwrIMcdvkYncR/ZaTRF3bt0krmXK7q6mDRYIQQHFo1Rsrc0+7aBriRNFnxH2U1k9CI6U5VUQ3l3BjV9lQAeLdyg9ONa5pINuUFEtB1I/VqWvaKAI6SU5ERztQABleQsMaU6zNnQa/yuTEPxQd+w1QFOBpwmRbxnW0aQb/Eqaymjo3KwV/Rzod00tp3CG6uy2cGJYhubbRj/7i1pi98AEUA8V5SlvBCcXkLcdwQSKpXXrcNE8V/0Uv3wxdHHQGQ+ZrDk/lAu/KZjNITj0ZFt9IjlOUjnvzwyJ/h0Q99JRvzPSE+i8XCsUBy13crGMZdy9YyWHpMDMkxMtQFpNf+wNRThyeHgnvn8ql/a9onKFiaiAkS7H181jth3qRVwvc X-Forefront-PRVS: 08756AC3C8 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(377454003)(24454002)(479174004)(2950100001)(5008740100001)(33656002)(87976001)(54356999)(76176999)(87266999)(50986999)(2201001)(83506001)(53806999)(65816999)(5004730100002)(50466002)(19580405001)(86362001)(122386002)(47776003)(19580395003)(42186005)(4001350100001)(5001770100001)(59896002)(23746002)(3450700001)(66066001)(65956001)(65806001)(586003)(43066003)(1096002)(77096005)(230700001)(40100003)(189998001)(3846002)(81166005)(4326007)(6116002)(2906002)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1473;H:[137.57.160.203];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?Windows-1252?Q?1;BLUPR03MB1473;23:KV+AmuL77xkcJ1h9S5ygjkAcw2meOQYtPxllG?= =?Windows-1252?Q?7DH/ZNR5PhNGEFCLlHvnXL2FYK6D+Fy9TK6/sHK66olNJDGN03oP6Eu7?= =?Windows-1252?Q?eNNZscdzIOthxFwsAieZs0KQNMzRo1zlRTzpSqBnWkrJqEsDNb8GfAQq?= =?Windows-1252?Q?GFORy48MOGHBV/ohtqAOXDBVOEX3EfmG1u4SsoJQVt/UdBsAZ+EgFNv9?= =?Windows-1252?Q?vYsaZMBwanpP8LyYNWJY4ptFb7LeNV9J5MU/sIeZ872QqfCrk6sd/Zyv?= =?Windows-1252?Q?qIkibSGzIY7dhciQ21zNK8H10LiKkp2OBz3ljE3ZRsHi5JLknsKelKyt?= =?Windows-1252?Q?HjOX5i8Tnmj0SJ5W/BGhxCCi8s0xvMi+cfAA3oPgXfnju61qvixx85pB?= =?Windows-1252?Q?I5ajgrj7S18HFqRsxU5CGSZ2NmD99omaOMO2bN8JwHZxucytJVJWabzn?= =?Windows-1252?Q?wcz85SxDq1UkA5uGbBxm+LkGUJuG4drgCwHDnYCxu+ctUpd+eD9cHGCp?= =?Windows-1252?Q?FNHzOJr7fJ+xYqgYG/hkrGUFs/ysu4Q7N3W/RltNpC62eIr2ZJxW6gHr?= =?Windows-1252?Q?vgtBgtArxk9bAQwQaAEt3egPd+TlfSzoDV6wja5Ec2hq+Z21v3rrvDT0?= =?Windows-1252?Q?ndIJzswsuLSDpkq24Ht+MJ2dcR0/MofPgdlPqmY/WhRlojPSApIsJPlP?= =?Windows-1252?Q?nspNe6toa8AY6Y42Ehwqyc5A71CDSJ+Qni3LsXiN5B02y5sZbg9v/ZJS?= =?Windows-1252?Q?7HlGQWqaPVcPsoFD+QLA+K2vqGyjrRm92Z9NNJnHnsgKorg7aF+9BJ0d?= =?Windows-1252?Q?55xNuHXOpqRJ9qR6Woa6bgk2/uD853nn3Sl1ApVPEckQ3B5KoRc8K8tP?= =?Windows-1252?Q?2FwyeBZ3qSAe6G5z0dHFWQQnv0kWFIXfmJrLExYjcP4jGsgy6t7WjHGj?= =?Windows-1252?Q?oV4to9gnUfOkJCpQwoXXIW/+KTowB0lBTUvW3HCLdgoe/JaqkFs5EOWl?= =?Windows-1252?Q?Y0Ayi8OCJxdXgcu2iPEOOInkOPDmfgmQsAZLpCIcMk95CN7h6A3WFOhf?= =?Windows-1252?Q?+QnaXXBdA/iUigXMmtH+4KRsS/nUaGeFoFvvLesuBUFDZTkFnTjEdt0V?= =?Windows-1252?Q?Ce9ZO1DksiATw9sPS+i+DXVXDJXN7GRs8qEd1u5KT0XJAi1biS+UA7p5?= =?Windows-1252?Q?+8dwZcHCqQD07VPALjawpRaJUlx3V6lKJQw11epaMxM7/RLoSE0jXrNl?= =?Windows-1252?Q?/quayQ6ige484aF5Fk166BJZ+zYNW7fixPEXxEn9iZyyq3pfFsjFWEOo?= =?Windows-1252?Q?/nKsVRpOIv0xr1FLmdZKIYTBUpglcH0dmx1ojDUzI5x8b4=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1473;5:XFzo/14+SeR9ISUKltSYpOgKy694D4klSEmtfeGm5gghJABixuSKULIFSbd64p/aQpMe2XM6nGVw7va8fDEUDmFPqG3L/3dSSnSKFN1La4UiJw8l6rIaVxSIONpw85eK5gDL8ibIy/rHnhRUGDo+Rg==;24:T8nKIqKSm3ZSWQ8Co63fjiX9YvBOEmg3oym4sryP4K34A66opTg9fmSkRzlk1J7SA2UdjV6lEJCoyXHTfFOrLdrDcJFysEbLtG4KUj1EabE=;20:xS97Vuh9WrE6Lk7vhpBi2b6aNHpZ+4F5rnHUAvCZ/OCOj9SqWGShTpWWknC1x5412QrZBDgl3/3H/4cOpFrV8BTCj+Z/AotavpXA40eKUkkaCwwqeAnEkbd2r3JOhR/lPdYSb9RLxHe/iwljCM4emkk9/5GZbGBRnzhnezkoCGg= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1473 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11FD016.protection.gbl X-Forefront-Antispam-Report: CIP:66.35.236.236;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(3190300001)(377454003)(479174004)(24454002)(189002)(199003)(16796002)(230700001)(54356999)(87266999)(956001)(6806005)(5008740100001)(5001770100001)(50986999)(76176999)(106466001)(11100500001)(65816999)(6116002)(586003)(2906002)(3846002)(85426001)(1220700001)(64126003)(43066003)(77096005)(189998001)(1096002)(40100003)(19580395003)(66066001)(3450700001)(65806001)(65956001)(3720700001)(87936001)(122386002)(19580405001)(50466002)(86362001)(80316001)(5004730100002)(83506001)(33656002)(81166005)(23746002)(105606002)(21840400001)(47776003)(4326007)(2950100001)(7099028)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB591;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD016;1:buVr050RMl9IHgwmAdEYauxkAOSYtkSbOsm7rNQS9ruEmHvDj/2W3ej1GrPJF0pG/9fIYSccPtd6UtJe7fFn0YsYYrwCk/J4h8Z1DIXCzBAWajIoOwyMLya4bhBvXXl4De/Flb6miF97OuQAY03SZ3bEDrS+VrFLXp/trXOo977It0gJWVtqjCwJALrwnp0tHiUdt15J8oi7W/qPFCKWdKhwJeUNkzBLDRvRRw1+g5XhxqKE7HBspz3XSePHs+H430vC90xZmJbdKRQoykf1rxtvKY9O/jgzcOiXBgF6YrRD05c+M9aeSNIm5a+RRrBBzGEidZJxojTIA+7iB+qcUIeVQUdJpvcfliLsbp3UjSncJ370whIEOWmtyJhsiZGzEIA8XuvEzf23waURFJsE+a2jQJkfSu81vFn6+c04w29kgxhTdhEpMlh3GnOZOSX2FJdODJlRWq6q/60bt+8Phf3ZfjQSsM3u/ey50YRmPEAj3CfO0nHGTGinQ6sKiZON X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB591;2:bXW4nNCLO+TzqmO+nmCP1Z8rTbQZAH61A1KHx+Wx6cnpkx2tw+JJSFexnaAzbUEwYVAY7thTGG3PRRdGm5PlGJjcsK4IxM0V5EDSb6dqjNsYDVVzlE+20wbZnmhbJTgvDKERkyeBP1Pgzo8PDLGEPJUEWrnyeCN7LJlSOHPbgOUFjbwxlmb9wMMciKE/0EyS;3:opSM1lkOemv1riguW480iIcf6pdlmPqJ9T2dcaIrs7JfjtEJPW2Skr8BEI9FriBkSMAxyrhyL/sghUWFGE3aiZFU5yscB6XWn6CMNVz7p4jS68+mb1L8aie5vReXeIKaXZrSa6ZxbzFMXL5gCwnynznmKaDCYHXfHiPe1PY8zdt4msxy/YiEFCjtHZ0duwbUBATl2MmYJw1hM/mD9nyb3OmDS1KI5y9KMYveBzy2VGZ7IkJX/M3VxMxGaTfmQu8l;25:ytwtG2qLGk6lKU6o+2YQAPHebNx+byJL01WFaHk1W84NeMr9pBx/iOQOGCYLWi16mFdtcYP8p/MkzNiXlQo+hJFIsrhKj5TJyyM7rzm0ksdU0Q0JwoNpJs19cr7wEQzZ/ecAPuSrXnfWIIBvI6x0826L3DXaLRIG/po6GBCLXk9LRko96ZE6dsKKklvYmAOIX8yAHZrZTxCTtmsXeYUEUr30sGKdoeOOumgIwxl+5oXve0qPatizNQX5C8KEK3r4vbdHL79+WKwbnZtzODtDbKKPXci+ib+h+iNVrFz1QOsc4edBc6Nv29lJEnPFzdfcnl4LxuneZFf/zAAw+u1S0Q==;20:0j9rV0rX3jTJvETqCwNW52P/50Vd7dWPNdTin2kBG5C0CPf+vrXCQ5OkJbSihlJ6QNCkz5ritmwUg7reIjoNpJoFvrnCKfVR5b1KCDtjHbfFMrTnQRRWihWZck1e1i7zme8jDaua8j538gBJfJPNLRTIzM1KrWtBWC6zHIdS5io= X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:BLUPR03MB591; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB591;4:sVC613FK0v7+DnSRvqC7fhLioISk+FaPsklAQpLsUVzU0gHcluVW9WSE0VzR1sfx+zk0la10NdYuYaxblWG1BFIfcKXx2wMEbP7uxOKvIPc1iW7mqDpdLXwI/GnrGVIf0ef13XJJcfV7N0J0ym8gXYtk8WB+U+h7m2W9JkuxtsrLY4KU+dUfpIBgXfMlwLNfXsUEb8UsbpRhCXcY37TYRLCJMKsXVIAIJSqXxzAmMgkzGUTd+fPBh/v3Qytl+qegzXS/aaSJkkA3P0qMm6o4napbdES3RgB6ereRqB2sHiXqaZL/YqBmHrcj8ssDcg8mbU5wkEaIMApxKLRBRuSJDENH3EY5Ve0vATzDNw5LCyifQDKaRElbXoibpGUzKcMlREE4VrgcxE3tjcFD5whOSGVAcK3j1krBRTmTwKJ2zSvPGmoDKtJ/ag78jgymlBw5Y8XdC+Ixr5g1Kodj/0kyFA== X-Forefront-PRVS: 08756AC3C8 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR03MB591;23:OCJOYRhhybFoKmpGlVSxHuNzw9MXFFRGyDeLm+?= =?Windows-1252?Q?aG3Oq8CdA4tF31nSKf8UneUg1hHHPT+iiksV1qoPirrV8Zhh4etT1j/4?= =?Windows-1252?Q?0S2LNMCnufcqO2HYyhhg9HEs/YwSpQMw/QG0kYvHDVI8pISCgqsKULR5?= =?Windows-1252?Q?o9pyxqW04+CAp0uLnYWc0twpp9SoqYT34uVzDsIupTUu1Tb0rYD3jqkc?= =?Windows-1252?Q?hUx24J0d/+J14R2fy19bUIvwXqV/em6SZDkMG/GE1GROmTCz6pURRP61?= =?Windows-1252?Q?TWLcHEVD0FA/2Wttqj9vr++TV8Vdz+1ml0ishAafplC9vhg509c8ORFP?= =?Windows-1252?Q?gXeDlE5U8tWnNhnKWMjBmBKH8u5PlEhPlm1idqTPKE3EtO6y+o1c92Dg?= =?Windows-1252?Q?D2QtLp0Xg1bje8otOCQMs/SXY85EefZzENODzbjqqyTHQjDFuBchPJSC?= =?Windows-1252?Q?sHkYlo/EH8EjUfZ6Z1/OGcwCUp5s9WPrdAkDCOJ7PI7MTlsc0uhTSvxC?= =?Windows-1252?Q?atP1FkNqrSlCDXI/mXpmKXve76P/nS6QG2aQbdGRbLiY6DmpWxUeKlAg?= =?Windows-1252?Q?QkK5KnIVVLBNcGVp6LXRoiXheBl3NNlQx/d9nk6cYvq0DdHyNJ3ERdqi?= =?Windows-1252?Q?rr50QXM2sSIiIbM3J4rCwoJTWQuMcM2QbvSsBa0bcQ8Ol4L5DajtjIMQ?= =?Windows-1252?Q?aqNDWVXSBRHf9u5mqw0WyqfOfN2TrRH60h+SBzGgP3xKT6xmVDea+sSZ?= =?Windows-1252?Q?Igcaj4rc9feH3frhQplVMShkwD/LJrunUWYf38spbvYuSEKXnuATdaIg?= =?Windows-1252?Q?BUuvYYyuKCD0noqhBWomvvkIoEgF3Vo3AmHf/aScOmDtLZKzE99KUMvm?= =?Windows-1252?Q?p46IW31XbWxKoLFWXW01t6QgsQR0RLKTTcii9vVvqEYXJehILwZ6qAOp?= =?Windows-1252?Q?iTaMaTnv2JyMQCuhbTVSTQaknP1JdYZr7EsKbHiiVn8Ptq0CmmSCV/Qy?= =?Windows-1252?Q?BwUyHSMvqJTkC6lo1xZHuMzSovyQqRKW1KmNwEYPsBlyvYzc31KePl+C?= =?Windows-1252?Q?VNZIl/cmvRrho+T0GdErE8sWraLNzaO2l8aLKbU3tbrTa6jvkQpz8GSL?= =?Windows-1252?Q?KGDUK0XCnR/ymyQSfsID1BGciWl9YcBZ2ukq2lpBw05Hg7+rvbbtNKoo?= =?Windows-1252?Q?2BQLChLPQIEd1X7tHuY8UunCwrdm/oIeT/l+glEpdeo8mDwC5Y7MKAky?= =?Windows-1252?Q?c5hAkwhvgO/VtSOsVAPhGcVkRADokXzDLCo4IPRlxqoULPZU9l80D8a8?= =?Windows-1252?Q?lPvnPFrXrDMfL2t4TAgZ767AG6cS67xqRqknvmVA7tNYyvBglo7o++6s?= =?Windows-1252?Q?eVm2fayaSsNUX3Edxcz+QxGHB2yxlyduikzYl2oc+OqMBE3nTEpmGel3?= =?Windows-1252?Q?7cZJtQax8lC3TbHUD2PQQwJ4pOt7o+NWOYXuIDkPc/cMqu9KdoRyrcr5?= =?Windows-1252?Q?hNcq0p7AF5rD7kPkAjYYIGOySp2ZNu0u2RPGYDWjo3d5AwoVJeC/XW3E?= =?Windows-1252?Q?z1Yme61paWGZPUaOsdKaXWq9F9c24bYRcI/D1hb7t5iM/SdhIdfwMCWD?= =?Windows-1252?Q?0gW5aeta3dwsR6so6dZbA=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB591;5:X6dhhT197PCXGr2ZiA6nOblACsH4gUKpASzptrhz4BEFOcwJIJbt/8suPOGQ/BFwJIgbB+Z6K4FgwxkMde9taY5pxP86+xeQwvdDvOPcemvp9D+OMhupOKRYgRFzbaHaHSYNyZrWuYbxcqMihFnEPg==;24:HOwFKFHSkzjFVstl4n/IzO/Bres2i/ZdZuSnXKtwk+ELWp9nVp84PNc7IiOqwkb8hWPHN6q8/uGIni/wxn5bOo9QP7/VUNkoqjNyZInMGoc=;20:VUOBduuVACgL4zKxZm+YjG26q1RFZOccnEa+evHfWiuV8JXRknxSpbXv767HI3+W3L+SUWZ7uyoq9yHRzQD06NKhN6jqw1KUigyvh3IYt/fNJBH6nz70NVB7M4Fs74Wqrlqj1wuHoAfqG6ElFQeG3JUC4RDqYV3/h/XmnujoTlY= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2016 15:55:21.2133 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB591 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dinh, On 03/08/2016 08:50 AM, Dinh Nguyen wrote: > > > On 03/07/2016 01:43 PM, tthayer@opensource.altera.com wrote: >> From: Thor Thayer >> >> Add the device tree entries needed to support the Altera L2 >> cache EDAC on the Arria10 chip. >> >> Signed-off-by: Thor Thayer >> --- >> v2 Match register value (l2-ecc@ffd06010) >> --- >> arch/arm/boot/dts/socfpga_arria10.dtsi | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/arch/arm/boot/dts/socfpga_arria10.dtsi b/arch/arm/boot/dts/socfpga_arria10.dtsi >> index cce9e50..44aeb3f 100644 >> --- a/arch/arm/boot/dts/socfpga_arria10.dtsi >> +++ b/arch/arm/boot/dts/socfpga_arria10.dtsi >> @@ -599,6 +599,20 @@ >> reg = <0xffe00000 0x40000>; >> }; >> >> + eccmgr: eccmgr@ffd06090 { >> + compatible = "altr,socfpga-ecc-manager"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + >> + l2-ecc@ffd06010 { >> + compatible = "altr,socfpga-a10-l2-ecc"; >> + reg = <0xffd06010 0x4>; >> + interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>, >> + <0 0 IRQ_TYPE_LEVEL_HIGH>; >> + }; >> + }; >> + > > Just checking if these addresses are correct. The eccmgr is at > 0xffd06090, but the l2-ecc is at 0xffd06010? I would have thought from > the placement the l2-ecc address would be inside the eccmgr's address? > > Dinh > Yes, this is confusing and I'll clarify/reorganize in the next series. The eccmgr is pointing to the ECC IRQ mask bits. These registers and the L2 ECC registers are organized in different areas within the system manager. I'm actually redoing the series since the Arria10 IRQ handling is significantly different. Since this change will affect the bindings and dti (the eccmgr will have the IRQs), please disregard this series. Sorry for the noise. Thor