Re: [Qemu-devel] [PATCH v2 1/7] target-tricore: Add FPU infrastructure

[Richard Henderson <rth@twiddle.net>]

On 03/08/2016 12:42 PM, Bastian Koppelmann wrote:
> +/* we don't care about input_denormal */
> +static inline uint8_t f_get_excp_flags(CPUTriCoreState *env)
> +{
> +    return env->fp_status.float_exception_flags & 0xbf;
> +}

No magic numbers please.  It's a long list, but please or all of the named 
flags together.

> +    if (flags & float_flag_invalid) {
> +        env->FPU_FI = (flags & float_flag_invalid) << 31;
> +    }

You know that float_flag_invalid is set; you just tested it.  Otherwise you're 
relying on float_flag_invalid being 1.

You know, you don't have to keep setting these to (1 << 31) either; -1 works 
just as well.



r~