Re: [Qemu-devel] [PATCH 1/2] i386: Prepare for interrupt remapping

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]

On 03/08/2016 12:28 PM, Rita Sinha wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Introduce a DMA default target address space for PCI devices. Catch all

[meta-comment]: When sending a series, both messages should be
In-Reply-To a 0/2 cover letter, rather than separate top-level threads.

> interrupt requests to the front-side bus via an MSI memory region that
> is part of that address space. Provide separate address spaces for
> IOAPIC and HPET if the IOMMU is active to prepare for adding remapping
> logic later on. Deliver the EDID from the IOAPIC for the same reason.
> 
> Allows to remove the MSI hack from the APIC MMIO write handler.

Awkward grammar, would sound better as:

Allows us to remove the MSI hack...

or

Allows the removal of the MSI hack...

I'll leave review of the patch proper to someone more familiar with the
code.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]