From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Hackmann Subject: Re: [PATCH v7 1/5] staging/android: add num_fences field to struct sync_file_info Date: Tue, 8 Mar 2016 18:36:31 -0800 Message-ID: <56DF8C2F.1040904@google.com> References: <1457034046-27678-1-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf0-x231.google.com (mail-pf0-x231.google.com [IPv6:2607:f8b0:400e:c00::231]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B3A96E805 for ; Wed, 9 Mar 2016 02:36:35 +0000 (UTC) Received: by mail-pf0-x231.google.com with SMTP id 63so27454997pfe.3 for ; Tue, 08 Mar 2016 18:36:35 -0800 (PST) In-Reply-To: <1457034046-27678-1-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, Daniel Stone , Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gMDMvMDMvMjAxNiAxMTo0MCBBTSwgR3VzdGF2byBQYWRvdmFuIHdyb3RlOgo+IEZyb206IEd1 c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jby51az4KPgo+IEluZm9y bSB1c2Vyc3BhY2UgaG93IG1hbnkgZmVuY2VzIGFyZSBpbiB0aGUgc3luY19mZW5jZV9pbmZvIGZp ZWxkLgo+Cj4gU2lnbmVkLW9mZi1ieTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5A Y29sbGFib3JhLmNvLnVrPgo+IFJldmlld2VkLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRl bi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9zdGFnaW5nL2Fu ZHJvaWQvc3luYy5jICAgICAgfCAyICsrCj4gICBkcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC91YXBp L3N5bmMuaCB8IDIgKysKPiAgIDIgZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCj4KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9zdGFnaW5nL2FuZHJvaWQvc3luYy5jIGIvZHJpdmVycy9zdGFn aW5nL2FuZHJvaWQvc3luYy5jCj4gaW5kZXggM2E4ZjIxMC4uMzFhYTQ2MiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC9zeW5jLmMKPiArKysgYi9kcml2ZXJzL3N0YWdpbmcv YW5kcm9pZC9zeW5jLmMKPiBAQCAtNTI1LDYgKzUyNSw4IEBAIHN0YXRpYyBsb25nIHN5bmNfZmls ZV9pb2N0bF9mZW5jZV9pbmZvKHN0cnVjdCBzeW5jX2ZpbGUgKnN5bmNfZmlsZSwKPiAgIAlpZiAo aW5mby0+c3RhdHVzID49IDApCj4gICAJCWluZm8tPnN0YXR1cyA9ICFpbmZvLT5zdGF0dXM7Cj4K PiArCWluZm8tPm51bV9mZW5jZXMgPSBzeW5jX2ZpbGUtPm51bV9mZW5jZXM7Cj4gKwo+ICAgCWxl biA9IHNpemVvZihzdHJ1Y3Qgc3luY19maWxlX2luZm8pOwo+Cj4gICAJZm9yIChpID0gMDsgaSA8 IHN5bmNfZmlsZS0+bnVtX2ZlbmNlczsgKytpKSB7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3Rh Z2luZy9hbmRyb2lkL3VhcGkvc3luYy5oIGIvZHJpdmVycy9zdGFnaW5nL2FuZHJvaWQvdWFwaS9z eW5jLmgKPiBpbmRleCBhMGNmMzU3Li40ZmZiN2NjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvc3Rh Z2luZy9hbmRyb2lkL3VhcGkvc3luYy5oCj4gKysrIGIvZHJpdmVycy9zdGFnaW5nL2FuZHJvaWQv dWFwaS9zeW5jLmgKPiBAQCAtNDcsMTIgKzQ3LDE0IEBAIHN0cnVjdCBzeW5jX2ZlbmNlX2luZm8g ewo+ICAgICoJCXVzZXJzcGFjZSBpbmNsdWRpbmcgcHRfaW5mby4KPiAgICAqIEBuYW1lOgluYW1l IG9mIGZlbmNlCj4gICAgKiBAc3RhdHVzOglzdGF0dXMgb2YgZmVuY2UuIDE6IHNpZ25hbGVkIDA6 YWN0aXZlIDwwOmVycm9yCj4gKyAqIEBudW1fZmVuY2VzCW51bWJlciBvZiBmZW5jZXMgaW4gdGhl IHN5bmNfZmlsZQo+ICAgICogQHN5bmNfZmVuY2VfaW5mbzogYXJyYXkgb2Ygc3luY19mZW5jZV9p bmZvIGZvciBldmVyeSBmZW5jZSBpbiB0aGUgc3luY19maWxlCj4gICAgKi8KPiAgIHN0cnVjdCBz eW5jX2ZpbGVfaW5mbyB7Cj4gICAJX191MzIJbGVuOwo+ICAgCWNoYXIJbmFtZVszMl07Cj4gICAJ X19zMzIJc3RhdHVzOwo+ICsJX191MzIJbnVtX2ZlbmNlczsKPgo+ICAgCV9fdTgJc3luY19mZW5j ZV9pbmZvWzBdOwo+ICAgfTsKPgoKR3JlZywgdGhpcyBpcyB1bHRpbWF0ZWx5IHlvdXIgY2FsbC4g IEJ1dCB0byBlY2hvIHdoYXQgSSBzYWlkIGJlZm9yZSwgSSdtIApPSyB3aXRoIHRoZSBBQkkgYnJl YWsgaGVyZSBpZiB0aGF0J3Mgd2hhdCdzIG5lZWRlZCB0byBnZXQgc3luYyBtb3ZlZCBvdXQgCm9m IHN0YWdpbmcuCgpQcmFnbWF0aWNhbGx5IHNwZWFraW5nLCB0aGlzIHdvbid0IGJyZWFrIG9yZGlu YXJ5IEFuZHJvaWQgYXBwcywgYmVjYXVzZSAKdGhleSBkb24ndCBnZXQgZGlyZWN0IGFjY2VzcyB0 byBzeW5jIGZlbmNlIGZkcyB0byBiZWdpbiB3aXRoLiAgU29tZSAKcHJpdmlsZWdlZCBzeXN0ZW0g cHJvY2Vzc2VzIGRvLCBidXQgdGhleSBnbyB0aHJvdWdoIGxpYnN5bmMsIHdoaWNoIGNhbiAKYmUg Y2hhbmdlZCB0byBkZWFsIHdpdGggdGhlIEFCSSBkaWZmZXJlbmNlcy4KCkFueXdheSwgZm9yIHRo ZSB3aG9sZSBzZXJpZXM6CgpBY2tlZC1ieTogR3JlZyBIYWNrbWFubiA8Z2hhY2ttYW5uQGdvb2ds ZS5jb20+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751568AbcCICgo (ORCPT ); Tue, 8 Mar 2016 21:36:44 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:34346 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbcCICgf (ORCPT ); Tue, 8 Mar 2016 21:36:35 -0500 Subject: Re: [PATCH v7 1/5] staging/android: add num_fences field to struct sync_file_info To: Gustavo Padovan , Greg Kroah-Hartman References: <1457034046-27678-1-git-send-email-gustavo@padovan.org> Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , Daniel Vetter , Rob Clark , John Harrison , Maarten Lankhorst , Gustavo Padovan From: Greg Hackmann Message-ID: <56DF8C2F.1040904@google.com> Date: Tue, 8 Mar 2016 18:36:31 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1457034046-27678-1-git-send-email-gustavo@padovan.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/03/2016 11:40 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Inform userspace how many fences are in the sync_fence_info field. > > Signed-off-by: Gustavo Padovan > Reviewed-by: Maarten Lankhorst > --- > drivers/staging/android/sync.c | 2 ++ > drivers/staging/android/uapi/sync.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c > index 3a8f210..31aa462 100644 > --- a/drivers/staging/android/sync.c > +++ b/drivers/staging/android/sync.c > @@ -525,6 +525,8 @@ static long sync_file_ioctl_fence_info(struct sync_file *sync_file, > if (info->status >= 0) > info->status = !info->status; > > + info->num_fences = sync_file->num_fences; > + > len = sizeof(struct sync_file_info); > > for (i = 0; i < sync_file->num_fences; ++i) { > diff --git a/drivers/staging/android/uapi/sync.h b/drivers/staging/android/uapi/sync.h > index a0cf357..4ffb7cc 100644 > --- a/drivers/staging/android/uapi/sync.h > +++ b/drivers/staging/android/uapi/sync.h > @@ -47,12 +47,14 @@ struct sync_fence_info { > * userspace including pt_info. > * @name: name of fence > * @status: status of fence. 1: signaled 0:active <0:error > + * @num_fences number of fences in the sync_file > * @sync_fence_info: array of sync_fence_info for every fence in the sync_file > */ > struct sync_file_info { > __u32 len; > char name[32]; > __s32 status; > + __u32 num_fences; > > __u8 sync_fence_info[0]; > }; > Greg, this is ultimately your call. But to echo what I said before, I'm OK with the ABI break here if that's what's needed to get sync moved out of staging. Pragmatically speaking, this won't break ordinary Android apps, because they don't get direct access to sync fence fds to begin with. Some privileged system processes do, but they go through libsync, which can be changed to deal with the ABI differences. Anyway, for the whole series: Acked-by: Greg Hackmann