From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Hackmann Subject: Re: [PATCH] staging/android: change IOCTLs opcode after ABI change Date: Tue, 8 Mar 2016 18:36:45 -0800 Message-ID: <56DF8C3D.7030005@google.com> References: <1457034046-27678-5-git-send-email-gustavo@padovan.org> <1457044963-5785-1-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-x22b.google.com (mail-pa0-x22b.google.com [IPv6:2607:f8b0:400e:c03::22b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 712916E806 for ; Wed, 9 Mar 2016 02:36:48 +0000 (UTC) Received: by mail-pa0-x22b.google.com with SMTP id tt10so26766967pab.3 for ; Tue, 08 Mar 2016 18:36:48 -0800 (PST) In-Reply-To: <1457044963-5785-1-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, Daniel Stone , Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gMDMvMDMvMjAxNiAwMjo0MiBQTSwgR3VzdGF2byBQYWRvdmFuIHdyb3RlOgo+IEZyb206IEd1 c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jby51az4KPgo+IEJ1cm4g dGhlIG9sZCBvcGNvZGUgdG8gYXZvaWQgYW55IHBvdGVudGlhbCBvbGQgdXNlcnNwYWNlIHJ1bm5p bmcgdGhlIG9sZAo+IEFQSSB0byBnZXQgd2VpcmQgZXJyb3JzLiBDaGFuZ2luZyB0aGUgb3Bjb2Rl cyB3aWxsIG1ha2UgdGhlbSBmYWlsIHJpZ2h0Cj4gYXdheS4KPgo+IFRoaXMgaXMganVzdCBhIHBy ZWNhdXRpb24sIHRoZXJlIG5vIHVwc3RyZWFtIHVzZXJzIG9mIHRoZXNlIGludGVyZmFjZXMKPiB5 ZXQgYW5kIHRoZSBvbmx5IHVzZXIgaXMgQW5kcm9pZCwgYnV0IHdlIGRvbid0IGV4cGVjdCBhbnlv bmUgdHJ5aW5nIHRvCj4gcnVuIGFuZHJvaWQgdXNlcnNwYWNlIGFuZCBhbGwgaXQgZGVwZW5kZW5j aWVzIG9uIHRvcCBvZiB1cHN0cmVhbSBrZXJuZWxzLgo+Cj4gTW9yZW92ZXIgQW5kcm9pZCBzaG91 bGQgYmUgY29udmVydGVkIHRvIHVzZSB1cHN0cmVhbSBzeW5jX2ZpbGVzLgo+Cj4gU3VnZ2VzdGVk LWJ5OiBSb2IgQ2xhcmsgPHJvYmRjbGFya0BnbWFpbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogR3Vz dGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29sbGFib3JhLmNvLnVrPgoKQWNrZWQtYnk6 IEdyZWcgSGFja21hbm4gPGdoYWNrbWFubkBnb29nbGUuY29tPgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751849AbcCICg6 (ORCPT ); Tue, 8 Mar 2016 21:36:58 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:35931 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592AbcCICgs (ORCPT ); Tue, 8 Mar 2016 21:36:48 -0500 Subject: Re: [PATCH] staging/android: change IOCTLs opcode after ABI change To: Gustavo Padovan , Greg Kroah-Hartman References: <1457034046-27678-5-git-send-email-gustavo@padovan.org> <1457044963-5785-1-git-send-email-gustavo@padovan.org> Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , Daniel Vetter , Rob Clark , John Harrison , Maarten Lankhorst , Gustavo Padovan From: Greg Hackmann Message-ID: <56DF8C3D.7030005@google.com> Date: Tue, 8 Mar 2016 18:36:45 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1457044963-5785-1-git-send-email-gustavo@padovan.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/03/2016 02:42 PM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Burn the old opcode to avoid any potential old userspace running the old > API to get weird errors. Changing the opcodes will make them fail right > away. > > This is just a precaution, there no upstream users of these interfaces > yet and the only user is Android, but we don't expect anyone trying to > run android userspace and all it dependencies on top of upstream kernels. > > Moreover Android should be converted to use upstream sync_files. > > Suggested-by: Rob Clark > Signed-off-by: Gustavo Padovan Acked-by: Greg Hackmann