From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51163)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1adYki-0006yV-Ae
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 02:41:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1adYkh-0002Xq-F4
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 02:41:52 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1455645388-32401-1-git-send-email-pbonzini@redhat.com>
	<1455645388-32401-6-git-send-email-pbonzini@redhat.com>
	<20160309031950.GD17947@ad.usersys.redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56DFD3B7.1020809@redhat.com>
Date: Wed, 9 Mar 2016 08:41:43 +0100
MIME-Version: 1.0
In-Reply-To: <20160309031950.GD17947@ad.usersys.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 05/16] mirror: use bottom half to re-enter
 coroutine
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com



On 09/03/2016 04:19, Fam Zheng wrote:
>> > +    /* The I/O operation is not finished until the callback returns.
>> > +     * If we call qemu_coroutine_enter here, there is the possibility
>> > +     * of a deadlock when the coroutine calls bdrv_drained_begin.
>> > +     */
>> > +    op->co_enter_bh = qemu_bh_new(mirror_bh_cb, op);
> Shouldn't this be aio_bh_new()?

Yes, of course.

Paolo