From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elaine Zhang Subject: Re: [PATCH v5 5/6] dt/bindings: rockchip: modify document of Rockchip power domains Date: Wed, 09 Mar 2016 16:48:31 +0800 Message-ID: <56DFE35F.3010400@rock-chips.com> References: <1456992233-25164-1-git-send-email-zhangqing@rock-chips.com> <1456992557-25331-1-git-send-email-zhangqing@rock-chips.com> <56DEB2E1.6060808@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56DEB2E1.6060808-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Caesar Wang , wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org Cc: huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, xxx-TNX95d0MmH7DzftRWevZcw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org, jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org CgpPbiAwMy8wOC8yMDE2IDA3OjA5IFBNLCBDYWVzYXIgV2FuZyB3cm90ZToKPgo+Cj4g5ZyoIDIw MTblubQwM+aciDAz5pelIDE2OjA5LCBFbGFpbmUgWmhhbmcg5YaZ6YGTOgo+PiBBZGQgYmluZGlu ZyBkb2N1bWVudGF0aW9uIGZvciB0aGUgcG93ZXIgZG9tYWlucwo+PiBmb3VuZCBvbiBSb2NrY2hp cCBSSzMzOTkgU29Dcy4KPj4gUkszMzk5IHBkIG9uL29mZiBub3QgbmVlZCB0byBlbmFibGUgY2xr IHdoaWNoIGluIHRoaXMgcGQuCj4+IFNvIHJlbW92ZSB0aGUgY2xvY2tzIGluIHRoZSByazMzOTkg cGQgZXhhbXBsZS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogRWxhaW5lIFpoYW5nIDx6aGFuZ3FpbmdA cm9jay1jaGlwcy5jb20+Cj4+IC0tLQo+PiAgIC4uLi9iaW5kaW5ncy9zb2Mvcm9ja2NoaXAvcG93 ZXJfZG9tYWluLnR4dCAgICAgICAgIHwgMzcKPj4gKysrKysrKysrKysrKysrKysrKysrKwo+PiAg IDEgZmlsZSBjaGFuZ2VkLCAzNyBpbnNlcnRpb25zKCspCj4+Cj4+IGRpZmYgLS1naXQKPj4gYS9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc29jL3JvY2tjaGlwL3Bvd2VyX2RvbWFp bi50eHQKPj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc29jL3JvY2tjaGlw L3Bvd2VyX2RvbWFpbi50eHQKPj4gaW5kZXggMTNkYzZhMy4uOTgwODVjOCAxMDA2NDQKPj4gLS0t IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9yb2NrY2hpcC9wb3dlcl9k b21haW4udHh0Cj4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb2Mv cm9ja2NoaXAvcG93ZXJfZG9tYWluLnR4dAo+PiBAQCAtNyw2ICs3LDcgQEAgUmVxdWlyZWQgcHJv cGVydGllcyBmb3IgcG93ZXIgZG9tYWluIGNvbnRyb2xsZXI6Cj4+ICAgLSBjb21wYXRpYmxlOiBT aG91bGQgYmUgb25lIG9mIHRoZSBmb2xsb3dpbmcuCj4gWy4uLi5dCj4+ICAgRXhhbXBsZSBvZiB0 aGUgbm9kZSB1c2luZyBwb3dlciBkb21haW46Cj4+IEBAIC02NSwzICs5Niw5IEBAIEV4YW1wbGUg b2YgdGhlIG5vZGUgdXNpbmcgcG93ZXIgZG9tYWluOgo+PiAgICAgICAgICAgICAgICAgICBwb3dl ci1kb21haW5zID0gPCZwb3dlciBSSzMzNjhfUERfR1BVXzE+Owo+PiAgICAgICAgICAgICAgICAg ICAvKiAuLi4gKi8KPj4gICAgICAgICAgIH07Cj4+ICsKPj4gKyAgICBub2RlIHsKPj4gKyAgICAg ICAgLyogLi4uICovCj4+ICsgICAgICAgIHBvd2VyLWRvbWFpbnMgPSA8JnBvd2VyIFJLMzM5OV9Q RF9WT1BCPjsKPj4gKyAgICAgICAgLyogLi4uICovCj4+ICsgICAgfTsKPgo+IFRyaXZpYWw6IHR5 cG8KPiAgICAgICAgICAgICAgICAgIHBvd2VyOiBwb3dlci1jb250cm9sbGVyIHsKPiBAQCAtOTIs MTAgKzkyLDEwIEBAIEV4YW1wbGUgb2YgdGhlIG5vZGUgdXNpbmcgcG93ZXIgZG9tYWluOgo+ICAg ICAgICAgIH07Cj4KPiAgICAgICAgICBub2RlIHsKPiAtICAgICAgICAgICAgICAgIC8qIC4uLiAq Lwo+IC0gICAgICAgICAgICAgICAgcG93ZXItZG9tYWlucyA9IDwmcG93ZXIgUkszMzY4X1BEX0dQ VV8xPjsKPiAtICAgICAgICAgICAgICAgIC8qIC4uLiAqLwo+IC0gICAgICAgIH07Cj4gKyAgICAg ICAgICAgICAgIC8qIC4uLiAqLwo+ICsgICAgICAgICAgICAgICBwb3dlci1kb21haW5zID0gPCZw b3dlciBSSzMzNjhfUERfR1BVXzE+Owo+ICsgICAgICAgICAgICAgICAvKiAuLi4gKi8KPiArICAg ICAgIH07ClRoaXMgaXMgYSBleGFtcGxlLkkgdGhpbmsgdGhlcmUgaXMgbm8gcHJvYmxlbS4KCj4K Pgo+Cj4KPgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt cm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhangqing@rock-chips.com (Elaine Zhang) Date: Wed, 09 Mar 2016 16:48:31 +0800 Subject: [PATCH v5 5/6] dt/bindings: rockchip: modify document of Rockchip power domains In-Reply-To: <56DEB2E1.6060808@gmail.com> References: <1456992233-25164-1-git-send-email-zhangqing@rock-chips.com> <1456992557-25331-1-git-send-email-zhangqing@rock-chips.com> <56DEB2E1.6060808@gmail.com> Message-ID: <56DFE35F.3010400@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/08/2016 07:09 PM, Caesar Wang wrote: > > > ? 2016?03?03? 16:09, Elaine Zhang ??: >> Add binding documentation for the power domains >> found on Rockchip RK3399 SoCs. >> RK3399 pd on/off not need to enable clk which in this pd. >> So remove the clocks in the rk3399 pd example. >> >> Signed-off-by: Elaine Zhang >> --- >> .../bindings/soc/rockchip/power_domain.txt | 37 >> ++++++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> index 13dc6a3..98085c8 100644 >> --- a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> +++ b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> @@ -7,6 +7,7 @@ Required properties for power domain controller: >> - compatible: Should be one of the following. > [....] >> Example of the node using power domain: >> @@ -65,3 +96,9 @@ Example of the node using power domain: >> power-domains = <&power RK3368_PD_GPU_1>; >> /* ... */ >> }; >> + >> + node { >> + /* ... */ >> + power-domains = <&power RK3399_PD_VOPB>; >> + /* ... */ >> + }; > > Trivial: typo > power: power-controller { > @@ -92,10 +92,10 @@ Example of the node using power domain: > }; > > node { > - /* ... */ > - power-domains = <&power RK3368_PD_GPU_1>; > - /* ... */ > - }; > + /* ... */ > + power-domains = <&power RK3368_PD_GPU_1>; > + /* ... */ > + }; This is a example.I think there is no problem. > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752669AbcCIIxL (ORCPT ); Wed, 9 Mar 2016 03:53:11 -0500 Received: from regular1.263xmail.com ([211.150.99.131]:50759 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbcCIIxC (ORCPT ); Wed, 9 Mar 2016 03:53:02 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: zhangqing@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zhangqing@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <56DFE35F.3010400@rock-chips.com> Date: Wed, 09 Mar 2016 16:48:31 +0800 From: Elaine Zhang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Caesar Wang , wxt@rock-chips.com CC: heiko@sntech.de, khilman@baylibre.com, huangtao@rock-chips.com, xxx@rock-chips.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, zyw@rock-chips.com, jay.xu@rock-chips.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 5/6] dt/bindings: rockchip: modify document of Rockchip power domains References: <1456992233-25164-1-git-send-email-zhangqing@rock-chips.com> <1456992557-25331-1-git-send-email-zhangqing@rock-chips.com> <56DEB2E1.6060808@gmail.com> In-Reply-To: <56DEB2E1.6060808@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08/2016 07:09 PM, Caesar Wang wrote: > > > 在 2016年03月03日 16:09, Elaine Zhang 写道: >> Add binding documentation for the power domains >> found on Rockchip RK3399 SoCs. >> RK3399 pd on/off not need to enable clk which in this pd. >> So remove the clocks in the rk3399 pd example. >> >> Signed-off-by: Elaine Zhang >> --- >> .../bindings/soc/rockchip/power_domain.txt | 37 >> ++++++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> index 13dc6a3..98085c8 100644 >> --- a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> +++ b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> @@ -7,6 +7,7 @@ Required properties for power domain controller: >> - compatible: Should be one of the following. > [....] >> Example of the node using power domain: >> @@ -65,3 +96,9 @@ Example of the node using power domain: >> power-domains = <&power RK3368_PD_GPU_1>; >> /* ... */ >> }; >> + >> + node { >> + /* ... */ >> + power-domains = <&power RK3399_PD_VOPB>; >> + /* ... */ >> + }; > > Trivial: typo > power: power-controller { > @@ -92,10 +92,10 @@ Example of the node using power domain: > }; > > node { > - /* ... */ > - power-domains = <&power RK3368_PD_GPU_1>; > - /* ... */ > - }; > + /* ... */ > + power-domains = <&power RK3368_PD_GPU_1>; > + /* ... */ > + }; This is a example.I think there is no problem. > > > > >