Re: [PATCH] spi/spi-xilinx: Add clock support

[Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>]

On 03/08/2016 09:42 AM, Shubhrajyoti Datta wrote:
> Add basic clock support. The clocks are requested at probe
> and released at remove.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/spi/spi-xilinx.c |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 3009121..7e12338 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -21,6 +21,7 @@
>  #include <linux/spi/spi_bitbang.h>
>  #include <linux/spi/xilinx_spi.h>
>  #include <linux/io.h>
> +#include <linux/clk.h>
>  
>  #define XILINX_SPI_MAX_CS	32
>  
> @@ -83,6 +84,7 @@ struct xilinx_spi {
>  	struct spi_bitbang bitbang;
>  	struct completion done;
>  	void __iomem	*regs;	/* virt. address of the control registers */
> +	struct clk *clk;
>  
>  	int		irq;
>  
> @@ -428,6 +430,15 @@ static int xilinx_spi_probe(struct platform_device *pdev)
>  		goto put_master;
>  	}
>  
> +	xspi->clk = devm_clk_get(&pdev->dev, NULL);

Considering that the core has multiple clock inputs this should specify
which clock you are referencing here.

Also this breaks existing devicetrees which do not specify the clock...

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html