From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-renesas-soc@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
Magnus Damm <magnus.damm@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms
Date: Wed, 9 Mar 2016 15:51:09 +0300 [thread overview]
Message-ID: <56E01C3D.1060600@cogentembedded.com> (raw)
In-Reply-To: <CACRpkdZzbp5MwD6uH=GbkYbvB=HsGOHYi+HcYpn5gZacmRwHwg@mail.gmail.com>
Hello.
On 3/9/2016 1:32 PM, Linus Walleij wrote:
>>>> This approach is better then, won't have to fix again whenever SH gets DT
>>>> support.
>>>
>>> Perhaps the of_have_populated_dt() check should be moved inside
>>> pinctrl_provide_dummies()?
>>
>> I suggest we pick up this patch now even with stable tag (the irq storm
>> fixup doesn't work correctly because of this) and consider the
>> refactoring as a second step?
>
> Sergei, Geert, do you ACK this?
Since this patch fixes the real issue in mainline (which I wasn't aware of
-- my patch only describes an issue with the 'ravb' driver the patches for
using which in gen2 were never sent upstream):
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
I'd only like that the "Fixes:" and "Cc:" tags were added to it.
> Yours,
> Linus Walleij
MBR, Sergei
next prev parent reply other threads:[~2016-03-09 12:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 18:40 [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms Wolfram Sang
2016-03-07 19:56 ` Geert Uytterhoeven
2016-03-07 20:02 ` Sergei Shtylyov
2016-03-07 20:29 ` Geert Uytterhoeven
2016-03-07 20:34 ` Sergei Shtylyov
2016-03-07 21:00 ` Geert Uytterhoeven
2016-03-07 21:19 ` Sergei Shtylyov
2016-03-08 8:15 ` Geert Uytterhoeven
2016-03-07 22:21 ` Wolfram Sang
2016-03-09 10:30 ` Linus Walleij
2016-03-09 9:58 ` Wolfram Sang
2016-03-09 10:32 ` Linus Walleij
2016-03-09 12:51 ` Sergei Shtylyov [this message]
2016-03-09 15:37 ` Wolfram Sang
2016-03-09 13:17 ` Geert Uytterhoeven
2016-03-29 5:48 ` Shawn Guo
2016-03-15 8:29 ` Linus Walleij
2016-03-15 9:08 ` Geert Uytterhoeven
2016-03-15 12:31 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E01C3D.1060600@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=kernel@pengutronix.de \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=shawnguo@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.