All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jarno Rajahalme <jarno@ovn.org>, netfilter-devel@vger.kernel.org
Cc: netdev@vger.kernel.org, dev@openvswitch.org
Subject: Re: [PATCH nf-next v8 3/8] openvswitch: Add commentary to conntrack.c
Date: Wed, 9 Mar 2016 16:50:13 +0300	[thread overview]
Message-ID: <56E02A15.6030005@cogentembedded.com> (raw)
In-Reply-To: <1457483084-13944-3-git-send-email-jarno@ovn.org>

Hello.

On 3/9/2016 3:24 AM, Jarno Rajahalme wrote:

> This makes the code easier to understand and the following patches
> more focused.
>
> Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
> ---
>   net/openvswitch/conntrack.c | 21 ++++++++++++++++++++-
>   1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
> index 3045290..8cd0110 100644
> --- a/net/openvswitch/conntrack.c
> +++ b/net/openvswitch/conntrack.c
[...]
> @@ -418,6 +429,13 @@ static int ovs_ct_lookup(struct net *net, struct sw_flow_key *key,
>   {
>   	struct nf_conntrack_expect *exp;
>
> +	/* If we pass an expected packet through nf_conntrack_in() the
> +	 * expectiation is typically removed, but the packet could still be

    Expectation.
[...]

MBR, Sergei

  reply	other threads:[~2016-03-09 13:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09  0:24 [PATCH nf-next v8 1/8] netfilter: Remove IP_CT_NEW_REPLY definition Jarno Rajahalme
     [not found] ` <1457483084-13944-1-git-send-email-jarno-LZ6Gd1LRuIk@public.gmane.org>
2016-03-09  0:24   ` [PATCH nf-next v8 2/8] netfilter: Allow calling into nat helper without skb_dst Jarno Rajahalme
2016-03-09  0:24 ` [PATCH nf-next v8 3/8] openvswitch: Add commentary to conntrack.c Jarno Rajahalme
2016-03-09 13:50   ` Sergei Shtylyov [this message]
     [not found]     ` <56E02A15.6030005-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-03-09 23:14       ` Jarno Rajahalme
2016-03-09  0:24 ` [PATCH nf-next v8 4/8] openvswitch: Update the CT state key only after nf_conntrack_in() Jarno Rajahalme
2016-03-09  0:24 ` [PATCH nf-next v8 5/8] openvswitch: Find existing conntrack entry after upcall Jarno Rajahalme
2016-03-09  0:24 ` [PATCH nf-next v8 6/8] openvswitch: Handle NF_REPEAT in conntrack action Jarno Rajahalme
2016-03-09  0:24 ` [PATCH nf-next v8 7/8] openvswitch: Delay conntrack helper call for new connections Jarno Rajahalme
2016-03-09  0:24 ` [PATCH nf-next v8 8/8] openvswitch: Interface with NAT Jarno Rajahalme
2016-03-09  5:21   ` kbuild test robot
2016-03-09  5:34   ` kbuild test robot
2016-03-09  8:04   ` kbuild test robot
2016-03-09 23:11     ` Jarno Rajahalme
2016-03-10  9:16 ` [PATCH nf-next v8 1/8] netfilter: Remove IP_CT_NEW_REPLY definition Or Gerlitz
2016-03-10 18:44   ` Jarno Rajahalme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E02A15.6030005@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=dev@openvswitch.org \
    --cc=jarno@ovn.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.