From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [RFC PATCH v1 0/9] Tests for sync infrastructure Date: Wed, 9 Mar 2016 09:13:00 -0700 Message-ID: <56E04B8C.7000504@osg.samsung.com> References: <1457537342-678-1-git-send-email-emilio.lopez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1457537342-678-1-git-send-email-emilio.lopez@collabora.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: =?UTF-8?Q?Emilio_L=c3=b3pez?= Cc: devel@driverdev.osuosl.org, Rob Clark , Daniel Stone , Daniel Vetter , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Maarten Lankhorst , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Shuah Khan , Riley Andrews , Greg Hackmann , linux-kselftest@vger.kernel.org, Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gMDMvMDkvMjAxNiAwODoyOCBBTSwgRW1pbGlvIEzDs3BleiB3cm90ZToKPiBIZWxsbyBldmVy eW9uZSwKPiAKPiBUaGlzIGlzIGEgc2VyaWVzIG9mIHRlc3RzIHRvIGV4ZXJjaXNlIHRoZSBzeW5j IGtlcm5lbCBpbmZyYXN0cnVjdHVyZS4gSXQgaXMKPiBtZWFudCB0byBiZSBhIHRlc3Qgc3VpdGUg Zm9yIHRoZSB3b3JrIEd1c3Rhdm8gaGFzIGJlZW4gZG9pbmcgdG8gZGVzdGFnZSBpdCwKPiBzZWUg WzBdIGZvciBoaXMgbGF0ZXN0IHNlcmllcyB0byBkYXRlLgo+IAo+IFRoZXNlIHRlc3RzIHdlcmUg b3JpZ2luYWxseSBwYXJ0IG9mIGEgYmF0dGVyeSBvZiB0ZXN0cyBzaGlwcGluZyB3aXRoCj4gQW5k cm9pZCdzIGxpYnN5bmMgdGhhdCB3ZXJlIHJld3JpdHRlbiB0byB1c2UgdGhlIG5ldyB1c2Vyc3Bh Y2UgaW50ZXJmYWNlcy4KPiAKPiBBcyB1c3VhbCwgYWxsIGNvbW1lbnRzIGFyZSB3ZWxjb21lLgo+ IAo+IENoZWVycyEKPiBFbWlsaW8KPiAKPiBbMF0gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvYXJjaGl2ZXMvZHJpLWRldmVsLzIwMTYtTWFyY2gvMTAyMjA0Lmh0bWwKCkdvb2QgdG8gc2Vl IHRoaXMgc3VpdGUgYWRkZWQgdG8gS3NlbGZ0ZXN0LiBUaGFua3MgZm9yCmJlaW5nIHRob3JvdWdo IGFuZCBpbmNsdWRpbmcgLmdpdGlnbm9yZS4KCkFyZSB0aGVyZSBhbnkgZGVzdHJ1Y3RpdmUgYW5k L29yIGxvbmdlciB0aW1lIHRlc3RzCmluIHRoaXMgc3VpdGUuIElmIHNvIGNvdWxkIHlvdSBwbGVh c2UgbWFrZSB0aGVtCm9wdGlvbmFsIHRvIHJ1bi4gUGxlYXNlIHNlZSBzZWxmdGVzdHMvdGltZXJz IGFzIGFuCmV4YW1wbGUgZm9yIGV4Y2x1ZGluZy4KCk1vcmUgY29tbWVudHMgb24gaW5kaXZpZHVh bCBwYXRjaGVzIHRvIGZvbGxvdy4KCnRoYW5rcywKLS0gU2h1YWgKCj4gCj4gCj4gRW1pbGlvIEzD s3BleiAoOSk6Cj4gICBzZWxmdGVzdDogc3luYzogYmFzaWMgdGVzdHMgZm9yIHN3X3N5bmMgZnJh bWV3b3JrCj4gICBzZWxmdGVzdDogc3luYzogZmVuY2UgdGVzdHMgZm9yIHN3X3N5bmMgZnJhbWV3 b3JrCj4gICBzZWxmdGVzdDogc3luYzogbWVyZ2UgdGVzdHMgZm9yIHN3X3N5bmMgZnJhbWV3b3Jr Cj4gICBzZWxmdGVzdDogc3luYzogd2FpdCB0ZXN0cyBmb3Igc3dfc3luYyBmcmFtZXdvcmsKPiAg IHNlbGZ0ZXN0OiBzeW5jOiBkZXN0cnVjdGlvbiB0ZXN0cyBmb3Igc3dfc3luYyBmcmFtZXdvcmsK PiAgIHNlbGZ0ZXN0OiBzeW5jOiBzdHJlc3MgdGVzdCBmb3IgcGFyYWxsZWxpc20KPiAgIHNlbGZ0 ZXN0OiBzeW5jOiBzdHJlc3MgY29uc3VtZXIvcHJvZHVjZXIgdGVzdAo+ICAgc2VsZnRlc3Q6IHN5 bmM6IHN0cmVzcyB0ZXN0IGZvciBtZXJnZXMKPiAgIHNlbGZ0ZXN0OiBzeW5jOiBkaXNhYmxlIHRl c3RzIHRoYXQgcmVseSBvbiBub3QgeWV0IGRlZmluZWQgYmVoYXZpb3VyCj4gCj4gIHRvb2xzL3Rl c3Rpbmcvc2VsZnRlc3RzL01ha2VmaWxlICAgICAgICAgICAgICAgICAgIHwgICAxICsKPiAgdG9v bHMvdGVzdGluZy9zZWxmdGVzdHMvc3luYy8uZ2l0aWdub3JlICAgICAgICAgICAgfCAgIDEgKwo+ ICB0b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9zeW5jL01ha2VmaWxlICAgICAgICAgICAgICB8ICAy OCArKysKPiAgdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvc3luYy9zd19zeW5jLmggICAgICAgICAg ICAgfCAgNDYgKysrKysKPiAgdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvc3luYy9zeW5jLmMgICAg ICAgICAgICAgICAgfCAyMDMgKysrKysrKysrKysrKysrKysrKysrCj4gIHRvb2xzL3Rlc3Rpbmcv c2VsZnRlc3RzL3N5bmMvc3luYy5oICAgICAgICAgICAgICAgIHwgMTE5ICsrKysrKysrKysrKwo+ ICB0b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9zeW5jL3N5bmNfYWxsb2MuYyAgICAgICAgICB8ICA3 NCArKysrKysrKwo+ICB0b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9zeW5jL3N5bmNfZGVzdHJveWVk LmMgICAgICB8ICA5MCArKysrKysrKysKPiAgdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvc3luYy9z eW5jX2ZlbmNlLmMgICAgICAgICAgfCAxMzQgKysrKysrKysrKysrKysKPiAgdG9vbHMvdGVzdGlu Zy9zZWxmdGVzdHMvc3luYy9zeW5jX21lcmdlLmMgICAgICAgICAgfCAgNjAgKysrKysrCj4gIC4u Li90ZXN0aW5nL3NlbGZ0ZXN0cy9zeW5jL3N5bmNfc3RyZXNzX2NvbnN1bWVyLmMgIHwgMTg1ICsr KysrKysrKysrKysrKysrKysKPiAgdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvc3luYy9zeW5jX3N0 cmVzc19tZXJnZS5jICAgfCAxMTUgKysrKysrKysrKysrCj4gIC4uLi9zZWxmdGVzdHMvc3luYy9z eW5jX3N0cmVzc19wYXJhbGxlbGlzbS5jICAgICAgIHwgMTExICsrKysrKysrKysrCj4gIHRvb2xz L3Rlc3Rpbmcvc2VsZnRlc3RzL3N5bmMvc3luY190ZXN0LmMgICAgICAgICAgIHwgIDg3ICsrKysr KysrKwo+ICB0b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9zeW5jL3N5bmNfd2FpdC5jICAgICAgICAg ICB8ICA5NSArKysrKysrKysrCj4gIHRvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL3N5bmMvc3luY3Rl c3QuaCAgICAgICAgICAgIHwgIDY5ICsrKysrKysKPiAgMTYgZmlsZXMgY2hhbmdlZCwgMTQxOCBp bnNlcnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCB0b29scy90ZXN0aW5nL3NlbGZ0ZXN0 cy9zeW5jLy5naXRpZ25vcmUKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IHRvb2xzL3Rlc3Rpbmcvc2Vs ZnRlc3RzL3N5bmMvTWFrZWZpbGUKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IHRvb2xzL3Rlc3Rpbmcv c2VsZnRlc3RzL3N5bmMvc3dfc3luYy5oCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCB0b29scy90ZXN0 aW5nL3NlbGZ0ZXN0cy9zeW5jL3N5bmMuYwo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgdG9vbHMvdGVz dGluZy9zZWxmdGVzdHMvc3luYy9zeW5jLmgKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IHRvb2xzL3Rl c3Rpbmcvc2VsZnRlc3RzL3N5bmMvc3luY19hbGxvYy5jCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCB0 b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9zeW5jL3N5bmNfZGVzdHJveWVkLmMKPiAgY3JlYXRlIG1v ZGUgMTAwNjQ0IHRvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL3N5bmMvc3luY19mZW5jZS5jCj4gIGNy ZWF0ZSBtb2RlIDEwMDY0NCB0b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9zeW5jL3N5bmNfbWVyZ2Uu Ywo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvc3luYy9zeW5j X3N0cmVzc19jb25zdW1lci5jCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCB0b29scy90ZXN0aW5nL3Nl bGZ0ZXN0cy9zeW5jL3N5bmNfc3RyZXNzX21lcmdlLmMKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IHRv b2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL3N5bmMvc3luY19zdHJlc3NfcGFyYWxsZWxpc20uYwo+ICBj cmVhdGUgbW9kZSAxMDA2NDQgdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvc3luYy9zeW5jX3Rlc3Qu Ywo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvc3luYy9zeW5j X3dhaXQuYwo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvc3lu Yy9zeW5jdGVzdC5oCj4gCgoKLS0gClNodWFoIEtoYW4KU3IuIExpbnV4IEtlcm5lbCBEZXZlbG9w ZXIKT3BlbiBTb3VyY2UgSW5ub3ZhdGlvbiBHcm91cApTYW1zdW5nIFJlc2VhcmNoIEFtZXJpY2Eg KFNpbGljb24gVmFsbGV5KQpzaHVhaGtoQG9zZy5zYW1zdW5nLmNvbSB8ICg5NzApIDIxNy04OTc4 Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRldmVsIG1h aWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2plY3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYu bGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933221AbcCIQNG (ORCPT ); Wed, 9 Mar 2016 11:13:06 -0500 Received: from lists.s-osg.org ([54.187.51.154]:39426 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753708AbcCIQND (ORCPT ); Wed, 9 Mar 2016 11:13:03 -0500 Subject: Re: [RFC PATCH v1 0/9] Tests for sync infrastructure To: =?UTF-8?Q?Emilio_L=c3=b3pez?= References: <1457537342-678-1-git-send-email-emilio.lopez@collabora.co.uk> Cc: devel@driverdev.osuosl.org, Gustavo Padovan , Riley Andrews , Daniel Vetter , John Harrison , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Greg Hackmann , Rob Clark , linux-kselftest@vger.kernel.org, Maarten Lankhorst , Daniel Stone , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Shuah Khan From: Shuah Khan Organization: Samsung Open Source Group Message-ID: <56E04B8C.7000504@osg.samsung.com> Date: Wed, 9 Mar 2016 09:13:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457537342-678-1-git-send-email-emilio.lopez@collabora.co.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/2016 08:28 AM, Emilio López wrote: > Hello everyone, > > This is a series of tests to exercise the sync kernel infrastructure. It is > meant to be a test suite for the work Gustavo has been doing to destage it, > see [0] for his latest series to date. > > These tests were originally part of a battery of tests shipping with > Android's libsync that were rewritten to use the new userspace interfaces. > > As usual, all comments are welcome. > > Cheers! > Emilio > > [0] https://lists.freedesktop.org/archives/dri-devel/2016-March/102204.html Good to see this suite added to Kselftest. Thanks for being thorough and including .gitignore. Are there any destructive and/or longer time tests in this suite. If so could you please make them optional to run. Please see selftests/timers as an example for excluding. More comments on individual patches to follow. thanks, -- Shuah > > > Emilio López (9): > selftest: sync: basic tests for sw_sync framework > selftest: sync: fence tests for sw_sync framework > selftest: sync: merge tests for sw_sync framework > selftest: sync: wait tests for sw_sync framework > selftest: sync: destruction tests for sw_sync framework > selftest: sync: stress test for parallelism > selftest: sync: stress consumer/producer test > selftest: sync: stress test for merges > selftest: sync: disable tests that rely on not yet defined behaviour > > tools/testing/selftests/Makefile | 1 + > tools/testing/selftests/sync/.gitignore | 1 + > tools/testing/selftests/sync/Makefile | 28 +++ > tools/testing/selftests/sync/sw_sync.h | 46 +++++ > tools/testing/selftests/sync/sync.c | 203 +++++++++++++++++++++ > tools/testing/selftests/sync/sync.h | 119 ++++++++++++ > tools/testing/selftests/sync/sync_alloc.c | 74 ++++++++ > tools/testing/selftests/sync/sync_destroyed.c | 90 +++++++++ > tools/testing/selftests/sync/sync_fence.c | 134 ++++++++++++++ > tools/testing/selftests/sync/sync_merge.c | 60 ++++++ > .../testing/selftests/sync/sync_stress_consumer.c | 185 +++++++++++++++++++ > tools/testing/selftests/sync/sync_stress_merge.c | 115 ++++++++++++ > .../selftests/sync/sync_stress_parallelism.c | 111 +++++++++++ > tools/testing/selftests/sync/sync_test.c | 87 +++++++++ > tools/testing/selftests/sync/sync_wait.c | 95 ++++++++++ > tools/testing/selftests/sync/synctest.h | 69 +++++++ > 16 files changed, 1418 insertions(+) > create mode 100644 tools/testing/selftests/sync/.gitignore > create mode 100644 tools/testing/selftests/sync/Makefile > create mode 100644 tools/testing/selftests/sync/sw_sync.h > create mode 100644 tools/testing/selftests/sync/sync.c > create mode 100644 tools/testing/selftests/sync/sync.h > create mode 100644 tools/testing/selftests/sync/sync_alloc.c > create mode 100644 tools/testing/selftests/sync/sync_destroyed.c > create mode 100644 tools/testing/selftests/sync/sync_fence.c > create mode 100644 tools/testing/selftests/sync/sync_merge.c > create mode 100644 tools/testing/selftests/sync/sync_stress_consumer.c > create mode 100644 tools/testing/selftests/sync/sync_stress_merge.c > create mode 100644 tools/testing/selftests/sync/sync_stress_parallelism.c > create mode 100644 tools/testing/selftests/sync/sync_test.c > create mode 100644 tools/testing/selftests/sync/sync_wait.c > create mode 100644 tools/testing/selftests/sync/synctest.h > -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978