From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [RFC PATCH v1 9/9] selftest: sync: disable tests that rely on not yet defined behaviour Date: Wed, 9 Mar 2016 09:14:14 -0700 Message-ID: <56E04BD6.9050502@osg.samsung.com> References: <1457537342-678-1-git-send-email-emilio.lopez@collabora.co.uk> <1457537342-678-10-git-send-email-emilio.lopez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1457537342-678-10-git-send-email-emilio.lopez@collabora.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: =?UTF-8?Q?Emilio_L=c3=b3pez?= Cc: devel@driverdev.osuosl.org, Rob Clark , Daniel Stone , Daniel Vetter , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Maarten Lankhorst , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Shuah Khan , Riley Andrews , Greg Hackmann , linux-kselftest@vger.kernel.org, Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gMDMvMDkvMjAxNiAwODoyOSBBTSwgRW1pbGlvIEzDs3BleiB3cm90ZToKPiBPbmUgb2YgdGhl IHRlc3RzIHJlbHkgb24gYSBiZWhhdmlvdXIgb25seSBvYnNlcnZlZCBvbiB0aGUgZHJpdmVyIGN1 cnJlbnRseQo+IGluIHVzZSBpbiBBbmRyb2lkLiBEaXNhYmxlIGl0IGhlcmUgdW50aWwgdGhlIGJl aGF2aW91ciBpcyBpbXBsZW1lbnRlZAo+IG9yIGl0IGlzIGRlY2lkZWQgaXQgc2hvdWxkIG5vdCBi ZSBpbXBsZW1lbnRlZCBvbiB0aGUgZHJpdmVyIGluIG1haW5saW5lLgo+IAo+IFNpZ25lZC1vZmYt Ynk6IEVtaWxpbyBMw7NwZXogPGVtaWxpby5sb3BlekBjb2xsYWJvcmEuY28udWs+Cj4gCj4gLS0t Cj4gCj4gIHRvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL3N5bmMvc3luY190ZXN0LmMgfCA3ICsrKysr KysKPiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS90 b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9zeW5jL3N5bmNfdGVzdC5jIGIvdG9vbHMvdGVzdGluZy9z ZWxmdGVzdHMvc3luYy9zeW5jX3Rlc3QuYwo+IGluZGV4IGMzZTRjMDEuLjNmNDg0MzE4IDEwMDY0 NAo+IC0tLSBhL3Rvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL3N5bmMvc3luY190ZXN0LmMKPiArKysg Yi90b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9zeW5jL3N5bmNfdGVzdC5jCj4gQEAgLTY2LDcgKzY2 LDE0IEBAIGludCBtYWluKHZvaWQpCj4gIAllcnIgKz0gUlVOX1RFU1QodGVzdF9mZW5jZV9vbmVf dGltZWxpbmVfbWVyZ2UpOwo+ICAJZXJyICs9IFJVTl9URVNUKHRlc3RfZmVuY2VfbWVyZ2Vfc2Ft ZV9mZW5jZSk7Cj4gIAllcnIgKz0gUlVOX1RFU1QodGVzdF9mZW5jZV9tdWx0aV90aW1lbGluZV93 YWl0KTsKPiArI2lmIDAKPiArCS8qIFRoZSBmb2xsb3dpbmcgdGVzdCBoYXMgYmVlbiBkaXNhYmxl ZCBkdWUgdG8gZGlmZmVyZW5jZXMKPiArCSAqIGJldHdlZW4gdGhlIHVwc3RyZWFtIGFuZCBBbmRy b2lkIGtlcm5lbCBkcml2ZXJzLiBUaGUgYmVoYXZpb3VyCj4gKwkgKiB0aGF0IHNob3VsZCBvY2N1 ciB3aGVuIGRlc3Ryb3lpbmcgYSB0aW1lbGluZSB3aXRoIGFjdGl2ZSBmZW5jZXMKPiArCSAqIGhh cyBub3QgYmVlbiBkZWZpbmVkIHlldC4KPiArCSAqLwo+ICAJZXJyICs9IFJVTl9URVNUKHRlc3Rf ZmVuY2Vfd2FpdF9vbl9kZXN0cm95ZWRfdGltZWxpbmUpOwo+ICsjZW5kaWYKCkl0IHdvdWxkIGJl IHVzZWZ1bCB0byBoYXZlIGEgcmVhbCBkZWZpbmUgaGVyZSB0aGF0IGNhbiBiZQplbmFibGVkIGxh dGVyIGVhc2lseSBpbnN0ZWFkIG9mIGlmIDAuCgp0aGFua3MsCi0tIFNodWFoCgo+ICAJZXJyICs9 IFJVTl9URVNUKHRlc3Rfc3RyZXNzX3R3b190aHJlYWRzX3NoYXJlZF90aW1lbGluZSk7Cj4gIAll cnIgKz0gUlVOX1RFU1QodGVzdF9jb25zdW1lcl9zdHJlc3NfbXVsdGlfcHJvZHVjZXJfc2luZ2xl X2NvbnN1bWVyKTsKPiAgCWVyciArPSBSVU5fVEVTVCh0ZXN0X21lcmdlX3N0cmVzc19yYW5kb21f bWVyZ2UpOwo+IAoKCi0tIApTaHVhaCBLaGFuClNyLiBMaW51eCBLZXJuZWwgRGV2ZWxvcGVyCk9w ZW4gU291cmNlIElubm92YXRpb24gR3JvdXAKU2Ftc3VuZyBSZXNlYXJjaCBBbWVyaWNhIChTaWxp Y29uIFZhbGxleSkKc2h1YWhraEBvc2cuc2Ftc3VuZy5jb20gfCAoOTcwKSAyMTctODk3OApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBtYWlsaW5n IGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2LmxpbnV4 ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933227AbcCIQOW (ORCPT ); Wed, 9 Mar 2016 11:14:22 -0500 Received: from lists.s-osg.org ([54.187.51.154]:39440 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933057AbcCIQOQ (ORCPT ); Wed, 9 Mar 2016 11:14:16 -0500 Subject: Re: [RFC PATCH v1 9/9] selftest: sync: disable tests that rely on not yet defined behaviour To: =?UTF-8?Q?Emilio_L=c3=b3pez?= References: <1457537342-678-1-git-send-email-emilio.lopez@collabora.co.uk> <1457537342-678-10-git-send-email-emilio.lopez@collabora.co.uk> Cc: devel@driverdev.osuosl.org, Gustavo Padovan , Riley Andrews , Daniel Vetter , John Harrison , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Greg Hackmann , Rob Clark , linux-kselftest@vger.kernel.org, Maarten Lankhorst , Daniel Stone , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Shuah Khan From: Shuah Khan Organization: Samsung Open Source Group Message-ID: <56E04BD6.9050502@osg.samsung.com> Date: Wed, 9 Mar 2016 09:14:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457537342-678-10-git-send-email-emilio.lopez@collabora.co.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/2016 08:29 AM, Emilio López wrote: > One of the tests rely on a behaviour only observed on the driver currently > in use in Android. Disable it here until the behaviour is implemented > or it is decided it should not be implemented on the driver in mainline. > > Signed-off-by: Emilio López > > --- > > tools/testing/selftests/sync/sync_test.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/testing/selftests/sync/sync_test.c b/tools/testing/selftests/sync/sync_test.c > index c3e4c01..3f484318 100644 > --- a/tools/testing/selftests/sync/sync_test.c > +++ b/tools/testing/selftests/sync/sync_test.c > @@ -66,7 +66,14 @@ int main(void) > err += RUN_TEST(test_fence_one_timeline_merge); > err += RUN_TEST(test_fence_merge_same_fence); > err += RUN_TEST(test_fence_multi_timeline_wait); > +#if 0 > + /* The following test has been disabled due to differences > + * between the upstream and Android kernel drivers. The behaviour > + * that should occur when destroying a timeline with active fences > + * has not been defined yet. > + */ > err += RUN_TEST(test_fence_wait_on_destroyed_timeline); > +#endif It would be useful to have a real define here that can be enabled later easily instead of if 0. thanks, -- Shuah > err += RUN_TEST(test_stress_two_threads_shared_timeline); > err += RUN_TEST(test_consumer_stress_multi_producer_single_consumer); > err += RUN_TEST(test_merge_stress_random_merge); > -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978