Re: [PULL] bcache: fix cache_set_flush() NULL pointer dereference on OOM

[Jens Axboe <axboe@kernel.dk>]

On 03/08/2016 08:36 PM, Eric Wheeler wrote:
> On Tue, 8 Mar 2016, Jens Axboe wrote:
>
>> On 03/07/2016 04:36 PM, Eric Wheeler wrote:
>>> Hi Jens,
>>>
>>> Here is another OOM fix for bcache.  Please pull:
>>>
>>>     git pull https://bitbucket.org/ewheelerinc/linux.git
>>>     v4.5-rc7-bcache-fixes
>>>
>>>    # git diff --stat v4.5-rc7
>>>    drivers/md/bcache/super.c | 3 +++
>>>    1 file changed, 3 insertions(+)
>>
>> I pulled this and the previous, but for 4.6. They are all marked stable, so
>> that should be fine.
>>
>> Note that your 2nd patch in the -rc6 branch, this one:
>>
>> bcache: cleaned up error handling around register_cache()
>>
>> had a 4 cases of trailing white space. Please ensure that future patches are
>> cleaned up, I fixed that one up.
>
> Interesting, do you mean whitespace at the end of a line with code or
> empty lines containing whitespace or both?  Something matched by [ ]+$  ?

Both. You had both trailing white space at the end of a line, and a 
space at the start of a new line.

> Is it acceptable to have empty likes whith whitespace leading up to the
> indent level?  eg:
> 	if (1) {
> 		foo
> 		<<whitespace-to-here but line is blank
> 		bar
> 	}

Nope

-- 
Jens Axboe