From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/6] ASoC: Intel: allow for DW_DMAC_CORE as module
Date: Wed, 9 Mar 2016 11:06:39 -0600 [thread overview]
Message-ID: <56E0581F.10500@linux.intel.com> (raw)
In-Reply-To: <20160309024326.GE3898@sirena.org.uk>
On 3/8/16 8:43 PM, Mark Brown wrote:
> On Mon, Mar 07, 2016 at 11:49:29AM -0600, Pierre-Louis Bossart wrote:
>> On 3/4/16 10:03 PM, Mark Brown wrote:
>>> On Thu, Mar 03, 2016 at 09:36:33PM -0600, Pierre-Louis Bossart wrote:
>
>>>> - depends on DW_DMAC_CORE=y && (SND_SST_IPC_ACPI = n)
>>>> + depends on (DW_DMAC_CORE != n) && (SND_SST_IPC_ACPI = n)
>
>>> What is the expected difference between a dependency on DW_DMAC_CORE and
>>> one on DW_DMAC_CORE != n?
>
>> No functional difference, it's more to make the menuconfig options more
>> obvious.
>> Without this patch, menuconfig will not show the legacy byt-max98090 and
>> byt-rt5640 options if the DW_DMAC_CORE is built as a module.
>> While we want to encourage folks to use the newer DPCM drivers, we also want
>> to leave these options accessible.
>
> My point is that you've written the above in a very confusing manner - I
> have to think about what it means while just a dependency would be clear
> and obvious.
Are you asking about the intent/functionality or just a simplification
to do this (un-tested):
depends on DW_DMAC_CORE && (SND_SST_IPC_ACPI = n)
next prev parent reply other threads:[~2016-03-09 17:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 3:36 [PATCH 0/6] Support for CherryTrail devices Pierre-Louis Bossart
2016-03-04 3:36 ` [PATCH 1/6] ASoC: Intel: allow for DW_DMAC_CORE as module Pierre-Louis Bossart
2016-03-05 4:03 ` Mark Brown
2016-03-07 17:49 ` Pierre-Louis Bossart
2016-03-09 2:43 ` Mark Brown
2016-03-09 17:06 ` Pierre-Louis Bossart [this message]
2016-03-09 17:19 ` Takashi Iwai
2016-03-10 5:45 ` Mark Brown
2016-03-04 3:36 ` [PATCH 2/6] ASoC: Intel: common: filter ACPI devices with _STA return value Pierre-Louis Bossart
2016-03-05 12:25 ` Applied "ASoC: Intel: common: filter ACPI devices with _STA return value" to the asoc tree Mark Brown
2016-03-04 3:36 ` [PATCH 2/6] ASoC: Intel: filter ACPI devices based on _STA return value Pierre-Louis Bossart
2016-03-04 3:36 ` [PATCH 3/6] ASoC: Intel: common: add translation from HID to codec-name Pierre-Louis Bossart
2016-03-05 12:25 ` Applied "ASoC: Intel: common: add translation from HID to codec-name" to the asoc tree Mark Brown
2016-03-04 3:36 ` [PATCH 4/6] ASoC: Intel: bytcr_rt5640: change quirk position Pierre-Louis Bossart
2016-03-05 12:25 ` Applied "ASoC: Intel: bytcr_rt5640: change quirk position" to the asoc tree Mark Brown
2016-03-04 3:36 ` [PATCH 5/6] ASoC: Intel: bytcr_rt5640: use HID translation util Pierre-Louis Bossart
2016-03-05 12:25 ` Applied "ASoC: Intel: bytcr_rt5640: use HID translation util" to the asoc tree Mark Brown
2016-03-04 3:36 ` [PATCH 6/6] ASoC: Intel: Atom: add support for CHT w/ RT5640 Pierre-Louis Bossart
2016-03-05 12:24 ` Applied "ASoC: Intel: Atom: add support for CHT w/ RT5640" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E0581F.10500@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.