Re: [Qemu-devel] [PATCH v2 01/10] qdict: implement a qdict_crumple method for un-flattening a dict

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1809 bytes --]

On 09.03.2016 19:07, Daniel P. Berrange wrote:
> On Mon, Mar 07, 2016 at 06:23:35PM +0100, Max Reitz wrote:
>> On 07.03.2016 16:43, Daniel P. Berrange wrote:

[...]

>>> +static void qdict_crumple_test_recursive(void)
>>> +{
>>> +    QDict *src, *dst, *rule;
>>> +    QObject *child;
>>> +    QList *rules;
>>> +
>>> +    src = qdict_new();
>>> +    qdict_put(src, "rule.0.match", qstring_from_str("fred"));
>>> +    qdict_put(src, "rule.0.policy", qstring_from_str("allow"));
>>> +    qdict_put(src, "rule.1.match", qstring_from_str("bob"));
>>> +    qdict_put(src, "rule.1.policy", qstring_from_str("deny"));
>>> +
>>> +    dst = (QDict *)qdict_crumple(src, true, &error_abort);
>>> +
>>> +    g_assert_cmpint(qdict_size(dst), ==, 1);
>>> +
>>> +    child = qdict_get(dst, "rule");
>>> +    g_assert_cmpint(qobject_type(child), ==, QTYPE_QLIST);
>>> +
>>> +    rules = qdict_get_qlist(dst, "rule");
>>> +    g_assert_cmpint(qlist_size(rules), ==, 2);
>>> +
>>> +    rule = qobject_to_qdict(qlist_pop(rules));
>>
>> g_assert_cmpint(qdict_size(rule), ==, 2); ?
>>
>>> +    g_assert_cmpstr("fred", ==, qdict_get_str(rule, "match"));
>>> +    g_assert_cmpstr("allow", ==, qdict_get_str(rule, "policy"));
>>> +    QDECREF(rule);
>>> +
>>> +    rule = qobject_to_qdict(qlist_pop(rules));
>>
>>
>> g_assert_cmpint(qdict_size(rule), ==, 2); ?
>>
>>> +    g_assert_cmpstr("bob", ==, qdict_get_str(rule, "match"));
>>> +    g_assert_cmpstr("deny", ==, qdict_get_str(rule, "policy"));
>>> +    QDECREF(rule);
>>> +
>>> +    QDECREF(src);
>>> +    QDECREF(dst);
>>
>> QDECREF(rules);
> 
> rules is a borrowed reference, so we can't decrement it.

Oops, right. :-)

I suppose it looked so tempting to me because of the QDECREF(rule) for
the pop'ed rules.

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]