From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adnWy-0004b8-UI for qemu-devel@nongnu.org; Wed, 09 Mar 2016 18:28:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adnWv-0003kG-Pb for qemu-devel@nongnu.org; Wed, 09 Mar 2016 18:28:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adnWv-0003kA-Ko for qemu-devel@nongnu.org; Wed, 09 Mar 2016 18:28:37 -0500 References: <1457194595-16189-1-git-send-email-eblake@redhat.com> <1457194595-16189-6-git-send-email-eblake@redhat.com> <87d1r580q0.fsf@blackfin.pond.sub.org> <56DEF9CB.6020601@redhat.com> From: Eric Blake Message-ID: <56E0B1A4.6000902@redhat.com> Date: Wed, 9 Mar 2016 16:28:36 -0700 MIME-Version: 1.0 In-Reply-To: <56DEF9CB.6020601@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="buNbn9CaaAmqk8ioKJ9QMlMn6FBhBAGwK" Subject: Re: [Qemu-devel] [PATCH v4 05/10] qapi: Utilize implicit struct visits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --buNbn9CaaAmqk8ioKJ9QMlMn6FBhBAGwK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/08/2016 09:11 AM, Eric Blake wrote: >>> >>> - ret +=3D gen_visit_members(arg_type.members, skiperr=3Ddealloc) >> >> Unless I'm mistaken, this is the only use of skiperr. Follow up with = a >> patch to drop the parameter and simplify? >=20 > Oh, nice. I noticed some cleanups in patch 6/10, but missed this one a= s > a reasonable improvement. >=20 > In fact, gen_visit_members() is now only used in qapi-visits.py, so > maybe I can move it back there (it used to live there before commit > 82ca8e469 moved it for sharing with the two files simplified here). In fact, this also nukes the only use of c_null(). I'll have a couple of cleanup patches in v5. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --buNbn9CaaAmqk8ioKJ9QMlMn6FBhBAGwK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW4LGkAAoJEKeha0olJ0Nq/uYH/ihJurJjbWolKs7Fn8WFAZse 06zyelYC1ghBPeB9G4IJXMlup8LsmUXTON05rchDLeedNSFYXzUFmPCJXVxZbcbr mOFzCp7cW0jdoDJ0jxc9RlVWRV+uRI53oQBpPdqkfkzXDHG/sO05tV0PF2Ndk8Vb /7swMci04S+jTlmJPOlykMVWknVzULSgdfI6wu19ZbUHJigZI29JdAG/wGE++HY/ gfSaRRhfBlvsH6L8ZcZSc8UxLU/zWh55gkH+5akUOTF8NpDufHHLvj18276r6/bb kARDg81JZZ8H6ZuRfTvFVMEAVbnVXOH9H9SRos4bgDUH8mffbXLb9W9x4u3dZ4c= =oekm -----END PGP SIGNATURE----- --buNbn9CaaAmqk8ioKJ9QMlMn6FBhBAGwK--